public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Require debug info for gdb.tui/tui-layout-asm-short-prog.exp
@ 2022-12-08 14:35 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2022-12-08 14:35 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2d77a94ff17a81260b80997db476f87cba5f4b11

commit 2d77a94ff17a81260b80997db476f87cba5f4b11
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Dec 8 15:35:47 2022 +0100

    [gdb/testsuite] Require debug info for gdb.tui/tui-layout-asm-short-prog.exp
    
    When running test-case gdb.tui/tui-layout-asm-short-prog.exp on SLE-12-SP3
    aarch64, I run into:
    ...
    FAIL: gdb.tui/tui-layout-asm-short-prog.exp: check asm box contents
    FAIL: gdb.tui/tui-layout-asm-short-prog.exp: check asm box contents again
    ...
    due to:
    ...
    (gdb) file tui-layout-asm-short-prog^M
    Reading symbols from tui-layout-asm-short-prog...^M
    (No debugging symbols found in tui-layout-asm-short-prog)^M
    ...
    
    I managed to reproduce the same behaviour on openSUSE Leap 15.4 x86_64, by
    removing the debug option.
    
    Fix this by making the test-case unsupported if no debug info is found.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp b/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp
index a6be799113d..bda1c02fe9a 100644
--- a/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp
+++ b/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp
@@ -32,6 +32,11 @@ if {![Term::prepare_for_tui]} {
     return
 }
 
+if { $gdb_file_cmd_debug_info == "nodebug" } {
+    unsupported "no debug info"
+    return
+}
+
 # This puts us into TUI mode, and should display the ASM window.
 Term::command_no_prompt_prefix "layout asm"
 Term::check_box_contents "check asm box contents" 0 0 80 15 "<_start>"

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-12-08 14:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-08 14:35 [binutils-gdb] [gdb/testsuite] Require debug info for gdb.tui/tui-layout-asm-short-prog.exp Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).