public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Hannes Domani <ssbssa@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Fix install-strip target
Date: Tue, 20 Dec 2022 19:39:50 +0000 (GMT)	[thread overview]
Message-ID: <20221220193950.D839A3857026@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a61ce0ce48c6353058f1b2214b0725f618ae7132

commit a61ce0ce48c6353058f1b2214b0725f618ae7132
Author: Hannes Domani <ssbssa@yahoo.de>
Date:   Mon Dec 19 17:29:27 2022 +0100

    Fix install-strip target
    
    The libtool patch broke install-strip of gdb:
    
    /bin/sh ../../gdb/../mkinstalldirs /src/gdb/inst/share/gdb/python/gdb
    transformed_name=`t='s,y,y,'; \
                      echo gdb | sed -e "$t"` ; \
            if test "x$transformed_name" = x; then \
              transformed_name=gdb ; \
            else \
              true ; \
            fi ; \
            /bin/sh ../../gdb/../mkinstalldirs /src/gdb/inst/bin ; \
            /bin/sh ./libtool --mode=install STRIPPROG='strip' /bin/sh /src/gdb/gdb.git/install-sh -c -s \
                    gdb \
                    /src/gdb/inst/bin/$transformed_name ; \
            /bin/sh ../../gdb/../mkinstalldirs /src/gdb/inst/include/gdb ; \
            /usr/bin/install -c -m 644 jit-reader.h /src/gdb/inst/include/gdb/jit-reader.h
    libtool: install: `/src/gdb/inst/bin/gdb' is not a directory
    libtool: install: Try `libtool --help --mode=install' for more information.
    
    Since INSTALL_PROGRAM_ENV is no longer at the beginning of the command, the
    gdb executable is not installed with install-strip.

Diff:
---
 gdb/Makefile.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index fb4d42c7baa..192f8086aec 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -2020,7 +2020,7 @@ install-only: $(CONFIG_INSTALL)
 		  true ; \
 		fi ; \
 		$(SHELL) $(srcdir)/../mkinstalldirs $(DESTDIR)$(bindir) ; \
-		$(LIBTOOL) --mode=install $(INSTALL_PROGRAM_ENV) $(INSTALL_PROGRAM) \
+		$(INSTALL_PROGRAM_ENV) $(LIBTOOL) --mode=install $(INSTALL_PROGRAM) \
 			gdb$(EXEEXT) \
 			$(DESTDIR)$(bindir)/$$transformed_name$(EXEEXT) ; \
 		$(SHELL) $(srcdir)/../mkinstalldirs $(DESTDIR)$(includedir)/gdb ; \
@@ -2533,7 +2533,7 @@ install-gdbtk:
 	  true ; \
 	fi ; \
 	$(SHELL) $(srcdir)/../mkinstalldirs $(DESTDIR)$(bindir); \
-	$(LIBTOOL) --mode=install $(INSTALL_PROGRAM_ENV) $(INSTALL_PROGRAM) \
+	$(INSTALL_PROGRAM_ENV) $(LIBTOOL) --mode=install $(INSTALL_PROGRAM) \
 		insight$(EXEEXT) \
 		$(DESTDIR)$(bindir)/$$transformed_name$(EXEEXT) ; \
 	$(SHELL) $(srcdir)/../mkinstalldirs \

                 reply	other threads:[~2022-12-20 19:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221220193950.D839A3857026@sourceware.org \
    --to=ssbssa@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).