public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Bruno Larsen <blarsen@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/testsuite: Fix FAILs in gdb.linespec/cpcompletion.exp when using clang Date: Fri, 6 Jan 2023 09:51:13 +0000 (GMT) [thread overview] Message-ID: <20230106095113.46DF43858D28@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=695e9773786d79f191e9487a88d3b39a57d9c7e7 commit 695e9773786d79f191e9487a88d3b39a57d9c7e7 Author: Bruno Larsen <blarsen@redhat.com> Date: Tue Jan 3 15:07:47 2023 +0100 gdb/testsuite: Fix FAILs in gdb.linespec/cpcompletion.exp when using clang When using clang 16.0.0 to test gdb.linespec/cpcompletion.exp, I get 99 unexpected failures. They all fail to produce a complete list of completion options for a function, either overload2_function, overload3_function or anon_ns_function. This happens because clang is optimizing them away, since they are never used. Fix this by adding __attribute__((used)) to all declarations to the aforementioned functions. Diff: --- gdb/testsuite/gdb.linespec/cpls.cc | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/gdb/testsuite/gdb.linespec/cpls.cc b/gdb/testsuite/gdb.linespec/cpls.cc index 037b5c28325..d63ed892564 100644 --- a/gdb/testsuite/gdb.linespec/cpls.cc +++ b/gdb/testsuite/gdb.linespec/cpls.cc @@ -56,16 +56,17 @@ struct overload2_arg9 {}; struct overload2_arga {}; #define GEN_OVERLOAD2_FUNCTIONS(ARG1, ARG2) \ - void \ + void __attribute__ ((used)) \ overload2_function (ARG1) \ {} \ \ struct struct_overload2_test \ { \ - void overload2_function (ARG2); \ + void __attribute__ ((used)) \ + overload2_function (ARG2); \ }; \ \ - void \ + void __attribute__ ((used)) \ struct_overload2_test::overload2_function (ARG2) \ {} @@ -99,23 +100,25 @@ namespace ns_overload2_test /* Code for the overload-3 test. */ #define GEN_OVERLOAD3_FUNCTIONS(ARG1, ARG2) \ - void \ + void __attribute__ ((used)) \ overload3_function (ARG1) \ {} \ - void \ + void __attribute__ ((used)) \ overload3_function (ARG2) \ {} \ \ struct struct_overload3_test \ { \ - void overload3_function (ARG1); \ - void overload3_function (ARG2); \ + void __attribute__ ((used)) \ + overload3_function (ARG1); \ + void __attribute__ ((used)) \ + overload3_function (ARG2); \ }; \ \ - void \ + void __attribute__ ((used)) \ struct_overload3_test::overload3_function (ARG1) \ {} \ - void \ + void __attribute__ ((used)) \ struct_overload3_test::overload3_function (ARG2) \ {} @@ -343,15 +346,15 @@ namespace ns2_incomplete_scope_colon_test namespace { - void anon_ns_function () + void __attribute__ ((used)) anon_ns_function () {} struct anon_ns_struct { - void anon_ns_function (); + void __attribute__ ((used)) anon_ns_function (); }; - void + void __attribute__ ((used)) anon_ns_struct::anon_ns_function () {} } @@ -361,15 +364,15 @@ namespace the_anon_ns_wrapper_ns namespace { - void anon_ns_function () + void __attribute__ ((used)) anon_ns_function () {} struct anon_ns_struct { - void anon_ns_function (); + void __attribute__ ((used)) anon_ns_function (); }; - void + void __attribute__ ((used)) anon_ns_struct::anon_ns_function () {} }
reply other threads:[~2023-01-06 9:51 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230106095113.46DF43858D28@sourceware.org \ --to=blarsen@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).