From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 562F53858C66; Thu, 12 Jan 2023 19:21:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 562F53858C66 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673551304; bh=1RXSoqj9LCGRWysgvAaHwmXmXsohZyxet+07whMRH7k=; h=From:To:Subject:Date:From; b=ZgYdtwecBFztFxUBlB7IKNHbJ+JH8FS7Pqi5vZFTjyDQupuiB0i2PKKbaJXdrekCn 0orImXTbDNOpaUoxX4psK8QVRcOG4LhFdzSm593gRmSIKCP4tp5/5oGbSObqNPdD9k 2v11nYCPydbhDa27AhJoLLD4OutvjQPZXF925K0A= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Disable ptype/o for dynamic types X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 1a26a53a0dee39106ba58fcb15496c5f13074652 X-Git-Newrev: 0c1aa2a09531b3256c8134258a2c75b694c9bd70 Message-Id: <20230112192144.562F53858C66@sourceware.org> Date: Thu, 12 Jan 2023 19:21:44 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D0c1aa2a09531= b3256c8134258a2c75b694c9bd70 commit 0c1aa2a09531b3256c8134258a2c75b694c9bd70 Author: Tom Tromey Date: Fri Jan 6 12:18:07 2023 -0700 Disable ptype/o for dynamic types =20 A user pointed out that "ptype/o" of a certain Ada type -- while in C mode -- caused gdb to crash. =20 The bug here is that dynamic types can't really be printed this way. This patch avoids the bug by disabling the "/o" feature in this case. =20 Note that using "ptype/o" in this way makes sense for the time being, because the Ada code doesn't support the "/o" feature (yet); and in any case gdb should not crash. Diff: --- gdb/testsuite/gdb.ada/ptype-o.exp | 47 ++++++++++++++++++++++++++++++= ++++ gdb/testsuite/gdb.ada/ptype-o/prog.adb | 29 +++++++++++++++++++++ gdb/typeprint.c | 6 +++++ 3 files changed, 82 insertions(+) diff --git a/gdb/testsuite/gdb.ada/ptype-o.exp b/gdb/testsuite/gdb.ada/ptyp= e-o.exp new file mode 100644 index 00000000000..987c6e729b4 --- /dev/null +++ b/gdb/testsuite/gdb.ada/ptype-o.exp @@ -0,0 +1,47 @@ +# Copyright 2023 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test that ptype/o of a dynamic type does not crash. + +load_lib "ada.exp" + +if { [skip_ada_tests] } { return -1 } + +standard_ada_testfile prog + +foreach_with_prefix scenario {all minimal} { + set flags [list debug additional_flags=3D-fgnat-encodings=3D$scenario] + + if {[gdb_compile_ada "${srcfile}" "${binfile}-${scenario}" executable = $flags] !=3D ""} { + return -1 + } + + clean_restart ${testfile}-${scenario} + + set bp_location [gdb_get_line_number "BREAK" ${testdir}/prog.adb] + runto "prog.adb:$bp_location" + + gdb_test "set lang c" \ + "Warning: the current language does not match this frame." + + if {$scenario =3D=3D "minimal"} { + set exp "ptype/o does not work with dynamic types.*" + } else { + # In "all" mode this prints nonsense, but at least does not + # crash. + set exp ".*" + } + gdb_test "ptype/o struct prog__rec" $exp +} diff --git a/gdb/testsuite/gdb.ada/ptype-o/prog.adb b/gdb/testsuite/gdb.ada= /ptype-o/prog.adb new file mode 100644 index 00000000000..1a3caad612e --- /dev/null +++ b/gdb/testsuite/gdb.ada/ptype-o/prog.adb @@ -0,0 +1,29 @@ +-- Copyright 2023 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see . + +procedure Prog is + type Index is range 0 .. 31; + type Char_Array is array ( Index range <>) of Character; + + type Rec (Length : Index) is + record + TV_Description : Char_Array (1 .. Length); + Note : Char_Array (1 .. Length); + end record; + + X : Rec (7); +begin + null; -- BREAK +end Prog; diff --git a/gdb/typeprint.c b/gdb/typeprint.c index 87df7f2ad35..41b57353ce1 100644 --- a/gdb/typeprint.c +++ b/gdb/typeprint.c @@ -539,6 +539,12 @@ whatis_exp (const char *exp, int show) type =3D value_type (val); } =20 + if (flags.print_offsets && is_dynamic_type (type)) + { + warning (_("ptype/o does not work with dynamic types; disabling '/o'= ")); + flags.print_offsets =3D 0; + } + get_user_print_options (&opts); if (val !=3D NULL && opts.objectprint) {