From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7850) id C6D013858C39; Fri, 13 Jan 2023 19:45:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C6D013858C39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673639109; bh=7NKgv4ev6owzGH14aK8Ki5ivqKgrRnlXPlpYeszrDYk=; h=From:To:Subject:Date:From; b=sp/3qKZykFOK2x+ZRy4iZt/XfZTkHunc2XkAGGErM0JjaQB9FO0a50iq7F2IHeb9Z +FllJlS0rJ/vzf5AB3vucNB+utb2I8AiiUbohqR1xUj3wdlGNTL6m6Cq3LwmSZupzQ EHOHtfsEQsdygEDuhhHQ1DPHUpwyTUy9qFLqIJOE= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Indu Bhagat To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org Subject: [binutils-gdb] libsframe: replace an strncat with strcat X-Act-Checkin: binutils-gdb X-Git-Author: Indu Bhagat X-Git-Refname: refs/heads/master X-Git-Oldrev: 027d8f7848f30e5b075dc0c9d74107a1747de190 X-Git-Newrev: 68e0003e12184a9bc13e06d35b6bb168f5f27ed3 Message-Id: <20230113194509.C6D013858C39@sourceware.org> Date: Fri, 13 Jan 2023 19:45:09 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D68e0003e1218= 4a9bc13e06d35b6bb168f5f27ed3 commit 68e0003e12184a9bc13e06d35b6bb168f5f27ed3 Author: Indu Bhagat Date: Fri Jan 13 11:15:43 2023 -0800 libsframe: replace an strncat with strcat =20 Calling strncat with the size of the src string is not so meaningful. The length argument to strncat should specify the remaining bytes bytes in the destination; although in this case, it appears to be unncessary altogether to use strncat in the first place. =20 libsframe/ * sframe-dump.c (dump_sframe_func_with_fres): Use of strcat is just as fine. Diff: --- libsframe/sframe-dump.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c index 320555a0a51..5417a16f48c 100644 --- a/libsframe/sframe-dump.c +++ b/libsframe/sframe-dump.c @@ -176,8 +176,7 @@ dump_sframe_func_with_fres (sframe_decoder_ctx *sfd_ctx, const char *ra_mangled_p_str =3D ((sframe_fre_get_ra_mangled_p (sfd_ctx, &fre, &err[2])) ? "[s]" : " "); - size_t ra_mangled_p_str_size =3D strlen (ra_mangled_p_str); - strncat (temp, ra_mangled_p_str, ra_mangled_p_str_size); + strcat (temp, ra_mangled_p_str); printf ("%-13s", temp); } }