From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 5912C3854806; Fri, 13 Jan 2023 20:34:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5912C3854806 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673642046; bh=sT2bk+Vj9e0Vu/S4PDXzXpVLMsWBREunvFxOLIw1xEQ=; h=From:To:Subject:Date:From; b=oiK+fx/iWFq3OEiCwI8z0J4NRZfywLYbQDZ7995Q74YXasicZTPf9ucBOtY3xZ/zg XarJUb0awEXsY/VqgG1fEbFIbRkIunRggH1F9xNtF1mxeLGDjfY8D8Zn0QubntW40V YT9/UUtuPr/G0G/1OTWt/h5F3R1gPqXF//GTZIvU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Use unsupported in 'require' X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 793862d2f427bdc7b80da5bb917acccb06c4ba61 X-Git-Newrev: fc5ab4bc44e77fbc5aee61d46e8b6f23bef8b371 Message-Id: <20230113203406.5912C3854806@sourceware.org> Date: Fri, 13 Jan 2023 20:34:06 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dfc5ab4bc44e7= 7fbc5aee61d46e8b6f23bef8b371 commit fc5ab4bc44e77fbc5aee61d46e8b6f23bef8b371 Author: Tom Tromey Date: Tue Dec 13 15:59:39 2022 -0700 Use unsupported in 'require' =20 This changes 'require' to use 'unsupported' rather than 'untested'. The latter doesn't really seem to be correct according to the DejaGNU documentation: =20 Declares a test was not run. `untested' writes in the log file a message beginning with _UNTESTED_, appending the `message' argument. For example, you might use this in a dummy test whose only role is = to record that a test does not yet exist for some feature. =20 The example there, and some text elsewhere, is what makes me think this isn't a great fit. On the other hand, 'unsupported' says: =20 Declares that a test case depends on some facility that does not ex= ist in the testing environment. Diff: --- gdb/testsuite/lib/gdb.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 88dfdafb654..3d416f902b8 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -9081,7 +9081,7 @@ proc require { args } { set fn $arg } if {$ok !=3D !![uplevel 1 $fn]} { - untested "require failed: $arg" + unsupported "require failed: $arg" return -code return 0 } }