From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 7C2863860744; Fri, 13 Jan 2023 20:34:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C2863860744 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673642056; bh=6NC8wvvPmddlK7a3APmAfTIgdpNuiV79FbIRrhfJnxQ=; h=From:To:Subject:Date:From; b=xzfqYNHPXEmEijbfwAAYz46jInzZog/mAtc6sIq4r/9MBTLNkU4JhcLEfeM9F8Nlv +g2yrcXe6sK4z4bIvW8Zs51LgD+wghwUGUaP12CV+0+BagVLLajdh7gxjQvCxYXQzB SjYFpXhC6W+hupyfWGUAxO2+yFezxpNH6S6CB26w= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Use require supports_process_record X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 5954db83d17f69ffecbf6a75eee4e08f53b237ca X-Git-Newrev: ade3e4f5b154f983dddff333edd8dd7445955b67 Message-Id: <20230113203416.7C2863860744@sourceware.org> Date: Fri, 13 Jan 2023 20:34:16 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dade3e4f5b154= f983dddff333edd8dd7445955b67 commit ade3e4f5b154f983dddff333edd8dd7445955b67 Author: Tom Tromey Date: Tue Dec 13 15:16:16 2022 -0700 Use require supports_process_record =20 This changes some tests to use "require supports_process_record". Diff: --- gdb/testsuite/gdb.mi/mi-record-changed.exp | 4 +--- gdb/testsuite/gdb.python/py-record-full.exp | 5 +---- gdb/testsuite/gdb.reverse/break-precsave.exp | 10 +++------- gdb/testsuite/gdb.reverse/consecutive-precsave.exp | 10 +++------- gdb/testsuite/gdb.reverse/i386-precsave.exp | 10 +++------- gdb/testsuite/gdb.reverse/machinestate-precsave.exp | 10 +++------- gdb/testsuite/gdb.reverse/solib-precsave.exp | 13 +++---------- gdb/testsuite/gdb.reverse/step-precsave.exp | 10 +++------- gdb/testsuite/gdb.reverse/until-precsave.exp | 10 +++------- gdb/testsuite/gdb.reverse/watch-precsave.exp | 10 +++------- 10 files changed, 26 insertions(+), 66 deletions(-) diff --git a/gdb/testsuite/gdb.mi/mi-record-changed.exp b/gdb/testsuite/gdb= .mi/mi-record-changed.exp index c324e8a31e7..c5fb6355a6c 100644 --- a/gdb/testsuite/gdb.mi/mi-record-changed.exp +++ b/gdb/testsuite/gdb.mi/mi-record-changed.exp @@ -13,9 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . =20 -if ![supports_process_record] { - return -} +require supports_process_record =20 standard_testfile basics.c if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \ diff --git a/gdb/testsuite/gdb.python/py-record-full.exp b/gdb/testsuite/gd= b.python/py-record-full.exp index 07fa6a1d5c5..fe19d6b207c 100644 --- a/gdb/testsuite/gdb.python/py-record-full.exp +++ b/gdb/testsuite/gdb.python/py-record-full.exp @@ -17,10 +17,7 @@ =20 # Skip this test if target does not support recording. =20 -if { ![supports_process_record] } { - untested "skipping recording tests" - return -1 -} +require supports_process_record =20 load_lib gdb-python.exp =20 diff --git a/gdb/testsuite/gdb.reverse/break-precsave.exp b/gdb/testsuite/g= db.reverse/break-precsave.exp index b41c3621729..2f04cbe0057 100644 --- a/gdb/testsuite/gdb.reverse/break-precsave.exp +++ b/gdb/testsuite/gdb.reverse/break-precsave.exp @@ -17,9 +17,7 @@ # with breakpoints in a process record logfile. =20 # This test suitable only for process record-replay -if ![supports_process_record] { - return -} +require supports_process_record =20 standard_testfile break-reverse.c set precsave [standard_output_file break.precsave] @@ -39,10 +37,8 @@ proc precsave_tests {} { =20 runto_main =20 - if [supports_process_record] { - # Activate process record/replay - gdb_test_no_output "record" "turn on process record" - } + # Activate process record/replay + gdb_test_no_output "record" "turn on process record" =20 gdb_test "break $end_location" \ "Breakpoint $decimal at .*$srcfile, line $end_location\." \ diff --git a/gdb/testsuite/gdb.reverse/consecutive-precsave.exp b/gdb/tests= uite/gdb.reverse/consecutive-precsave.exp index 3c8696df6de..a0a4ed0014f 100644 --- a/gdb/testsuite/gdb.reverse/consecutive-precsave.exp +++ b/gdb/testsuite/gdb.reverse/consecutive-precsave.exp @@ -17,9 +17,7 @@ # consecutive instructions in a process record logfile. =20 # This test suitable only for process record-replay -if ![supports_process_record] { - return -} +require supports_process_record =20 standard_testfile consecutive-reverse.c set precsave [standard_output_file consecutive.precsave] @@ -30,10 +28,8 @@ if { [prepare_for_testing "failed to prepare" $testfile = $srcfile] } { =20 runto_main =20 -if [supports_process_record] { - # Activate process record/replay - gdb_test_no_output "record" "turn on process record" -} +# Activate process record/replay +gdb_test_no_output "record" "turn on process record" =20 set is_stmt [is_stmt_addresses $srcfile] =20 diff --git a/gdb/testsuite/gdb.reverse/i386-precsave.exp b/gdb/testsuite/gd= b.reverse/i386-precsave.exp index 7ab2f54a95a..301e3b60208 100644 --- a/gdb/testsuite/gdb.reverse/i386-precsave.exp +++ b/gdb/testsuite/gdb.reverse/i386-precsave.exp @@ -20,9 +20,7 @@ # =20 # This test suitable only for process record-replay -if ![supports_process_record] { - return -} +require supports_process_record =20 =20 if {![is_x86_like_target]} { @@ -46,10 +44,8 @@ set end_of_inc_dec_tests [gdb_get_line_number " end inc_= dec_tests "] =20 runto_main =20 -if [supports_process_record] { - # Activate process record/replay - gdb_test_no_output "record" "turn on process record" -} +# Activate process record/replay +gdb_test_no_output "record" "turn on process record" =20 global hex global decimal diff --git a/gdb/testsuite/gdb.reverse/machinestate-precsave.exp b/gdb/test= suite/gdb.reverse/machinestate-precsave.exp index 678aac8dc58..fd53806e467 100644 --- a/gdb/testsuite/gdb.reverse/machinestate-precsave.exp +++ b/gdb/testsuite/gdb.reverse/machinestate-precsave.exp @@ -36,9 +36,7 @@ # =20 # This test suitable only for process record-replay -if ![supports_process_record] { - return -} +require supports_process_record =20 standard_testfile machinestate.c ms1.c set precsave [standard_output_file machinestate.precsave] @@ -57,10 +55,8 @@ set endmain [gdb_get_line_number " end main " $srcfi= le] =20 runto_main =20 -if [supports_process_record] { - # Activate process record/replay - gdb_test_no_output "record" "turn on process record" -} +# Activate process record/replay +gdb_test_no_output "record" "turn on process record" =20 gdb_test "break $endmain" \ "Breakpoint $decimal at .*$srcfile, line $endmain\." \ diff --git a/gdb/testsuite/gdb.reverse/solib-precsave.exp b/gdb/testsuite/g= db.reverse/solib-precsave.exp index 518a45b98dc..92d0a0d30a0 100644 --- a/gdb/testsuite/gdb.reverse/solib-precsave.exp +++ b/gdb/testsuite/gdb.reverse/solib-precsave.exp @@ -17,12 +17,7 @@ # with shared libraries and a logfile. =20 # This test suitable only for process record-replay -if ![supports_process_record] { - return -} -if {[skip_shlib_tests]} { - return -} +require supports_process_record !skip_shlib_tests =20 standard_testfile solib-reverse.c set precsave [standard_output_file solib.precsave] @@ -77,10 +72,8 @@ gdb_load_shlib $library2 =20 runto_main =20 -if [supports_process_record] { - # Activate process record/replay - gdb_test_no_output "record" "turn on process record" -} +# Activate process record/replay +gdb_test_no_output "record" "turn on process record" =20 set end_of_main [gdb_get_line_number "end of main" ] gdb_test "break $end_of_main" \ diff --git a/gdb/testsuite/gdb.reverse/step-precsave.exp b/gdb/testsuite/gd= b.reverse/step-precsave.exp index ec12389fc45..19cd5d9930e 100644 --- a/gdb/testsuite/gdb.reverse/step-precsave.exp +++ b/gdb/testsuite/gdb.reverse/step-precsave.exp @@ -21,9 +21,7 @@ # =20 # This test suitable only for process record-replay -if ![supports_process_record] { - return -} +require supports_process_record =20 standard_testfile step-reverse.c set precsave [standard_output_file step.precsave] @@ -34,10 +32,8 @@ if { [prepare_for_testing "failed to prepare" $testfile = $srcfile] } { =20 runto_main =20 -if [supports_process_record] { - # Activate process record/replay - gdb_test_no_output "record" "turn on process record" -} +# Activate process record/replay +gdb_test_no_output "record" "turn on process record" =20 set end_of_main [gdb_get_line_number "end of main" ] gdb_test "break $end_of_main" \ diff --git a/gdb/testsuite/gdb.reverse/until-precsave.exp b/gdb/testsuite/g= db.reverse/until-precsave.exp index 0c2d7537cd6..b5b2ba764d3 100644 --- a/gdb/testsuite/gdb.reverse/until-precsave.exp +++ b/gdb/testsuite/gdb.reverse/until-precsave.exp @@ -17,9 +17,7 @@ # 'advance' in precord logfile. =20 # This test suitable only for process record-replay -if ![supports_process_record] { - return -} +require supports_process_record =20 standard_testfile until-reverse.c ur1.c set precsave [standard_output_file until.precsave] @@ -38,10 +36,8 @@ set bp_location21 [gdb_get_line_number "set breakpoint 2= 1 here"] =20 runto_main =20 -if [supports_process_record] { - # Activate process record/replay - gdb_test_no_output "record" "turn on process record" -} +# Activate process record/replay +gdb_test_no_output "record" "turn on process record" =20 set end_of_main [gdb_get_line_number "set breakpoint 10a here" ] gdb_test "break $end_of_main" \ diff --git a/gdb/testsuite/gdb.reverse/watch-precsave.exp b/gdb/testsuite/g= db.reverse/watch-precsave.exp index bb8cab47afd..1f981393f0e 100644 --- a/gdb/testsuite/gdb.reverse/watch-precsave.exp +++ b/gdb/testsuite/gdb.reverse/watch-precsave.exp @@ -18,9 +18,7 @@ # debugging with watchpoints. =20 # This test suitable only for process record-replay -if ![supports_process_record] { - return -} +require supports_process_record =20 standard_testfile watch-reverse.c set precsave [standard_output_file watch.precsave] @@ -31,10 +29,8 @@ if { [prepare_for_testing "failed to prepare" $testfile = $srcfile] } { =20 runto_main =20 -if [supports_process_record] { - # Activate process record/replay - gdb_test_no_output "record" "turn on process record" -} +# Activate process record/replay +gdb_test_no_output "record" "turn on process record" =20 set end_location [gdb_get_line_number "end of main" ] gdb_test "break $end_location" \