public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Use require is_x86_like_target Date: Fri, 13 Jan 2023 20:34:26 +0000 (GMT) [thread overview] Message-ID: <20230113203426.A768A3858004@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=18d2b8767a86e819c911d12077ad9a1ab6f289a3 commit 18d2b8767a86e819c911d12077ad9a1ab6f289a3 Author: Tom Tromey <tom@tromey.com> Date: Tue Dec 13 15:25:00 2022 -0700 Use require is_x86_like_target This changes some tests to use "require is_x86_like_target". Diff: --- gdb/testsuite/gdb.arch/i386-cfi-notcurrent.exp | 4 +--- gdb/testsuite/gdb.arch/i386-disp-step.exp | 5 +---- gdb/testsuite/gdb.arch/i386-gnu-cfi.exp | 5 +---- gdb/testsuite/gdb.arch/i386-prologue.exp | 5 +---- gdb/testsuite/gdb.arch/i386-size-overlap.exp | 5 +---- gdb/testsuite/gdb.arch/i386-size.exp | 5 +---- gdb/testsuite/gdb.arch/i386-sse-stack-align.exp | 5 +---- gdb/testsuite/gdb.arch/i386-stap-eval-lang-ada.exp | 5 +---- gdb/testsuite/gdb.arch/i386-unwind.exp | 5 +---- gdb/testsuite/gdb.dwarf2/callframecfa.exp | 5 +---- gdb/testsuite/gdb.dwarf2/pieces-optimized-out.exp | 5 +---- gdb/testsuite/gdb.dwarf2/pieces.exp | 5 +---- gdb/testsuite/gdb.dwarf2/valop.exp | 5 +---- gdb/testsuite/gdb.dwarf2/watch-notconst.exp | 6 +----- gdb/testsuite/gdb.reverse/i386-precsave.exp | 8 +------- gdb/testsuite/gdb.reverse/i386-reverse.exp | 7 +------ gdb/testsuite/gdb.reverse/i387-env-reverse.exp | 5 +---- gdb/testsuite/gdb.reverse/i387-stack-reverse.exp | 5 +---- 18 files changed, 18 insertions(+), 77 deletions(-) diff --git a/gdb/testsuite/gdb.arch/i386-cfi-notcurrent.exp b/gdb/testsuite/gdb.arch/i386-cfi-notcurrent.exp index cc19250e17f..9412b0a6418 100644 --- a/gdb/testsuite/gdb.arch/i386-cfi-notcurrent.exp +++ b/gdb/testsuite/gdb.arch/i386-cfi-notcurrent.exp @@ -16,9 +16,7 @@ # [RFA] DWARF frame unwinder executes one too many rows # http://sourceware.org/ml/gdb-patches/2012-07/msg00650.html -if { ![is_x86_like_target] } { - return 0 -} +require is_x86_like_target set testfile "i386-cfi-notcurrent" set srcfile ${testfile}.S diff --git a/gdb/testsuite/gdb.arch/i386-disp-step.exp b/gdb/testsuite/gdb.arch/i386-disp-step.exp index 264544db0e2..02f74136507 100644 --- a/gdb/testsuite/gdb.arch/i386-disp-step.exp +++ b/gdb/testsuite/gdb.arch/i386-disp-step.exp @@ -18,10 +18,7 @@ # Test i386 displaced stepping. -if {![is_x86_like_target]} { - verbose "Skipping x86 displaced stepping tests." - return -} +require is_x86_like_target standard_testfile .S diff --git a/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp b/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp index 884b3b6cad2..56a4eee32a6 100644 --- a/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp +++ b/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp @@ -23,10 +23,7 @@ # Test i386 unwinder. -if {![is_x86_like_target]} { - verbose "Skipping i386 unwinder tests." - return -} +require is_x86_like_target set testfile "i386-gnu-cfi" set srcfilec ${testfile}.c diff --git a/gdb/testsuite/gdb.arch/i386-prologue.exp b/gdb/testsuite/gdb.arch/i386-prologue.exp index f522f864e9c..8e24b879fd1 100644 --- a/gdb/testsuite/gdb.arch/i386-prologue.exp +++ b/gdb/testsuite/gdb.arch/i386-prologue.exp @@ -21,10 +21,7 @@ # Test i386 prologue analyzer. -if {![is_x86_like_target]} { - verbose "Skipping i386 prologue tests." - return -} +require is_x86_like_target set testfile "i386-prologue" set srcfile ${testfile}.c diff --git a/gdb/testsuite/gdb.arch/i386-size-overlap.exp b/gdb/testsuite/gdb.arch/i386-size-overlap.exp index a3c62d63106..a5517b836f3 100644 --- a/gdb/testsuite/gdb.arch/i386-size-overlap.exp +++ b/gdb/testsuite/gdb.arch/i386-size-overlap.exp @@ -17,10 +17,7 @@ # Test that GDB can handle overlapping sizes of symbols. -if {![is_x86_like_target]} { - verbose "Skipping i386 unwinder tests." - return -} +require is_x86_like_target standard_testfile diff --git a/gdb/testsuite/gdb.arch/i386-size.exp b/gdb/testsuite/gdb.arch/i386-size.exp index 9fcd7ba734c..0b616f68893 100644 --- a/gdb/testsuite/gdb.arch/i386-size.exp +++ b/gdb/testsuite/gdb.arch/i386-size.exp @@ -20,10 +20,7 @@ # Test that GDB can see the sizes of symbols. -if {![is_x86_like_target]} { - verbose "Skipping i386 unwinder tests." - return -} +require is_x86_like_target set testfile "i386-size" set srcfile ${testfile}.c diff --git a/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp b/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp index 009140f7067..7b931a6d2dd 100644 --- a/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp +++ b/gdb/testsuite/gdb.arch/i386-sse-stack-align.exp @@ -13,10 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if ![is_x86_like_target] { - verbose "Skipping x86 SSE stack alignment tests." - return -} +require is_x86_like_target set testfile "i386-sse-stack-align" set srcfile ${testfile}.S diff --git a/gdb/testsuite/gdb.arch/i386-stap-eval-lang-ada.exp b/gdb/testsuite/gdb.arch/i386-stap-eval-lang-ada.exp index d62a2408294..2b7bfbff76c 100644 --- a/gdb/testsuite/gdb.arch/i386-stap-eval-lang-ada.exp +++ b/gdb/testsuite/gdb.arch/i386-stap-eval-lang-ada.exp @@ -16,10 +16,7 @@ standard_testfile ".S" # We can only test this if the target is i686 or x86_64 with -m32 -if { ![is_x86_like_target] } { - verbose "Skipping $testfile.exp" - return -} +require is_x86_like_target if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { return -1 diff --git a/gdb/testsuite/gdb.arch/i386-unwind.exp b/gdb/testsuite/gdb.arch/i386-unwind.exp index 2c6ba331561..04ef77132eb 100644 --- a/gdb/testsuite/gdb.arch/i386-unwind.exp +++ b/gdb/testsuite/gdb.arch/i386-unwind.exp @@ -21,10 +21,7 @@ # Test i386 unwinder. -if {![is_x86_like_target]} { - verbose "Skipping i386 unwinder tests." - return -} +require is_x86_like_target standard_testfile diff --git a/gdb/testsuite/gdb.dwarf2/callframecfa.exp b/gdb/testsuite/gdb.dwarf2/callframecfa.exp index 4242e08a296..9554a0f89a0 100644 --- a/gdb/testsuite/gdb.dwarf2/callframecfa.exp +++ b/gdb/testsuite/gdb.dwarf2/callframecfa.exp @@ -17,11 +17,8 @@ load_lib dwarf.exp # Test DW_OP_call_frame_cfa. # This test can only be run on targets which support DWARF-2 and use gas. -require dwarf2_support # This test can only be run on x86 targets. -if {![is_x86_like_target]} { - return 0 -} +require dwarf2_support is_x86_like_target standard_testfile .S diff --git a/gdb/testsuite/gdb.dwarf2/pieces-optimized-out.exp b/gdb/testsuite/gdb.dwarf2/pieces-optimized-out.exp index 90acd39cb08..b0e01afd06e 100644 --- a/gdb/testsuite/gdb.dwarf2/pieces-optimized-out.exp +++ b/gdb/testsuite/gdb.dwarf2/pieces-optimized-out.exp @@ -16,11 +16,8 @@ load_lib dwarf.exp # Test some DWARF piece operators. # This test can only be run on targets which support DWARF-2 and use gas. -require dwarf2_support # This test can only be run on x86 targets. -if {![is_x86_like_target]} { - return 0 -} +require dwarf2_support is_x86_like_target standard_testfile .S set csrcfile ${testfile}.c diff --git a/gdb/testsuite/gdb.dwarf2/pieces.exp b/gdb/testsuite/gdb.dwarf2/pieces.exp index e6666b853aa..9464f3f835f 100644 --- a/gdb/testsuite/gdb.dwarf2/pieces.exp +++ b/gdb/testsuite/gdb.dwarf2/pieces.exp @@ -16,11 +16,8 @@ load_lib dwarf.exp # Test some DWARF piece operators. # This test can only be run on targets which support DWARF-2 and use gas. -require dwarf2_support # This test can only be run on x86 targets. -if {![is_x86_like_target]} { - return 0 -} +require dwarf2_support is_x86_like_target standard_testfile .S set csrcfile ${testfile}.c diff --git a/gdb/testsuite/gdb.dwarf2/valop.exp b/gdb/testsuite/gdb.dwarf2/valop.exp index 848a19de60a..1a58d26281e 100644 --- a/gdb/testsuite/gdb.dwarf2/valop.exp +++ b/gdb/testsuite/gdb.dwarf2/valop.exp @@ -17,11 +17,8 @@ load_lib dwarf.exp # Test DW_OP_stack_value and DW_OP_implicit_value. # This test can only be run on targets which support DWARF-2 and use gas. -require dwarf2_support # This test can only be run on x86 targets. -if {![is_x86_like_target]} { - return 0 -} +require dwarf2_support is_x86_like_target standard_testfile .S diff --git a/gdb/testsuite/gdb.dwarf2/watch-notconst.exp b/gdb/testsuite/gdb.dwarf2/watch-notconst.exp index d7786bbf1b6..0cf086b2ab8 100644 --- a/gdb/testsuite/gdb.dwarf2/watch-notconst.exp +++ b/gdb/testsuite/gdb.dwarf2/watch-notconst.exp @@ -17,12 +17,8 @@ load_lib dwarf.exp set test "watch-notconst" # This test can only be run on targets which support DWARF-2 and use gas. -require dwarf2_support - # This test can only be run on x86 targets. -if { ![is_x86_like_target] } { - return 0 -} +require dwarf2_support is_x86_like_target if { [prepare_for_testing "failed to prepare" "${test}" \ {watch-notconst.c watch-notconst2.S} {nodebug}] } { diff --git a/gdb/testsuite/gdb.reverse/i386-precsave.exp b/gdb/testsuite/gdb.reverse/i386-precsave.exp index 301e3b60208..3e9a402e5b6 100644 --- a/gdb/testsuite/gdb.reverse/i386-precsave.exp +++ b/gdb/testsuite/gdb.reverse/i386-precsave.exp @@ -20,13 +20,7 @@ # # This test suitable only for process record-replay -require supports_process_record - - -if {![is_x86_like_target]} { - verbose "Skipping i386 reverse tests." - return -} +require supports_process_record is_x86_like_target standard_testfile i386-reverse.c set precsave [standard_output_file i386.precsave] diff --git a/gdb/testsuite/gdb.reverse/i386-reverse.exp b/gdb/testsuite/gdb.reverse/i386-reverse.exp index 5fa7237af53..42ad28d44ea 100644 --- a/gdb/testsuite/gdb.reverse/i386-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i386-reverse.exp @@ -19,12 +19,7 @@ # This test tests some i386 general instructions for reverse execution. # -require supports_reverse - -if {![is_x86_like_target]} { - verbose "Skipping i386 reverse tests." - return -} +require supports_reverse is_x86_like_target standard_testfile diff --git a/gdb/testsuite/gdb.reverse/i387-env-reverse.exp b/gdb/testsuite/gdb.reverse/i387-env-reverse.exp index 0decbfc2481..7bb17f70640 100644 --- a/gdb/testsuite/gdb.reverse/i387-env-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i387-env-reverse.exp @@ -16,10 +16,7 @@ # This file is part of the gdb testsuite. -if {![is_x86_like_target]} { - verbose "Skipping i387 reverse float tests." - return -} +require is_x86_like_target standard_testfile diff --git a/gdb/testsuite/gdb.reverse/i387-stack-reverse.exp b/gdb/testsuite/gdb.reverse/i387-stack-reverse.exp index cdb481519ec..ee6507af74e 100644 --- a/gdb/testsuite/gdb.reverse/i387-stack-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i387-stack-reverse.exp @@ -16,10 +16,7 @@ # This file is part of the gdb testsuite. -if {![is_x86_like_target]} { - verbose "Skipping i387 reverse float tests." - return -} +require is_x86_like_target standard_testfile
reply other threads:[~2023-01-13 20:34 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230113203426.A768A3858004@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).