public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Use require !skip_btrace_tests Date: Fri, 13 Jan 2023 20:35:42 +0000 (GMT) [thread overview] Message-ID: <20230113203542.BADB43858C39@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6848695de293c4f8f33bcab968f729702fdb0b2d commit 6848695de293c4f8f33bcab968f729702fdb0b2d Author: Tom Tromey <tom@tromey.com> Date: Wed Dec 14 09:42:37 2022 -0700 Use require !skip_btrace_tests This changes some tests to use "require !skip_btrace_tests". Diff: --- gdb/testsuite/gdb.btrace/buffer-size.exp | 5 +---- gdb/testsuite/gdb.btrace/data.exp | 5 +---- gdb/testsuite/gdb.btrace/delta.exp | 5 +---- gdb/testsuite/gdb.btrace/enable-new-thread.exp | 5 +---- gdb/testsuite/gdb.btrace/enable-running.exp | 5 +---- gdb/testsuite/gdb.btrace/enable.exp | 5 +---- gdb/testsuite/gdb.btrace/exception.exp | 5 +---- gdb/testsuite/gdb.btrace/function_call_history.exp | 5 +---- gdb/testsuite/gdb.btrace/gcore.exp | 5 +---- gdb/testsuite/gdb.btrace/instruction_history.exp | 5 +---- gdb/testsuite/gdb.btrace/multi-inferior.exp | 5 +---- gdb/testsuite/gdb.btrace/multi-thread-step.exp | 5 +---- gdb/testsuite/gdb.btrace/nohist.exp | 5 +---- gdb/testsuite/gdb.btrace/non-stop.exp | 5 +---- gdb/testsuite/gdb.btrace/reconnect.exp | 5 +---- gdb/testsuite/gdb.btrace/record_goto-step.exp | 5 +---- gdb/testsuite/gdb.btrace/record_goto.exp | 5 +---- gdb/testsuite/gdb.btrace/rn-dl-bind.exp | 5 +---- gdb/testsuite/gdb.btrace/segv.exp | 5 +---- gdb/testsuite/gdb.btrace/step.exp | 5 +---- gdb/testsuite/gdb.btrace/stepi.exp | 5 +---- gdb/testsuite/gdb.btrace/tailcall-only.exp | 5 +---- gdb/testsuite/gdb.btrace/tailcall.exp | 5 +---- gdb/testsuite/gdb.btrace/unknown_functions.exp | 5 +---- gdb/testsuite/gdb.btrace/vdso.exp | 5 +---- gdb/testsuite/gdb.python/py-record-btrace-threads.exp | 5 +---- gdb/testsuite/gdb.python/py-record-btrace.exp | 5 +---- 27 files changed, 27 insertions(+), 108 deletions(-) diff --git a/gdb/testsuite/gdb.btrace/buffer-size.exp b/gdb/testsuite/gdb.btrace/buffer-size.exp index 6790323f854..d0a9086604f 100644 --- a/gdb/testsuite/gdb.btrace/buffer-size.exp +++ b/gdb/testsuite/gdb.btrace/buffer-size.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile record_goto.c if [prepare_for_testing "failed to prepare" $testfile $srcfile] { diff --git a/gdb/testsuite/gdb.btrace/data.exp b/gdb/testsuite/gdb.btrace/data.exp index 77248beb1a2..8be2a4ccdea 100644 --- a/gdb/testsuite/gdb.btrace/data.exp +++ b/gdb/testsuite/gdb.btrace/data.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile if [prepare_for_testing "failed to prepare" $testfile $srcfile] { diff --git a/gdb/testsuite/gdb.btrace/delta.exp b/gdb/testsuite/gdb.btrace/delta.exp index e21cbfb87eb..e4307e15a5b 100644 --- a/gdb/testsuite/gdb.btrace/delta.exp +++ b/gdb/testsuite/gdb.btrace/delta.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile record_goto.c if [prepare_for_testing "failed to prepare" $testfile $srcfile] { diff --git a/gdb/testsuite/gdb.btrace/enable-new-thread.exp b/gdb/testsuite/gdb.btrace/enable-new-thread.exp index fb6b9ca3dd2..22cc33f142f 100644 --- a/gdb/testsuite/gdb.btrace/enable-new-thread.exp +++ b/gdb/testsuite/gdb.btrace/enable-new-thread.exp @@ -17,10 +17,7 @@ # Test that new threads of recorded inferiors also get recorded. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile if [prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthreads}] { diff --git a/gdb/testsuite/gdb.btrace/enable-running.exp b/gdb/testsuite/gdb.btrace/enable-running.exp index 2c24b8d8398..6e626e3a053 100644 --- a/gdb/testsuite/gdb.btrace/enable-running.exp +++ b/gdb/testsuite/gdb.btrace/enable-running.exp @@ -15,10 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" "$binfile" executable {debug}] != "" } { diff --git a/gdb/testsuite/gdb.btrace/enable.exp b/gdb/testsuite/gdb.btrace/enable.exp index 1c29131e97b..bb57f7b8a74 100644 --- a/gdb/testsuite/gdb.btrace/enable.exp +++ b/gdb/testsuite/gdb.btrace/enable.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests # start fresh - without an executable gdb_exit diff --git a/gdb/testsuite/gdb.btrace/exception.exp b/gdb/testsuite/gdb.btrace/exception.exp index 731ebe1cf90..e84ff14d193 100755 --- a/gdb/testsuite/gdb.btrace/exception.exp +++ b/gdb/testsuite/gdb.btrace/exception.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests # We expect a specific function call history. This gets messed up with # PIE on 32-bit. diff --git a/gdb/testsuite/gdb.btrace/function_call_history.exp b/gdb/testsuite/gdb.btrace/function_call_history.exp index 562412f121c..fd35d762796 100644 --- a/gdb/testsuite/gdb.btrace/function_call_history.exp +++ b/gdb/testsuite/gdb.btrace/function_call_history.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests # We expect a specific function call history. This gets messed up with # PIE on 32-bit. diff --git a/gdb/testsuite/gdb.btrace/gcore.exp b/gdb/testsuite/gdb.btrace/gcore.exp index 4b056c0fee0..1e98860aee3 100644 --- a/gdb/testsuite/gdb.btrace/gcore.exp +++ b/gdb/testsuite/gdb.btrace/gcore.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile record_goto.c if [prepare_for_testing "failed to prepare" $testfile $srcfile] { diff --git a/gdb/testsuite/gdb.btrace/instruction_history.exp b/gdb/testsuite/gdb.btrace/instruction_history.exp index b9043b36eac..0e525c73cb7 100644 --- a/gdb/testsuite/gdb.btrace/instruction_history.exp +++ b/gdb/testsuite/gdb.btrace/instruction_history.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile .c .S if [prepare_for_testing "failed to prepare" $testfile "$srcfile $srcfile2" {debug}] { diff --git a/gdb/testsuite/gdb.btrace/multi-inferior.exp b/gdb/testsuite/gdb.btrace/multi-inferior.exp index 87bf029e4be..727161e4dbd 100644 --- a/gdb/testsuite/gdb.btrace/multi-inferior.exp +++ b/gdb/testsuite/gdb.btrace/multi-inferior.exp @@ -22,10 +22,7 @@ # # Each inferior can be recorded separately. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests if { [use_gdb_stub] } { unsupported "test creates multiple inferiors" diff --git a/gdb/testsuite/gdb.btrace/multi-thread-step.exp b/gdb/testsuite/gdb.btrace/multi-thread-step.exp index d58b791b4e1..a18734843ae 100644 --- a/gdb/testsuite/gdb.btrace/multi-thread-step.exp +++ b/gdb/testsuite/gdb.btrace/multi-thread-step.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" "$binfile" executable {debug}] != "" } { diff --git a/gdb/testsuite/gdb.btrace/nohist.exp b/gdb/testsuite/gdb.btrace/nohist.exp index 60710132431..0875b8a6e22 100644 --- a/gdb/testsuite/gdb.btrace/nohist.exp +++ b/gdb/testsuite/gdb.btrace/nohist.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile record_goto.c if [prepare_for_testing "failed to prepare" $testfile $srcfile] { diff --git a/gdb/testsuite/gdb.btrace/non-stop.exp b/gdb/testsuite/gdb.btrace/non-stop.exp index 0cc78e97f16..278064fbac5 100644 --- a/gdb/testsuite/gdb.btrace/non-stop.exp +++ b/gdb/testsuite/gdb.btrace/non-stop.exp @@ -15,10 +15,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" "$binfile" executable {debug}] != "" } { diff --git a/gdb/testsuite/gdb.btrace/reconnect.exp b/gdb/testsuite/gdb.btrace/reconnect.exp index 0adfc1b65fc..868cf1f0680 100644 --- a/gdb/testsuite/gdb.btrace/reconnect.exp +++ b/gdb/testsuite/gdb.btrace/reconnect.exp @@ -19,10 +19,7 @@ load_lib gdbserver-support.exp -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests if { [skip_gdbserver_tests] } { unsupported "target does not support gdbserver" return -1 diff --git a/gdb/testsuite/gdb.btrace/record_goto-step.exp b/gdb/testsuite/gdb.btrace/record_goto-step.exp index f1a3f00ada9..1f289b47f64 100644 --- a/gdb/testsuite/gdb.btrace/record_goto-step.exp +++ b/gdb/testsuite/gdb.btrace/record_goto-step.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile record_goto.c if [prepare_for_testing "failed to prepare" $testfile $srcfile] { diff --git a/gdb/testsuite/gdb.btrace/record_goto.exp b/gdb/testsuite/gdb.btrace/record_goto.exp index ab32a298ce3..dce9ca18c6c 100644 --- a/gdb/testsuite/gdb.btrace/record_goto.exp +++ b/gdb/testsuite/gdb.btrace/record_goto.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests # The "record goto" command jumps to a specific instruction in the execution # trace. To guarantee that we always get the same execution trace, we use diff --git a/gdb/testsuite/gdb.btrace/rn-dl-bind.exp b/gdb/testsuite/gdb.btrace/rn-dl-bind.exp index c55ff18b003..f61aa936a8d 100644 --- a/gdb/testsuite/gdb.btrace/rn-dl-bind.exp +++ b/gdb/testsuite/gdb.btrace/rn-dl-bind.exp @@ -21,10 +21,7 @@ # Test that we can reverse-next over the dynamic linker's symbol # lookup code. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile if [prepare_for_testing "failed to prepare" $testfile $srcfile \ diff --git a/gdb/testsuite/gdb.btrace/segv.exp b/gdb/testsuite/gdb.btrace/segv.exp index 45b9d1d5b5e..9d256795729 100644 --- a/gdb/testsuite/gdb.btrace/segv.exp +++ b/gdb/testsuite/gdb.btrace/segv.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile if [prepare_for_testing "failed to prepare" $testfile $srcfile] { diff --git a/gdb/testsuite/gdb.btrace/step.exp b/gdb/testsuite/gdb.btrace/step.exp index 438ff580b55..8ad58d48fdc 100644 --- a/gdb/testsuite/gdb.btrace/step.exp +++ b/gdb/testsuite/gdb.btrace/step.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile record_goto.c if [prepare_for_testing "failed to prepare" $testfile $srcfile] { diff --git a/gdb/testsuite/gdb.btrace/stepi.exp b/gdb/testsuite/gdb.btrace/stepi.exp index 06a68d9b1b4..f659d58cf7c 100644 --- a/gdb/testsuite/gdb.btrace/stepi.exp +++ b/gdb/testsuite/gdb.btrace/stepi.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests # This test is stepping on instruction level. To guarantee that we always # get the same execution trace, we use an assembly source file. diff --git a/gdb/testsuite/gdb.btrace/tailcall-only.exp b/gdb/testsuite/gdb.btrace/tailcall-only.exp index 081a919b719..16541b2eacf 100644 --- a/gdb/testsuite/gdb.btrace/tailcall-only.exp +++ b/gdb/testsuite/gdb.btrace/tailcall-only.exp @@ -20,10 +20,7 @@ # calls. This used to cause a crash in get_frame_type. # -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests # This test requires the compiler to generate a tail call. To guarantee that # we always get one, we use an assembly source file. diff --git a/gdb/testsuite/gdb.btrace/tailcall.exp b/gdb/testsuite/gdb.btrace/tailcall.exp index 028e03fc6f6..f422fbb1b2a 100644 --- a/gdb/testsuite/gdb.btrace/tailcall.exp +++ b/gdb/testsuite/gdb.btrace/tailcall.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests # This test requires the compiler to generate a tail call. To guarantee that # we always get one, we use an assembly source file. diff --git a/gdb/testsuite/gdb.btrace/unknown_functions.exp b/gdb/testsuite/gdb.btrace/unknown_functions.exp index 1bfa4dcd873..291d7df5963 100644 --- a/gdb/testsuite/gdb.btrace/unknown_functions.exp +++ b/gdb/testsuite/gdb.btrace/unknown_functions.exp @@ -17,10 +17,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile diff --git a/gdb/testsuite/gdb.btrace/vdso.exp b/gdb/testsuite/gdb.btrace/vdso.exp index ef2ef2c8e8f..16a7e230786 100644 --- a/gdb/testsuite/gdb.btrace/vdso.exp +++ b/gdb/testsuite/gdb.btrace/vdso.exp @@ -20,10 +20,7 @@ # # Test that we can access the vdso memory during replay for stepping. -if { [skip_btrace_tests] } { - unsupported "target does not support record-btrace" - return -1 -} +require !skip_btrace_tests standard_testfile if [prepare_for_testing "failed to prepare" $testfile $srcfile] { diff --git a/gdb/testsuite/gdb.python/py-record-btrace-threads.exp b/gdb/testsuite/gdb.python/py-record-btrace-threads.exp index 53f4a7bba98..ef14edceded 100644 --- a/gdb/testsuite/gdb.python/py-record-btrace-threads.exp +++ b/gdb/testsuite/gdb.python/py-record-btrace-threads.exp @@ -17,10 +17,7 @@ # Skip this test if btrace is disabled. -if { [skip_btrace_tests] } { - untested "skipping btrace tests" - return -1 -} +require !skip_btrace_tests standard_testfile diff --git a/gdb/testsuite/gdb.python/py-record-btrace.exp b/gdb/testsuite/gdb.python/py-record-btrace.exp index 0d36959464e..38c326f555f 100644 --- a/gdb/testsuite/gdb.python/py-record-btrace.exp +++ b/gdb/testsuite/gdb.python/py-record-btrace.exp @@ -17,10 +17,7 @@ # Skip this test if btrace is disabled. -if { [skip_btrace_tests] } { - untested "skipping btrace tests" - return -1 -} +require !skip_btrace_tests load_lib gdb-python.exp
reply other threads:[~2023-01-13 20:35 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230113203542.BADB43858C39@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).