From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id C139D3860744; Fri, 13 Jan 2023 20:36:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C139D3860744 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673642213; bh=kjrYUJ9kogl5ru9782XXUL9GB6oUEdIonIE3QyIhVyc=; h=From:To:Subject:Date:From; b=yFJPIZ+bn+ED7hixLntsctnNVU+5AZQy+Z2NX74AR81Immun3Qp1+udaKNpp0BCrL 1l2H7EuJ7J7xbIMTHeAI7w9oWan331SjSHjOZBTBOv9lu8IutLs5X1bMGpNSckeJ+H Zs6bmNrgexJBLFLymSOkykFIRZRB7mPxDDk+5hVE= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Use require !skip_shlib_tests X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: ba16d4d85f053d8a533b0c40218f4d681f6eebd5 X-Git-Newrev: 78a1c061b2ad49c687ca1ecc4e87acadfad37e1f Message-Id: <20230113203653.C139D3860744@sourceware.org> Date: Fri, 13 Jan 2023 20:36:53 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D78a1c061b2ad= 49c687ca1ecc4e87acadfad37e1f commit 78a1c061b2ad49c687ca1ecc4e87acadfad37e1f Author: Tom Tromey Date: Wed Dec 14 10:11:33 2022 -0700 Use require !skip_shlib_tests =20 This changes some tests to use "require !skip_shlib_tests". This patch cleans up a few spots that were missed in the earlier patch. Diff: --- gdb/testsuite/gdb.base/attach-pie-misread.exp | 4 ++-- gdb/testsuite/gdb.base/break-interp.exp | 4 ++-- gdb/testsuite/gdb.base/info-fun.exp | 3 ++- gdb/testsuite/gdb.base/prelink.exp | 4 ++-- gdb/testsuite/gdb.base/skip-solib.exp | 4 ++-- gdb/testsuite/gdb.base/solib-search.exp | 3 ++- 6 files changed, 12 insertions(+), 10 deletions(-) diff --git a/gdb/testsuite/gdb.base/attach-pie-misread.exp b/gdb/testsuite/= gdb.base/attach-pie-misread.exp index 4e0d549351c..9adf107ad92 100644 --- a/gdb/testsuite/gdb.base/attach-pie-misread.exp +++ b/gdb/testsuite/gdb.base/attach-pie-misread.exp @@ -14,8 +14,8 @@ # along with this program. If not, see . =20 # This test only works on GNU/Linux. -require !use_gdb_stub isnative -if { [is_remote host] || ![istarget *-linux*] || [skip_shlib_tests]} { +require !use_gdb_stub isnative !skip_shlib_tests +if { [is_remote host] || ![istarget *-linux*] } { return } =20 diff --git a/gdb/testsuite/gdb.base/break-interp.exp b/gdb/testsuite/gdb.ba= se/break-interp.exp index 2cee092b184..21452d8569e 100644 --- a/gdb/testsuite/gdb.base/break-interp.exp +++ b/gdb/testsuite/gdb.base/break-interp.exp @@ -14,8 +14,8 @@ # along with this program. If not, see . =20 # This test only works on GNU/Linux. -require !use_gdb_stub isnative -if { [is_remote host] || ![istarget *-linux*] || [skip_shlib_tests]} { +require !use_gdb_stub isnative !skip_shlib_tests +if { [is_remote host] || ![istarget *-linux*] } { return } =20 diff --git a/gdb/testsuite/gdb.base/info-fun.exp b/gdb/testsuite/gdb.base/i= nfo-fun.exp index 5bae3e22656..07520049244 100644 --- a/gdb/testsuite/gdb.base/info-fun.exp +++ b/gdb/testsuite/gdb.base/info-fun.exp @@ -12,7 +12,8 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . =20 -if { [skip_shlib_tests] || [is_remote target] } { +require !skip_shlib_tests +if { [is_remote target] } { return 0 } =20 diff --git a/gdb/testsuite/gdb.base/prelink.exp b/gdb/testsuite/gdb.base/pr= elink.exp index 9c5b777b4a2..1e40aecc92b 100644 --- a/gdb/testsuite/gdb.base/prelink.exp +++ b/gdb/testsuite/gdb.base/prelink.exp @@ -19,8 +19,8 @@ # This file was written by Alexandre Oliva =20 =20 -require isnative -if { [is_remote host] || [skip_shlib_tests]} { +require isnative !skip_shlib_tests +if { [is_remote host] } { return } =20 diff --git a/gdb/testsuite/gdb.base/skip-solib.exp b/gdb/testsuite/gdb.base= /skip-solib.exp index 22a1e8746e7..f5850c7a0b1 100644 --- a/gdb/testsuite/gdb.base/skip-solib.exp +++ b/gdb/testsuite/gdb.base/skip-solib.exp @@ -20,8 +20,8 @@ # =20 # This only works on GNU/Linux. -require isnative -if { [is_remote host] || ![istarget *-linux*] || [skip_shlib_tests]} { +require isnative !skip_shlib_tests +if { [is_remote host] || ![istarget *-linux*] } { return } =20 diff --git a/gdb/testsuite/gdb.base/solib-search.exp b/gdb/testsuite/gdb.ba= se/solib-search.exp index 8d2dacfb947..c77fcc4f5ca 100644 --- a/gdb/testsuite/gdb.base/solib-search.exp +++ b/gdb/testsuite/gdb.base/solib-search.exp @@ -16,7 +16,8 @@ # Test solib-search-path, and in the case of solib-svr4.c whether l_addr_p # is properly reset when the path is changed. =20 -if {[is_remote target] || [skip_shlib_tests]} { +require !skip_shlib_tests +if {[is_remote target]} { untested "skipping remote target and shared library tests" return -1 }