public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Use require !gdb_debug_enabled
Date: Fri, 13 Jan 2023 20:37:03 +0000 (GMT) [thread overview]
Message-ID: <20230113203703.E54403858004@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e5bf39c507a7806f0926a35a81b78b5cc5273c6a
commit e5bf39c507a7806f0926a35a81b78b5cc5273c6a
Author: Tom Tromey <tom@tromey.com>
Date: Wed Dec 14 16:42:16 2022 -0700
Use require !gdb_debug_enabled
This changes some tests to use "require !gdb_debug_enabled".
Diff:
---
gdb/testsuite/gdb.base/breakpoint-in-ro-region.exp | 5 +----
gdb/testsuite/gdb.base/debug-expr.exp | 5 +----
gdb/testsuite/gdb.base/foll-fork.exp | 5 +----
gdb/testsuite/gdb.base/fork-print-inferior-events.exp | 5 +----
gdb/testsuite/gdb.base/gdb-sigterm.exp | 5 +----
gdb/testsuite/gdb.base/gdbinit-history.exp | 5 +----
gdb/testsuite/gdb.base/osabi.exp | 5 +----
gdb/testsuite/gdb.base/page-logging.exp | 5 +----
gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp | 5 +----
gdb/testsuite/gdb.base/style-logging.exp | 5 +----
gdb/testsuite/gdb.base/ui-redirect.exp | 5 +----
gdb/testsuite/gdb.fortran/debug-expr.exp | 5 +----
gdb/testsuite/gdb.gdb/unittest.exp | 5 +----
gdb/testsuite/gdb.mi/new-ui-mi-sync.exp | 5 +----
gdb/testsuite/gdb.mi/user-selected-context-sync.exp | 5 +----
gdb/testsuite/gdb.threads/check-libthread-db.exp | 5 +----
.../gdb.threads/signal-while-stepping-over-bp-other-thread.exp | 4 +---
gdb/testsuite/gdb.threads/stepi-random-signal.exp | 5 +----
18 files changed, 18 insertions(+), 71 deletions(-)
diff --git a/gdb/testsuite/gdb.base/breakpoint-in-ro-region.exp b/gdb/testsuite/gdb.base/breakpoint-in-ro-region.exp
index 00a4fe5af5b..0330cfa345a 100644
--- a/gdb/testsuite/gdb.base/breakpoint-in-ro-region.exp
+++ b/gdb/testsuite/gdb.base/breakpoint-in-ro-region.exp
@@ -17,10 +17,7 @@
# Test relies on checking gdb debug output. Do not run if gdb debug is
# enabled as any debug will be redirected to the log.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
standard_testfile
diff --git a/gdb/testsuite/gdb.base/debug-expr.exp b/gdb/testsuite/gdb.base/debug-expr.exp
index a2fbf7470b1..c7e2afce5a0 100644
--- a/gdb/testsuite/gdb.base/debug-expr.exp
+++ b/gdb/testsuite/gdb.base/debug-expr.exp
@@ -17,10 +17,7 @@
# Test relies on checking gdb debug output. Do not run if gdb debug is
# enabled as any debug will be redirected to the log.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
standard_testfile .c
diff --git a/gdb/testsuite/gdb.base/foll-fork.exp b/gdb/testsuite/gdb.base/foll-fork.exp
index 59a664952c3..51dfcce7ff5 100644
--- a/gdb/testsuite/gdb.base/foll-fork.exp
+++ b/gdb/testsuite/gdb.base/foll-fork.exp
@@ -15,10 +15,7 @@
# Test relies on checking follow-fork output. Do not run if gdb debug is
# enabled as it will be redirected to the log.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
standard_testfile
diff --git a/gdb/testsuite/gdb.base/fork-print-inferior-events.exp b/gdb/testsuite/gdb.base/fork-print-inferior-events.exp
index 1b0ff149b31..33ac172c53b 100644
--- a/gdb/testsuite/gdb.base/fork-print-inferior-events.exp
+++ b/gdb/testsuite/gdb.base/fork-print-inferior-events.exp
@@ -24,10 +24,7 @@ require !use_gdb_stub
# Test relies on checking follow-fork output. Do not run if gdb debug is
# enabled as it will be redirected to the log.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
standard_testfile
diff --git a/gdb/testsuite/gdb.base/gdb-sigterm.exp b/gdb/testsuite/gdb.base/gdb-sigterm.exp
index d2392394aaf..e9dc5f2ea27 100644
--- a/gdb/testsuite/gdb.base/gdb-sigterm.exp
+++ b/gdb/testsuite/gdb.base/gdb-sigterm.exp
@@ -17,10 +17,7 @@
# Test relies on checking gdb debug output. Do not run if gdb debug is
# enabled as any debug will be redirected to the log.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
standard_testfile
diff --git a/gdb/testsuite/gdb.base/gdbinit-history.exp b/gdb/testsuite/gdb.base/gdbinit-history.exp
index b4f0d1b6eef..46d76b0e239 100644
--- a/gdb/testsuite/gdb.base/gdbinit-history.exp
+++ b/gdb/testsuite/gdb.base/gdbinit-history.exp
@@ -22,10 +22,7 @@
# local machine.
# Do not run if gdb debug is enabled - it interferes with the command history.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
if { [is_remote host] } {
unsupported "can't set environment variables on remote host"
diff --git a/gdb/testsuite/gdb.base/osabi.exp b/gdb/testsuite/gdb.base/osabi.exp
index e9f761902b5..a412d932f7d 100644
--- a/gdb/testsuite/gdb.base/osabi.exp
+++ b/gdb/testsuite/gdb.base/osabi.exp
@@ -17,10 +17,7 @@
# Test relies on checking gdb debug output. Do not run if gdb debug is
# enabled as any debug will be redirected to the log.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
# Test that choosing "set osabi none" really requests a gdbarch with no osabi.
diff --git a/gdb/testsuite/gdb.base/page-logging.exp b/gdb/testsuite/gdb.base/page-logging.exp
index a45c5d5c902..ec54ba12c65 100644
--- a/gdb/testsuite/gdb.base/page-logging.exp
+++ b/gdb/testsuite/gdb.base/page-logging.exp
@@ -14,10 +14,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Do not run if gdb debug is enabled as it will interfere with log redirect.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
gdb_start
diff --git a/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp b/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp
index 1bf2e139326..85976c211dd 100644
--- a/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp
+++ b/gdb/testsuite/gdb.base/sss-bp-on-user-bp-2.exp
@@ -33,10 +33,7 @@
# Test relies on checking gdb debug output. Do not run if gdb debug is
# enabled as any debug will be redirected to the log.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
standard_testfile
diff --git a/gdb/testsuite/gdb.base/style-logging.exp b/gdb/testsuite/gdb.base/style-logging.exp
index 75b07086d36..dcf13575a17 100644
--- a/gdb/testsuite/gdb.base/style-logging.exp
+++ b/gdb/testsuite/gdb.base/style-logging.exp
@@ -16,10 +16,7 @@
# Test that logging does not style.
# Do not run if gdb debug is enabled as it will interfere with log redirect.
-if {[gdb_debug_enabled]} {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
if {[is_remote host]} {
untested "does not work on remote host"
diff --git a/gdb/testsuite/gdb.base/ui-redirect.exp b/gdb/testsuite/gdb.base/ui-redirect.exp
index 2c9fc1aec77..c0ba4f11809 100644
--- a/gdb/testsuite/gdb.base/ui-redirect.exp
+++ b/gdb/testsuite/gdb.base/ui-redirect.exp
@@ -14,10 +14,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Do not run if gdb debug is enabled as it will interfere with log redirect.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
if { [prepare_for_testing "failed to prepare" ui-redirect start.c] } {
return -1
diff --git a/gdb/testsuite/gdb.fortran/debug-expr.exp b/gdb/testsuite/gdb.fortran/debug-expr.exp
index 75324ac4607..2a45214d89f 100644
--- a/gdb/testsuite/gdb.fortran/debug-expr.exp
+++ b/gdb/testsuite/gdb.fortran/debug-expr.exp
@@ -19,10 +19,7 @@ require !skip_fortran_tests
# Test relies on checking gdb debug output. Do not run if gdb debug is
# enabled as any debug will be redirected to the log.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
standard_testfile .f90
load_lib fortran.exp
diff --git a/gdb/testsuite/gdb.gdb/unittest.exp b/gdb/testsuite/gdb.gdb/unittest.exp
index c8a68469767..ff532856e40 100644
--- a/gdb/testsuite/gdb.gdb/unittest.exp
+++ b/gdb/testsuite/gdb.gdb/unittest.exp
@@ -15,10 +15,7 @@
# Do not run if gdb debug is enabled as maintenance output will be
# redirected to the log files.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
load_lib completion-support.exp
diff --git a/gdb/testsuite/gdb.mi/new-ui-mi-sync.exp b/gdb/testsuite/gdb.mi/new-ui-mi-sync.exp
index e9a85394130..07b316c8ce9 100644
--- a/gdb/testsuite/gdb.mi/new-ui-mi-sync.exp
+++ b/gdb/testsuite/gdb.mi/new-ui-mi-sync.exp
@@ -21,10 +21,7 @@
# stops again. See PR gdb/20418.
# Do not run if gdb debug is enabled as it doesn't work for separate-mi-tty.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
load_lib mi-support.exp
diff --git a/gdb/testsuite/gdb.mi/user-selected-context-sync.exp b/gdb/testsuite/gdb.mi/user-selected-context-sync.exp
index 55dab46fba8..91ca9b16bf8 100644
--- a/gdb/testsuite/gdb.mi/user-selected-context-sync.exp
+++ b/gdb/testsuite/gdb.mi/user-selected-context-sync.exp
@@ -30,10 +30,7 @@
# are using all-stop, or running, if we are using non-stop.
# Do not run if gdb debug is enabled as it doesn't work for separate-mi-tty.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
load_lib mi-support.exp
diff --git a/gdb/testsuite/gdb.threads/check-libthread-db.exp b/gdb/testsuite/gdb.threads/check-libthread-db.exp
index c93706e3818..2324b7f27e6 100644
--- a/gdb/testsuite/gdb.threads/check-libthread-db.exp
+++ b/gdb/testsuite/gdb.threads/check-libthread-db.exp
@@ -20,10 +20,7 @@ if {[target_info gdb_protocol] != "" || ![istarget *-linux*]} {
# Test relies on checking gdb debug output. Do not run if gdb debug is
# enabled as any debug will be redirected to the log.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
standard_testfile
diff --git a/gdb/testsuite/gdb.threads/signal-while-stepping-over-bp-other-thread.exp b/gdb/testsuite/gdb.threads/signal-while-stepping-over-bp-other-thread.exp
index 0bb26f36cbb..65ecdcd5e33 100644
--- a/gdb/testsuite/gdb.threads/signal-while-stepping-over-bp-other-thread.exp
+++ b/gdb/testsuite/gdb.threads/signal-while-stepping-over-bp-other-thread.exp
@@ -20,9 +20,7 @@
# Test relies on checking gdb debug output. Do not run if gdb debug is
# enabled as any debug will be redirected to the log.
-if [gdb_debug_enabled] {
- return
-}
+require !gdb_debug_enabled
standard_testfile
set executable ${testfile}
diff --git a/gdb/testsuite/gdb.threads/stepi-random-signal.exp b/gdb/testsuite/gdb.threads/stepi-random-signal.exp
index 113e0f737ee..bccc319b6f5 100644
--- a/gdb/testsuite/gdb.threads/stepi-random-signal.exp
+++ b/gdb/testsuite/gdb.threads/stepi-random-signal.exp
@@ -15,10 +15,7 @@
# Test relies on checking gdb debug output. Do not run if gdb debug is
# enabled as any debug will be redirected to the log.
-if [gdb_debug_enabled] {
- untested "debug is enabled"
- return 0
-}
+require !gdb_debug_enabled
standard_testfile
set executable ${testfile}
reply other threads:[~2023-01-13 20:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113203703.E54403858004@sourceware.org \
--to=tromey@sourceware.org \
--cc=gdb-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).