From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id E618C3854806; Fri, 13 Jan 2023 20:38:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E618C3854806 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673642294; bh=RWSSq4wmrxVhHPNwkck4RWE+F2rDeckq4CNAGoYG01s=; h=From:To:Subject:Date:From; b=RqqCr6KychCjo4F6bGpLBoKwbUEKzv6HJEL+UVAXXx+B+DyocRIaUg4tE00cbMfci P7m/sS3LxHXSjI1RL9IfiDeWxenvEpwyf0jHUgpbYSR8bDtHf2ksAQ+ZXxB1YMlcdZ Kw5ai0LiGAiMGZKpqckBpEgIQB1exPKuLIJVEwhs= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Rename to allow_aarch64_sve_tests X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: b963a97fb1cd04beb40a5d69599c74f5da933e78 X-Git-Newrev: 71fd14a943d7c33824724662086a5c3b965b7283 Message-Id: <20230113203814.E618C3854806@sourceware.org> Date: Fri, 13 Jan 2023 20:38:14 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D71fd14a943d7= c33824724662086a5c3b965b7283 commit 71fd14a943d7c33824724662086a5c3b965b7283 Author: Tom Tromey Date: Sat Jan 7 13:32:55 2023 -0700 Rename to allow_aarch64_sve_tests =20 This changes skip_aarch64_sve_tests to invert the sense, and renames it to allow_aarch64_sve_tests. Diff: --- gdb/testsuite/gdb.arch/aarch64-sighandler-regs.exp | 2 +- gdb/testsuite/gdb.arch/aarch64-sve.exp | 2 +- gdb/testsuite/lib/gdb.exp | 18 +++++++++--------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.arch/aarch64-sighandler-regs.exp b/gdb/tests= uite/gdb.arch/aarch64-sighandler-regs.exp index d3f7d1f503e..57ebed3628f 100644 --- a/gdb/testsuite/gdb.arch/aarch64-sighandler-regs.exp +++ b/gdb/testsuite/gdb.arch/aarch64-sighandler-regs.exp @@ -19,7 +19,7 @@ require is_aarch64_target =20 set compile_flags {debug} =20 -if { [skip_aarch64_sve_tests] } { +if { ![allow_aarch64_sve_tests] } { unsupported "target does not support SVE" set sve_hw 0 } else { diff --git a/gdb/testsuite/gdb.arch/aarch64-sve.exp b/gdb/testsuite/gdb.arc= h/aarch64-sve.exp index 4a54b56105d..9b2755e569d 100644 --- a/gdb/testsuite/gdb.arch/aarch64-sve.exp +++ b/gdb/testsuite/gdb.arch/aarch64-sve.exp @@ -15,7 +15,7 @@ =20 # Test a binary that uses SVE and exercise changing the SVE vector length. =20 -require !skip_aarch64_sve_tests +require allow_aarch64_sve_tests =20 standard_testfile if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index f293cbb19cc..9f7ec180189 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -3906,15 +3906,15 @@ gdb_caching_proc skip_btrace_pt_tests { } =20 # Run a test on the target to see if it supports Aarch64 SVE hardware. -# Return 0 if so, 1 if it does not. Note this causes a restart of GDB. +# Return 1 if so, 0 if it does not. Note this causes a restart of GDB. =20 -gdb_caching_proc skip_aarch64_sve_tests { +gdb_caching_proc allow_aarch64_sve_tests { global srcdir subdir gdb_prompt inferior_exited_re =20 set me "skip_aarch64_sve_tests" =20 if { ![is_aarch64_target]} { - return 1 + return 0 } =20 set compile_flags "{additional_flags=3D-march=3Darmv8-a+sve}" @@ -3927,7 +3927,7 @@ gdb_caching_proc skip_aarch64_sve_tests { } } if {![gdb_simple_compile $me $src executable $compile_flags]} { - return 1 + return 0 } =20 # Compilation succeeded so now run it via gdb. @@ -3936,22 +3936,22 @@ gdb_caching_proc skip_aarch64_sve_tests { gdb_expect { -re ".*Illegal instruction.*${gdb_prompt} $" { verbose -log "\n$me sve hardware not detected" - set skip_sve_tests 1 + set allow_sve_tests 0 } -re ".*$inferior_exited_re normally.*${gdb_prompt} $" { verbose -log "\n$me: sve hardware detected" - set skip_sve_tests 0 + set allow_sve_tests 1 } default { warning "\n$me: default case taken" - set skip_sve_tests 1 + set allow_sve_tests 0 } } gdb_exit remote_file build delete $obj =20 - verbose "$me: returning $skip_sve_tests" 2 - return $skip_sve_tests + verbose "$me: returning $allow_sve_tests" 2 + return $allow_sve_tests }