public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Rename to allow_avx512fp16_tests
Date: Fri, 13 Jan 2023 20:38:30 +0000 (GMT)	[thread overview]
Message-ID: <20230113203830.290083858004@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6d1df4502357ff7b716e2a34ec614a2a7617d894

commit 6d1df4502357ff7b716e2a34ec614a2a7617d894
Author: Tom Tromey <tom@tromey.com>
Date:   Sun Jan 8 10:39:51 2023 -0700

    Rename to allow_avx512fp16_tests
    
    This changes skip_avx512fp16_tests to invert the sense, and renames it
    to allow_avx512fp16_tests.

Diff:
---
 gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp |  2 +-
 gdb/testsuite/gdb.arch/x86-avx512fp16.exp     |  2 +-
 gdb/testsuite/lib/gdb.exp                     | 24 ++++++++++++------------
 3 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp b/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp
index 696a6b8edf1..bf8291a4d0b 100644
--- a/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp
+++ b/gdb/testsuite/gdb.arch/x86-avx512fp16-abi.exp
@@ -15,7 +15,7 @@
 
 # Test support for _Float16 parameters and return values.
 
-require !skip_avx512fp16_tests
+require allow_avx512fp16_tests
 
 standard_testfile
 
diff --git a/gdb/testsuite/gdb.arch/x86-avx512fp16.exp b/gdb/testsuite/gdb.arch/x86-avx512fp16.exp
index 526be1660bf..144b51bfa68 100644
--- a/gdb/testsuite/gdb.arch/x86-avx512fp16.exp
+++ b/gdb/testsuite/gdb.arch/x86-avx512fp16.exp
@@ -15,7 +15,7 @@
 
 # Test fp16 support in AVX512 registers.
 
-require !skip_avx512fp16_tests
+require allow_avx512fp16_tests
 
 standard_testfile
 
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index b68ea4eb5b0..4959af6b2c4 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3750,16 +3750,16 @@ gdb_caching_proc allow_avx512bf16_tests {
     return $allow_avx512bf16_tests
 }
 
-# Run a test on the target to see if it supports avx512fp16.  Return 0 if so,
-# 1 if it does not.  Based on 'check_vmx_hw_available' from the GCC testsuite.
+# Run a test on the target to see if it supports avx512fp16.  Return 1 if so,
+# 0 if it does not.  Based on 'check_vmx_hw_available' from the GCC testsuite.
 
-gdb_caching_proc skip_avx512fp16_tests {
+gdb_caching_proc allow_avx512fp16_tests {
     global srcdir subdir gdb_prompt inferior_exited_re
 
-    set me "skip_avx512fp16_tests"
+    set me "allow_avx512fp16_tests"
     if { ![istarget "i?86-*-*"] && ![istarget "x86_64-*-*"] } {
-        verbose "$me:  target does not support avx512fp16, returning 1" 2
-        return 1
+	verbose "$me:  target does not support avx512fp16, returning 0" 2
+	return 0
     }
 
     # Compile a test program.
@@ -3770,7 +3770,7 @@ gdb_caching_proc skip_avx512fp16_tests {
         }
     }
     if {![gdb_simple_compile $me $src executable]} {
-        return 1
+	return 0
     }
 
     # No error message, compilation succeeded so now run it via gdb.
@@ -3783,22 +3783,22 @@ gdb_caching_proc skip_avx512fp16_tests {
     gdb_expect {
         -re ".*Illegal instruction.*${gdb_prompt} $" {
             verbose -log "$me:  avx512fp16 hardware not detected."
-            set skip_avx512fp16_tests 1
+	    set allow_avx512fp16_tests 0
         }
         -re ".*$inferior_exited_re normally.*${gdb_prompt} $" {
             verbose -log "$me:  avx512fp16 hardware detected."
-            set skip_avx512fp16_tests 0
+	    set allow_avx512fp16_tests 1
         }
         default {
             warning "\n$me:  default case taken."
-            set skip_avx512fp16_tests 1
+	    set allow_avx512fp16_tests 0
         }
     }
     gdb_exit
     remote_file build delete $obj
 
-    verbose "$me:  returning $skip_avx512fp16_tests" 2
-    return $skip_avx512fp16_tests
+    verbose "$me:  returning $allow_avx512fp16_tests" 2
+    return $allow_avx512fp16_tests
 }
 
 # Run a test on the target to see if it supports btrace hardware.  Return 0 if so,

                 reply	other threads:[~2023-01-13 20:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113203830.290083858004@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).