From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 8470F3857438; Fri, 13 Jan 2023 20:38:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8470F3857438 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673642335; bh=hyTA6hzsFS4mYN2f3Q5t+KKjYjzwTOYzOkAMf+byfAQ=; h=From:To:Subject:Date:From; b=HNuwDPYVLoIVU8gtD++wFbFjv55AtYpLOxhZOexZBhVwbfcMAm4Q26YNw3PjfrUG5 XPaPsz+4zmSs8YdqV8bne2gkcmP7RtZkUrj0u3mEc6YXMYVOg2XZZt6BCiA/rqc+tw Ej6hXLF9+r7zoVNk24kWP0GH0JiHt4fo30KUMJ70= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Rename to allow_debuginfod_tests X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 30ce6aa427da49fa944de6024387e9ab66f5db11 X-Git-Newrev: 112e10e2e0067ef488bef8f02eeaf86ff9bd5dca Message-Id: <20230113203855.8470F3857438@sourceware.org> Date: Fri, 13 Jan 2023 20:38:55 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D112e10e2e006= 7ef488bef8f02eeaf86ff9bd5dca commit 112e10e2e0067ef488bef8f02eeaf86ff9bd5dca Author: Tom Tromey Date: Sun Jan 8 10:49:20 2023 -0700 Rename to allow_debuginfod_tests =20 This changes skip_debuginfod_tests to invert the sense, and renames it to allow_debuginfod_tests. Diff: --- gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp | 2 +- gdb/testsuite/lib/debuginfod-support.exp | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp b/gdb/t= estsuite/gdb.debuginfod/fetch_src_and_symbols.exp index e2c77eb109f..c9cd8a30a1c 100644 --- a/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp +++ b/gdb/testsuite/gdb.debuginfod/fetch_src_and_symbols.exp @@ -20,7 +20,7 @@ standard_testfile load_lib dwarf.exp load_lib debuginfod-support.exp =20 -require !skip_debuginfod_tests +require allow_debuginfod_tests =20 set sourcetmp [standard_output_file tmp-${srcfile}] set outputdir [standard_output_file {}] diff --git a/gdb/testsuite/lib/debuginfod-support.exp b/gdb/testsuite/lib/d= ebuginfod-support.exp index ad156f23d03..50a8b512a4a 100644 --- a/gdb/testsuite/lib/debuginfod-support.exp +++ b/gdb/testsuite/lib/debuginfod-support.exp @@ -15,20 +15,20 @@ =20 # Helper functions to make it easier to write debuginfod tests. =20 -# Return true if the debuginfod tests should be skipped, otherwise, return +# Return true if the debuginfod tests should be run, otherwise, return # false. -proc skip_debuginfod_tests {} { +proc allow_debuginfod_tests {} { if [is_remote host] { - return true + return false } =20 if { [which debuginfod] =3D=3D 0 } { - return true + return false } =20 if { [which curl] =3D=3D 0 } { untested "cannot find curl" - return true + return false } =20 # Skip testing if gdb was not configured with debuginfod. @@ -39,10 +39,10 @@ proc skip_debuginfod_tests {} { if { [string first "with-debuginfod" \ [eval exec $::GDB --quiet $::INTERNAL_GDBFLAGS \ --configuration]] =3D=3D -1 } { - return true + return false } =20 - return false + return true } =20 # Create two directories within the current output directory. One directo= ry