From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 9602138543B3; Fri, 13 Jan 2023 20:39:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9602138543B3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673642340; bh=9L2yzjx4xAECbftpuaeHEOaX5IcfPm2tbRsXUZ0GFW8=; h=From:To:Subject:Date:From; b=sE93vhb7OYQHWYWQziD5H2xlTf8OlQu9zu/OBsi21U+2nFXGX6yMjgBaZb4cjZaXn MTKKUclQEDza9Hu9CuwpU5bLAm44ikjEPTEb1cHsLjTKbFR6rf1+tJNjmPg2QUdUo4 qVrOtui4+mU3zaq6Ur5SRn1ZUhOFAVxRY9Lly9TU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Rename to allow_dlmopen_tests X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 112e10e2e0067ef488bef8f02eeaf86ff9bd5dca X-Git-Newrev: 673deccaac0a585eec10137d0b77b3e93ccd7372 Message-Id: <20230113203900.9602138543B3@sourceware.org> Date: Fri, 13 Jan 2023 20:39:00 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D673deccaac0a= 585eec10137d0b77b3e93ccd7372 commit 673deccaac0a585eec10137d0b77b3e93ccd7372 Author: Tom Tromey Date: Sun Jan 8 10:50:41 2023 -0700 Rename to allow_dlmopen_tests =20 This changes skip_dlmopen_tests to invert the sense, and renames it to allow_dlmopen_tests. Diff: --- gdb/testsuite/gdb.base/dlmopen.exp | 2 +- gdb/testsuite/lib/gdb.exp | 24 ++++++++++++------------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/gdb/testsuite/gdb.base/dlmopen.exp b/gdb/testsuite/gdb.base/dl= mopen.exp index 54a5eadee2d..ddb832a64f8 100644 --- a/gdb/testsuite/gdb.base/dlmopen.exp +++ b/gdb/testsuite/gdb.base/dlmopen.exp @@ -21,7 +21,7 @@ # We test that GDB shows the correct number of instances of the libraries # the test loaded while unloading them one-by-one. =20 -require !skip_dlmopen_tests +require allow_dlmopen_tests =20 standard_testfile =20 diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index e2feebfab8f..edf26e7b999 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2476,17 +2476,17 @@ proc skip_shlib_tests {} { return 1 } =20 -# Return 1 if we should skip dlmopen tests, 0 if we should not. +# Return 1 if we should run dlmopen tests, 0 if we should not. =20 -gdb_caching_proc skip_dlmopen_tests { +gdb_caching_proc allow_dlmopen_tests { global srcdir subdir gdb_prompt inferior_exited_re =20 # We need shared library support. if { [skip_shlib_tests] } { - return 1 + return 0 } =20 - set me "skip_dlmopen_tests" + set me "allow_dlmopen_tests" set lib { int foo (void) { return 42; @@ -2536,13 +2536,13 @@ gdb_caching_proc skip_dlmopen_tests { =20 if { [gdb_compile_shlib $libsrc $libout {debug}] !=3D "" } { verbose -log "failed to build library" - return 1 + return 0 } if { ![gdb_simple_compile $me $src executable \ [list shlib_load debug \ additional_flags=3D-DDSO_NAME=3D\"$libout\"]] } { verbose -log "failed to build executable" - return 1 + return 0 } =20 gdb_exit @@ -2552,24 +2552,24 @@ gdb_caching_proc skip_dlmopen_tests { =20 if { [gdb_run_cmd] !=3D 0 } { verbose -log "failed to start skip test" - return 1 + return 0 } gdb_expect { -re "$inferior_exited_re normally.*${gdb_prompt} $" { - set skip_dlmopen_tests 0 + set allow_dlmopen_tests 1 } -re "$inferior_exited_re with code.*${gdb_prompt} $" { - set skip_dlmopen_tests 1 + set allow_dlmopen_tests 0 } default { warning "\n$me: default case taken" - set skip_dlmopen_tests 1 + set allow_dlmopen_tests 0 } } gdb_exit =20 - verbose "$me: returning $skip_dlmopen_tests" 2 - return $skip_dlmopen_tests + verbose "$me: returning $allow_dlmopen_tests" 2 + return $allow_dlmopen_tests } =20 # Return 1 if we should skip tui related tests.