From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id CDE05385783F; Fri, 13 Jan 2023 20:39:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CDE05385783F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673642355; bh=VLuUBk8G/grgq7YSyOU5d7NlFINKwRy8L+rLIvQHNpU=; h=From:To:Subject:Date:From; b=uJTnzbWpNqkdiE4EV1D+jNo3eKY5RmNE4dUMWKFpzO++6ByKeE+YCHISHN6zi5lWs EYOsUmDFnWAK4eCmXSB4Y+r6Sth8UFH4VcHFth4SC1ICcKwQEl5V4sK9S5MGUMetFX T5kmhBmWcM1pbeFYTErC+6aEaQxPPqnIfwGnTy+4= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Rename to allow_gdbserver_tests X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 57b7402d206a215ef4689ed402467bbfc82375f3 X-Git-Newrev: cadfc59b0d721599b32fab6eeaba401360602e0f Message-Id: <20230113203915.CDE05385783F@sourceware.org> Date: Fri, 13 Jan 2023 20:39:15 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dcadfc59b0d72= 1599b32fab6eeaba401360602e0f commit cadfc59b0d721599b32fab6eeaba401360602e0f Author: Tom Tromey Date: Sun Jan 8 10:53:55 2023 -0700 Rename to allow_gdbserver_tests =20 This changes skip_gdbserver_tests to invert the sense, and renames it to allow_gdbserver_tests. Diff: --- gdb/testsuite/gdb.btrace/enable.exp | 4 ++-- gdb/testsuite/gdb.btrace/reconnect.exp | 2 +- gdb/testsuite/gdb.mi/mi-file-transfer.exp | 2 +- gdb/testsuite/gdb.multi/attach-no-multi-process.exp | 2 +- gdb/testsuite/gdb.multi/multi-target.exp.tcl | 2 +- gdb/testsuite/gdb.python/py-send-packet.exp | 2 +- gdb/testsuite/gdb.server/abspath.exp | 2 +- gdb/testsuite/gdb.server/attach-flag.exp | 2 +- gdb/testsuite/gdb.server/bkpt-other-inferior.exp | 2 +- gdb/testsuite/gdb.server/connect-stopped-target.exp | 2 +- gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp | 2 +- gdb/testsuite/gdb.server/connect-without-multi-process.exp | 2 +- gdb/testsuite/gdb.server/exit-multiple-threads.exp | 2 +- gdb/testsuite/gdb.server/ext-attach.exp | 2 +- gdb/testsuite/gdb.server/ext-restart.exp | 2 +- gdb/testsuite/gdb.server/ext-run.exp | 2 +- gdb/testsuite/gdb.server/ext-wrapper.exp | 2 +- gdb/testsuite/gdb.server/file-transfer.exp | 2 +- gdb/testsuite/gdb.server/monitor-exit-quit.exp | 2 +- gdb/testsuite/gdb.server/multi-ui-errors.exp | 2 +- gdb/testsuite/gdb.server/no-thread-db.exp | 2 +- gdb/testsuite/gdb.server/non-existing-program.exp | 2 +- gdb/testsuite/gdb.server/reconnect-ctrl-c.exp | 2 +- gdb/testsuite/gdb.server/run-without-local-binary.exp | 2 +- gdb/testsuite/gdb.server/server-connect.exp | 2 +- gdb/testsuite/gdb.server/server-exec-info.exp | 2 +- gdb/testsuite/gdb.server/server-kill-python.exp | 2 +- gdb/testsuite/gdb.server/server-kill.exp | 2 +- gdb/testsuite/gdb.server/server-mon.exp | 2 +- gdb/testsuite/gdb.server/server-pipe.exp | 2 +- gdb/testsuite/gdb.server/server-run.exp | 2 +- gdb/testsuite/gdb.server/solib-list.exp | 2 +- gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp | 2 +- gdb/testsuite/gdb.server/stop-reply-no-thread.exp | 2 +- gdb/testsuite/gdb.server/sysroot.exp | 2 +- gdb/testsuite/gdb.server/twice-connect.exp | 2 +- gdb/testsuite/gdb.server/unittest.exp | 2 +- gdb/testsuite/gdb.server/wrapper.exp | 2 +- gdb/testsuite/lib/gdbserver-support.exp | 14 +++++++---= ---- 39 files changed, 46 insertions(+), 46 deletions(-) diff --git a/gdb/testsuite/gdb.btrace/enable.exp b/gdb/testsuite/gdb.btrace= /enable.exp index acad4c6e828..113b8e18aad 100644 --- a/gdb/testsuite/gdb.btrace/enable.exp +++ b/gdb/testsuite/gdb.btrace/enable.exp @@ -70,13 +70,13 @@ gdb_test "record btrace" "The process is already being = recorded\\. Use \"record # continue to the end and make sure we don't die gdb_test "continue" ".*Inferior.*exited.*" "continue to end" =20 -# skip_gdbserver_tests requires GDB not running. +# allow_gdbserver_tests requires GDB not running. gdb_exit =20 # skip the rerun test when using gdbserver # otherwise rerun twice, target should be automatically disabled load_lib gdbserver-support.exp -if [skip_gdbserver_tests] { +if !{[allow_gdbserver_tests]} { unsupported "target does not support gdbserver" return 0 } diff --git a/gdb/testsuite/gdb.btrace/reconnect.exp b/gdb/testsuite/gdb.btr= ace/reconnect.exp index 1da9f4be566..2c8358327a4 100644 --- a/gdb/testsuite/gdb.btrace/reconnect.exp +++ b/gdb/testsuite/gdb.btrace/reconnect.exp @@ -20,7 +20,7 @@ load_lib gdbserver-support.exp =20 require allow_btrace_tests -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 standard_testfile if [prepare_for_testing "failed to prepare" $testfile $srcfile] { diff --git a/gdb/testsuite/gdb.mi/mi-file-transfer.exp b/gdb/testsuite/gdb.= mi/mi-file-transfer.exp index 71aa2f83cc0..726504c46d8 100644 --- a/gdb/testsuite/gdb.mi/mi-file-transfer.exp +++ b/gdb/testsuite/gdb.mi/mi-file-transfer.exp @@ -20,7 +20,7 @@ load_lib gdbserver-support.exp load_lib mi-support.exp set MIFLAGS "-i=3Dmi" =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 standard_testfile basics.c =20 diff --git a/gdb/testsuite/gdb.multi/attach-no-multi-process.exp b/gdb/test= suite/gdb.multi/attach-no-multi-process.exp index 50b04ad6761..1ef7984078a 100644 --- a/gdb/testsuite/gdb.multi/attach-no-multi-process.exp +++ b/gdb/testsuite/gdb.multi/attach-no-multi-process.exp @@ -22,7 +22,7 @@ load_lib gdbserver-support.exp =20 standard_testfile =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 require can_spawn_for_attach =20 diff --git a/gdb/testsuite/gdb.multi/multi-target.exp.tcl b/gdb/testsuite/g= db.multi/multi-target.exp.tcl index af9b564228f..2356b6c8e6e 100644 --- a/gdb/testsuite/gdb.multi/multi-target.exp.tcl +++ b/gdb/testsuite/gdb.multi/multi-target.exp.tcl @@ -165,7 +165,7 @@ proc setup {non-stop} { proc multi_target_prepare {} { global binfile srcfile =20 - if { [skip_gdbserver_tests] } { + if { ![allow_gdbserver_tests] } { return 0 } =20 diff --git a/gdb/testsuite/gdb.python/py-send-packet.exp b/gdb/testsuite/gd= b.python/py-send-packet.exp index e09dbb05fd4..75e7bb6aa9c 100644 --- a/gdb/testsuite/gdb.python/py-send-packet.exp +++ b/gdb/testsuite/gdb.python/py-send-packet.exp @@ -24,7 +24,7 @@ load_lib gdbserver-support.exp =20 standard_testfile =20 -require !skip_gdbserver_tests !skip_python_tests +require allow_gdbserver_tests !skip_python_tests =20 if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { return -1 diff --git a/gdb/testsuite/gdb.server/abspath.exp b/gdb/testsuite/gdb.serve= r/abspath.exp index 58d9b39efc1..46657c65e8f 100644 --- a/gdb/testsuite/gdb.server/abspath.exp +++ b/gdb/testsuite/gdb.server/abspath.exp @@ -22,7 +22,7 @@ load_lib gdbserver-support.exp =20 standard_testfile normal.c =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 # Because we're relying on being able to change our CWD before # executing gdbserver, we just run if we're not testing with a remote diff --git a/gdb/testsuite/gdb.server/attach-flag.exp b/gdb/testsuite/gdb.s= erver/attach-flag.exp index bb6f3673e4e..ad67303a7dd 100644 --- a/gdb/testsuite/gdb.server/attach-flag.exp +++ b/gdb/testsuite/gdb.server/attach-flag.exp @@ -21,7 +21,7 @@ load_lib gdbserver-support.exp =20 standard_testfile =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 require can_spawn_for_attach =20 diff --git a/gdb/testsuite/gdb.server/bkpt-other-inferior.exp b/gdb/testsui= te/gdb.server/bkpt-other-inferior.exp index fe561d8e924..d4395d2c441 100644 --- a/gdb/testsuite/gdb.server/bkpt-other-inferior.exp +++ b/gdb/testsuite/gdb.server/bkpt-other-inferior.exp @@ -21,7 +21,7 @@ load_lib gdbserver-support.exp =20 standard_testfile server.c =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if { [prepare_for_testing "failed to prepare" ${binfile} "${srcfile}" \ {debug pthreads}] } { diff --git a/gdb/testsuite/gdb.server/connect-stopped-target.exp b/gdb/test= suite/gdb.server/connect-stopped-target.exp index ed193f8599c..2dfe2ea94ac 100644 --- a/gdb/testsuite/gdb.server/connect-stopped-target.exp +++ b/gdb/testsuite/gdb.server/connect-stopped-target.exp @@ -20,7 +20,7 @@ load_lib gdbserver-support.exp load_lib prelink-support.exp =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 standard_testfile set executable ${testfile} diff --git a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp b/gdb= /testsuite/gdb.server/connect-with-no-symbol-file.exp index 159f82f6c3b..b98e566e2d6 100644 --- a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp +++ b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp @@ -25,7 +25,7 @@ load_lib gdbserver-support.exp =20 standard_testfile =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if { [build_executable "failed to prepare" $testfile $srcfile debug] } { return -1 diff --git a/gdb/testsuite/gdb.server/connect-without-multi-process.exp b/g= db/testsuite/gdb.server/connect-without-multi-process.exp index 831ccd6f876..fcd64c9f49a 100644 --- a/gdb/testsuite/gdb.server/connect-without-multi-process.exp +++ b/gdb/testsuite/gdb.server/connect-without-multi-process.exp @@ -18,7 +18,7 @@ =20 load_lib gdbserver-support.exp =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 standard_testfile =20 diff --git a/gdb/testsuite/gdb.server/exit-multiple-threads.exp b/gdb/tests= uite/gdb.server/exit-multiple-threads.exp index 88c4df11ccd..46239e3eabf 100644 --- a/gdb/testsuite/gdb.server/exit-multiple-threads.exp +++ b/gdb/testsuite/gdb.server/exit-multiple-threads.exp @@ -25,7 +25,7 @@ =20 load_lib gdbserver-support.exp =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 standard_testfile =20 diff --git a/gdb/testsuite/gdb.server/ext-attach.exp b/gdb/testsuite/gdb.se= rver/ext-attach.exp index 81b324d4c5f..f7092b0340c 100644 --- a/gdb/testsuite/gdb.server/ext-attach.exp +++ b/gdb/testsuite/gdb.server/ext-attach.exp @@ -22,7 +22,7 @@ load_lib trace-support.exp =20 standard_testfile =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 require can_spawn_for_attach =20 diff --git a/gdb/testsuite/gdb.server/ext-restart.exp b/gdb/testsuite/gdb.s= erver/ext-restart.exp index df26c91fa25..5b6aa7038f2 100644 --- a/gdb/testsuite/gdb.server/ext-restart.exp +++ b/gdb/testsuite/gdb.server/ext-restart.exp @@ -21,7 +21,7 @@ load_lib gdbserver-support.exp =20 standard_testfile server.c =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 save_vars { GDBFLAGS } { # If GDB and GDBserver are both running locally, set the sysroot to av= oid diff --git a/gdb/testsuite/gdb.server/ext-run.exp b/gdb/testsuite/gdb.serve= r/ext-run.exp index 2add84e8b1b..59ead666d7b 100644 --- a/gdb/testsuite/gdb.server/ext-run.exp +++ b/gdb/testsuite/gdb.server/ext-run.exp @@ -21,7 +21,7 @@ load_lib gdbserver-support.exp =20 standard_testfile server.c =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if {[build_executable $testfile.exp $testfile $srcfile debug] =3D=3D -1} { return -1 diff --git a/gdb/testsuite/gdb.server/ext-wrapper.exp b/gdb/testsuite/gdb.s= erver/ext-wrapper.exp index 4f150cfc0a5..2fe601a81aa 100644 --- a/gdb/testsuite/gdb.server/ext-wrapper.exp +++ b/gdb/testsuite/gdb.server/ext-wrapper.exp @@ -19,7 +19,7 @@ load_lib gdbserver-support.exp =20 standard_testfile wrapper.c =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if {[build_executable $testfile.exp $testfile $srcfile debug] =3D=3D -1} { return -1 diff --git a/gdb/testsuite/gdb.server/file-transfer.exp b/gdb/testsuite/gdb= .server/file-transfer.exp index cd98ffee90d..05da514413c 100644 --- a/gdb/testsuite/gdb.server/file-transfer.exp +++ b/gdb/testsuite/gdb.server/file-transfer.exp @@ -20,7 +20,7 @@ load_lib gdbserver-support.exp =20 standard_testfile server.c =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { return -1 diff --git a/gdb/testsuite/gdb.server/monitor-exit-quit.exp b/gdb/testsuite= /gdb.server/monitor-exit-quit.exp index 88eb2e483b9..f253f823896 100644 --- a/gdb/testsuite/gdb.server/monitor-exit-quit.exp +++ b/gdb/testsuite/gdb.server/monitor-exit-quit.exp @@ -21,7 +21,7 @@ load_lib gdbserver-support.exp =20 standard_testfile server.c =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if {[build_executable $testfile.exp $testfile $srcfile debug] =3D=3D -1} { return -1 diff --git a/gdb/testsuite/gdb.server/multi-ui-errors.exp b/gdb/testsuite/g= db.server/multi-ui-errors.exp index 95a08c9bca6..9cc5239d888 100644 --- a/gdb/testsuite/gdb.server/multi-ui-errors.exp +++ b/gdb/testsuite/gdb.server/multi-ui-errors.exp @@ -24,7 +24,7 @@ load_lib gdbserver-support.exp =20 standard_testfile =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 save_vars { GDBFLAGS } { # If GDB and GDBserver are both running locally, set the sysroot to av= oid diff --git a/gdb/testsuite/gdb.server/no-thread-db.exp b/gdb/testsuite/gdb.= server/no-thread-db.exp index 0e2fbae80be..53d04753c40 100644 --- a/gdb/testsuite/gdb.server/no-thread-db.exp +++ b/gdb/testsuite/gdb.server/no-thread-db.exp @@ -25,7 +25,7 @@ load_lib gdbserver-support.exp standard_testfile set unresolvable_thread_db_path "/foo/bar" =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" ex= ecutable {debug}] !=3D "" } { return -1 diff --git a/gdb/testsuite/gdb.server/non-existing-program.exp b/gdb/testsu= ite/gdb.server/non-existing-program.exp index 60ca0a43dfb..32f27fa2b1c 100644 --- a/gdb/testsuite/gdb.server/non-existing-program.exp +++ b/gdb/testsuite/gdb.server/non-existing-program.exp @@ -22,7 +22,7 @@ load_lib gdbserver-support.exp =20 standard_testfile =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 set gdbserver [find_gdbserver] if { $gdbserver =3D=3D "" } { diff --git a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp b/gdb/testsuite/= gdb.server/reconnect-ctrl-c.exp index 42707692c4b..c8ef81443e5 100644 --- a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp +++ b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp @@ -19,7 +19,7 @@ =20 load_lib gdbserver-support.exp =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if [target_info exists gdb,nointerrupts] { verbose "Skipping reconnect-ctrl-c.exp because of nointerrupts." diff --git a/gdb/testsuite/gdb.server/run-without-local-binary.exp b/gdb/te= stsuite/gdb.server/run-without-local-binary.exp index 4f3f0d9af4e..c390eeb435a 100644 --- a/gdb/testsuite/gdb.server/run-without-local-binary.exp +++ b/gdb/testsuite/gdb.server/run-without-local-binary.exp @@ -15,7 +15,7 @@ =20 load_lib gdbserver-support.exp =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 standard_testfile normal.c =20 diff --git a/gdb/testsuite/gdb.server/server-connect.exp b/gdb/testsuite/gd= b.server/server-connect.exp index 76570f34232..6c4c969c30d 100644 --- a/gdb/testsuite/gdb.server/server-connect.exp +++ b/gdb/testsuite/gdb.server/server-connect.exp @@ -22,7 +22,7 @@ load_lib gdbserver-support.exp =20 standard_testfile normal.c =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 # We want to have control over where we start gdbserver. if { [is_remote target] } { diff --git a/gdb/testsuite/gdb.server/server-exec-info.exp b/gdb/testsuite/= gdb.server/server-exec-info.exp index a80c0f96480..b1a392883b0 100644 --- a/gdb/testsuite/gdb.server/server-exec-info.exp +++ b/gdb/testsuite/gdb.server/server-exec-info.exp @@ -18,7 +18,7 @@ load_lib gdbserver-support.exp # We test for skip_shlib_tests in this test because without a main # exec file we only have the exec target loaded if shared libraries # are present. -require !skip_gdbserver_tests !skip_shlib_tests +require allow_gdbserver_tests !skip_shlib_tests =20 standard_testfile server.c if [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] { diff --git a/gdb/testsuite/gdb.server/server-kill-python.exp b/gdb/testsuit= e/gdb.server/server-kill-python.exp index 4ef70daaf90..bc62cbfc431 100644 --- a/gdb/testsuite/gdb.server/server-kill-python.exp +++ b/gdb/testsuite/gdb.server/server-kill-python.exp @@ -23,7 +23,7 @@ load_lib gdbserver-support.exp =20 standard_testfile multi-ui-errors.c =20 -require !skip_gdbserver_tests !skip_python_tests +require allow_gdbserver_tests !skip_python_tests =20 if {[build_executable "failed to prepare" ${testfile} \ ${srcfile}] =3D=3D -1} { diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.s= erver/server-kill.exp index 04b7f62561a..b757369b71c 100644 --- a/gdb/testsuite/gdb.server/server-kill.exp +++ b/gdb/testsuite/gdb.server/server-kill.exp @@ -22,7 +22,7 @@ load_lib gdbserver-support.exp =20 standard_testfile =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if { [build_executable "failed to prepare" ${testfile}] } { return -1 diff --git a/gdb/testsuite/gdb.server/server-mon.exp b/gdb/testsuite/gdb.se= rver/server-mon.exp index 4b728cb8038..728cc84a9e0 100644 --- a/gdb/testsuite/gdb.server/server-mon.exp +++ b/gdb/testsuite/gdb.server/server-mon.exp @@ -21,7 +21,7 @@ load_lib gdbserver-support.exp =20 standard_testfile server.c =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { return -1 diff --git a/gdb/testsuite/gdb.server/server-pipe.exp b/gdb/testsuite/gdb.s= erver/server-pipe.exp index 2038ca9140d..693771e942e 100644 --- a/gdb/testsuite/gdb.server/server-pipe.exp +++ b/gdb/testsuite/gdb.server/server-pipe.exp @@ -32,7 +32,7 @@ load_lib gdbserver-support.exp =20 standard_testfile =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 set gdbserver [find_gdbserver] if { $gdbserver =3D=3D "" } { diff --git a/gdb/testsuite/gdb.server/server-run.exp b/gdb/testsuite/gdb.se= rver/server-run.exp index 55b40057f91..35f499f7d1a 100644 --- a/gdb/testsuite/gdb.server/server-run.exp +++ b/gdb/testsuite/gdb.server/server-run.exp @@ -21,7 +21,7 @@ load_lib gdbserver-support.exp =20 standard_testfile server.c =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if {[build_executable $testfile.exp $testfile $srcfile debug] =3D=3D -1} { return -1 diff --git a/gdb/testsuite/gdb.server/solib-list.exp b/gdb/testsuite/gdb.se= rver/solib-list.exp index f22ec8956c4..ef99be74747 100644 --- a/gdb/testsuite/gdb.server/solib-list.exp +++ b/gdb/testsuite/gdb.server/solib-list.exp @@ -23,7 +23,7 @@ load_lib gdbserver-support.exp load_lib prelink-support.exp =20 -require !skip_gdbserver_tests !skip_shlib_tests +require allow_gdbserver_tests !skip_shlib_tests =20 standard_testfile solib-list-main.c set srclibfile ${testfile}-lib.c diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp b/gdb/= testsuite/gdb.server/stop-reply-no-thread-multi.exp index 066f2a1b736..20d45ba17da 100644 --- a/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp +++ b/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp @@ -30,7 +30,7 @@ =20 load_lib gdbserver-support.exp =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 standard_testfile if { [build_executable "failed to prepare" $testfile $srcfile {debug pthre= ads}] =3D=3D -1 } { diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp b/gdb/testsu= ite/gdb.server/stop-reply-no-thread.exp index 134ab6a9c29..848ada128f3 100644 --- a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp +++ b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp @@ -22,7 +22,7 @@ =20 load_lib gdbserver-support.exp =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 standard_testfile if { [build_executable "failed to prepare" $testfile $srcfile] =3D=3D -1 }= { diff --git a/gdb/testsuite/gdb.server/sysroot.exp b/gdb/testsuite/gdb.serve= r/sysroot.exp index 9845a7a8333..715d6001020 100644 --- a/gdb/testsuite/gdb.server/sysroot.exp +++ b/gdb/testsuite/gdb.server/sysroot.exp @@ -20,7 +20,7 @@ =20 load_lib gdbserver-support.exp =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile "additional_f= lags=3D--no-builtin"] =3D=3D -1} { diff --git a/gdb/testsuite/gdb.server/twice-connect.exp b/gdb/testsuite/gdb= .server/twice-connect.exp index a8318c0de4a..8ff8334f5f2 100644 --- a/gdb/testsuite/gdb.server/twice-connect.exp +++ b/gdb/testsuite/gdb.server/twice-connect.exp @@ -19,7 +19,7 @@ load_lib gdbserver-support.exp =20 standard_testfile =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if { [build_executable "failed to prepare" $::testfile $::srcfile \ {debug}] } { diff --git a/gdb/testsuite/gdb.server/unittest.exp b/gdb/testsuite/gdb.serv= er/unittest.exp index f727892fdc8..d25ee362644 100644 --- a/gdb/testsuite/gdb.server/unittest.exp +++ b/gdb/testsuite/gdb.server/unittest.exp @@ -19,7 +19,7 @@ load_lib gdbserver-support.exp =20 standard_testfile =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 global server_spawn_id =20 diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.serve= r/wrapper.exp index caaa4f69afb..ec985e0da2e 100644 --- a/gdb/testsuite/gdb.server/wrapper.exp +++ b/gdb/testsuite/gdb.server/wrapper.exp @@ -21,7 +21,7 @@ load_lib gdbserver-support.exp =20 standard_testfile =20 -require !skip_gdbserver_tests +require allow_gdbserver_tests =20 if { [istarget *-*-mingw*] || [istarget *-*-cygwin*] } { diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gd= bserver-support.exp index 49ae56190c2..30d94fd7eb6 100644 --- a/gdb/testsuite/lib/gdbserver-support.exp +++ b/gdb/testsuite/lib/gdbserver-support.exp @@ -160,12 +160,12 @@ proc find_gdbserver { } { return "" } =20 -# Return non-zero if we should skip gdbserver-specific tests. +# Return non-zero if we should run gdbserver-specific tests. =20 -proc skip_gdbserver_tests { } { - if { [find_gdbserver] =3D=3D "" } { - return 1 - } +proc allow_gdbserver_tests { } { + if { [find_gdbserver] =3D=3D "" } { + return 0 + } =20 # If GDB is lack of XML support, and targets, like arm, have # multiple target descriptions, GDB doesn't know which target @@ -179,10 +179,10 @@ proc skip_gdbserver_tests { } { || [istarget "s390*-*-linux*"] || [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"]) } { - return 1 + return 0 } =20 - return 0 + return 1 } =20 # Download the currently loaded program to the target if necessary.