From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 0C6393858D1E; Sat, 14 Jan 2023 19:49:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C6393858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673725745; bh=S1l6p2eU4XOEGbYMU7fWy6ugRvtaXubzt8cF2KMFeLU=; h=From:To:Subject:Date:From; b=GiB9/6Dxsc7ts9Vx1gusWukTV3xITbAnxm9KlFeV6oy1dfxY4ZFnM91E/qCgoTj/n Zipw+7PXNfAg8uHZYknnuXkDcABHaSBcL8ntT8HNTcyjIIpVlwzyzupBkKKnUX5A5c 78Z7CI9XWH9rsbNxKNO4IGmUFCpviqvz2k2B6D5A= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Pass internal gdb flags to --configuration invocations X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 311578da0f0e282c09732944e11fae89a30aeaef X-Git-Newrev: 856cd0786ccea2f0b39d36024187c415e0a27d76 Message-Id: <20230114194905.0C6393858D1E@sourceware.org> Date: Sat, 14 Jan 2023 19:49:05 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D856cd0786cce= a2f0b39d36024187c415e0a27d76 commit 856cd0786ccea2f0b39d36024187c415e0a27d76 Author: Tom Tromey Date: Sat Jan 14 12:42:30 2023 -0700 Pass internal gdb flags to --configuration invocations =20 The test suite uses the --configuration flag to feature-test gdb. However, when I added this, I neglected to pass the internal gdbflags to this, causing an error, which then caused failures in the test suite (which would not be seen if you'd ever run "make install"). =20 This patch fixes the bug. Tested by removing my install tree first, to verify that I could reproduce the failure. Diff: --- gdb/testsuite/lib/gdb-guile.exp | 2 +- gdb/testsuite/lib/gdb.exp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/lib/gdb-guile.exp b/gdb/testsuite/lib/gdb-guile.= exp index f2307372b8b..50189c8ed90 100644 --- a/gdb/testsuite/lib/gdb-guile.exp +++ b/gdb/testsuite/lib/gdb-guile.exp @@ -21,7 +21,7 @@ set ghex {[0-9a-f]+} # Return a 1 for configurations that support Guile scripting. =20 gdb_caching_proc allow_guile_tests { - set output [exec $::GDB --configuration] + set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configurat= ion"] return [expr {[string first "--with-guile" $output] !=3D -1}] } =20 diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 5359315667e..68337bd235c 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2450,7 +2450,7 @@ proc allow_rust_tests {} { # Return a 1 for configurations that support Python scripting. =20 gdb_caching_proc allow_python_tests { - set output [remote_exec host $::GDB --configuration] + set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configurat= ion"] return [expr {[string first "--with-python" $output] !=3D -1}] } =20 @@ -2575,7 +2575,7 @@ gdb_caching_proc allow_dlmopen_tests { # Return 1 if we should allow TUI-related tests. =20 gdb_caching_proc allow_tui_tests { - set output [remote_exec host $::GDB --configuration] + set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configurat= ion"] return [expr {[string first "--enable-tui" $output] !=3D -1}] }