From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id E86933858C60; Tue, 17 Jan 2023 14:05:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E86933858C60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1673964348; bh=4uZ2l85rIvOHwW6aiFEPO2H68VXEvXuaMMa0HP2zcmY=; h=From:To:Subject:Date:From; b=m8DM9bUlEoR0YaFyTUE66WNR4pgjbbbEO9KznC9DItBI+fSoYiDnHWCpYOI9scTSo Kjg+cc3xO5IRPRXkob0S9k0U3/sitU+ykgP5aH3gNEBMw/IIfNY5TT1peeTJGSPEOm lr8/+q+dHdu5bKnS3Nt34BJRGCdSQOR9L91gtvmk= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Don't erase empty indices in DWARF reader X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 63078a04984b73e1fdeb4571a63605ee5c13f929 X-Git-Newrev: 1a6191f1a614f61d20bfe414b81c39a8ca785cc7 Message-Id: <20230117140548.E86933858C60@sourceware.org> Date: Tue, 17 Jan 2023 14:05:48 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D1a6191f1a614= f61d20bfe414b81c39a8ca785cc7 commit 1a6191f1a614f61d20bfe414b81c39a8ca785cc7 Author: Tom Tromey Date: Wed Dec 14 07:20:49 2022 -0700 Don't erase empty indices in DWARF reader =20 The DWARF reader has some code to remove empty indices. However, I think this code has been obsolete since some earlier changes to parallel_for_each. This patch removes this code. Diff: --- gdb/dwarf2/read.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 851852404eb..c3f246fedf7 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -7170,16 +7170,6 @@ dwarf2_build_psymtabs_hard (dwarf2_per_objfile *per_= objfile) print_tu_stats (per_objfile); =20 indexes.push_back (index_storage.release ()); - /* Remove any NULL entries. This might happen if parallel-for - decides to throttle the number of threads that were used. */ - indexes.erase - (std::remove_if (indexes.begin (), - indexes.end (), - [] (const std::unique_ptr &entry) - { - return entry =3D=3D nullptr; - }), - indexes.end ()); indexes.shrink_to_fit (); =20 cooked_index_vector *vec =3D new cooked_index_vector (std::move (indexes= ));