public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Fix 'make TAGS' in gdbserver
Date: Wed, 18 Jan 2023 18:12:40 +0000 (GMT)	[thread overview]
Message-ID: <20230118181240.BD7393858D28@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bd3014572d687e6d6e9d27a46d5b19a4a5528e85

commit bd3014572d687e6d6e9d27a46d5b19a4a5528e85
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Dec 23 13:28:20 2022 -0700

    Fix 'make TAGS' in gdbserver
    
    PR build/29003 points out that "make TAGS" is broken in gdbserver.
    This patch fixes the problem that is pointed out there, plus another
    one I noticed while working on that -- namely that the "sed" computes
    the wrong names for some source files.  Finally, a couple of obsolete
    variable references are removed.
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29003

Diff:
---
 gdbserver/Makefile.in | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in
index 040f0b6faa0..39cb9e7a151 100644
--- a/gdbserver/Makefile.in
+++ b/gdbserver/Makefile.in
@@ -235,7 +235,7 @@ DEPFILES = @GDBSERVER_DEPFILES@
 LIBOBJS = @LIBOBJS@
 
 SOURCES = $(SFILES)
-TAGFILES = $(SOURCES) ${HFILES} ${ALLPARAM} ${POSSLIBS}
+TAGFILES = $(SOURCES)
 
 OBS = \
 	alloc.o \
@@ -398,8 +398,9 @@ TAGS:	${TAGFILES}
 	etags \
 	  `for i in yzzy ${DEPFILES}; do \
 	     if [ x$$i != xyzzy ]; then \
-	       echo ${srcdir}/$$i | sed -e 's/\.o$$/\.cc/' \
-		 -e 's,/\(arch\|nat\|target\)/,/../\1/,' \
+	       echo ${srcdir}/$$i | \
+		 sed -e 's,/\(\(arch\|nat\|target\)/.*\)\.o$$,/../gdb/\1.c,' \
+		     -e 's/\.o$$/\.cc/'; \
 	     fi; \
 	   done` \
 	  ${TAGFILES}

                 reply	other threads:[~2023-01-18 18:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230118181240.BD7393858D28@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).