public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Use "maint ignore-probes" in no-libstdcxx-probe.exp
Date: Thu, 19 Jan 2023 22:19:55 +0000 (GMT)	[thread overview]
Message-ID: <20230119221955.A3D803858CDA@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=3db27e74ee6175a2c73f3481ae5c5b8b2e4bc18f

commit 3db27e74ee6175a2c73f3481ae5c5b8b2e4bc18f
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Jan 19 11:26:53 2023 -0700

    Use "maint ignore-probes" in no-libstdcxx-probe.exp
    
    While looking at some test output, I saw that no-libstdcxx-probe.exp
    was not being run.  However, it occurred to me that Tom de Vries' new
    "maint ignore-probes" command could be used to enable this test
    unconditionally.
    
    Reviewed-by: Tom de Vries <tdevries@suse.de>

Diff:
---
 gdb/testsuite/gdb.cp/no-libstdcxx-probe.exp | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/gdb/testsuite/gdb.cp/no-libstdcxx-probe.exp b/gdb/testsuite/gdb.cp/no-libstdcxx-probe.exp
index b10daa638e6..752298af55d 100644
--- a/gdb/testsuite/gdb.cp/no-libstdcxx-probe.exp
+++ b/gdb/testsuite/gdb.cp/no-libstdcxx-probe.exp
@@ -21,12 +21,11 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile {debug c++}]} {
     return -1
 }
 
-if {![runto_main]} {
-    return -1
-}
+# This tests that $_exception gives an error when the systemtap probes
+# are not available, so simulate this by disabling them.
+gdb_test "maint ignore-probes libstdcxx .*" ".*OBJNAME: ''"
 
-if { [skip_libstdcxx_probe_tests] == 0 } {
-    untested "Have libstdc++ stap probe"
+if {![runto_main]} {
     return -1
 }

                 reply	other threads:[~2023-01-19 22:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230119221955.A3D803858CDA@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).