From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1879) id BFB4C389850C; Fri, 20 Jan 2023 16:51:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BFB4C389850C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674233519; bh=jF0h0Pc/qUFVBCJgW5WA4RsuD73P/HLpUsgwtr4VJZs=; h=From:To:Subject:Date:From; b=uH5BSKjKWl2h9t2KeFS09axvcDvYKp+2rTlpKtOJei8Ro2u503cRJSB0yEmB5m/wp fODScP1FH4LPa+IMHdhLqHW8z5s78VY9RSmuG9TQfcoF3FUSQIZaUvNZLOhKgBCHty wX9ZoozZ1KZdx0GX50EXjMxPgd+o66faEIDNkaBs= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Simon Marchi To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/testsuite: add test for negative subrange bounds with unsigned form X-Act-Checkin: binutils-gdb X-Git-Author: Simon Marchi X-Git-Refname: refs/heads/master X-Git-Oldrev: ec15b12d0684b41f67b56623f6e9b5024bf08905 X-Git-Newrev: 173628ae6896d4cadddcb0c3034206d7cc9fb19a Message-Id: <20230120165159.BFB4C389850C@sourceware.org> Date: Fri, 20 Jan 2023 16:51:59 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D173628ae6896= d4cadddcb0c3034206d7cc9fb19a commit 173628ae6896d4cadddcb0c3034206d7cc9fb19a Author: Simon Marchi Date: Fri Jan 20 11:41:08 2023 -0500 gdb/testsuite: add test for negative subrange bounds with unsigned form =20 I am looking at this code [1]: =20 /* Normally, the DWARF producers are expected to use a signed constant form (Eg. DW_FORM_sdata) to express negative bounds. But this is unfortunately not always the case, as witnessed with GCC, for instance, where the ambiguous DW_FORM_dataN form is used instead. To work around that ambiguity, we treat the bounds as signed, and thus sign-extend their values, when the base type is signed. */ negative_mask =3D -((ULONGEST) 1 << (base_type->length () * TARGET_CHAR_BIT - 1)); if (low.kind () =3D=3D PROP_CONST && !base_type->is_unsigned () && (low.const_val () & negative_mas= k)) low.set_const_val (low.const_val () | negative_mask); if (high.kind () =3D=3D PROP_CONST && !base_type->is_unsigned () && (high.const_val () & negative_ma= sk)) high.set_const_val (high.const_val () | negative_mask); =20 Nothing in the testsuite seems to exercise it, as when I remove it, all of gdb.dwarf2 still passes. And tests in other directories would be compiler-dependent, so would rely on having a buggy compiler. =20 Update gdb.dwarf2/subrange.exp to have a test for it. When removing the code above, the new test fails with: =20 ptype array_with_buggy_negative_bounds_type^M type =3D array [240..244] of signed_byte^M (gdb) FAIL: gdb.dwarf2/subrange.exp: ptype array_with_buggy_negative_= bounds_type =20 instead of the expected: =20 ptype array_with_buggy_negative_bounds_type^M type =3D array [-16..-12] of signed_byte^M (gdb) PASS: gdb.dwarf2/subrange.exp: ptype array_with_buggy_negative_= bounds_type =20 [1] https://gitlab.com/gnutools/binutils-gdb/-/blob/5ea14aa4e53fa37f4ba= 4517497ed2c1e4c60dee2/gdb/dwarf2/read.c#L17681-17695 =20 Change-Id: I1992a3ff0cb1e90fa8a9114dae6c591792f059c2 Diff: --- gdb/testsuite/gdb.dwarf2/subrange.exp | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gdb/testsuite/gdb.dwarf2/subrange.exp b/gdb/testsuite/gdb.dwar= f2/subrange.exp index 72d7babc88e..97743ee1099 100644 --- a/gdb/testsuite/gdb.dwarf2/subrange.exp +++ b/gdb/testsuite/gdb.dwarf2/subrange.exp @@ -28,6 +28,7 @@ Dwarf::assemble $asm_file { compile_unit {{language @DW_LANG_Pascal83}} { declare_labels byte_label typedef_label array_label =20 + # A subrange's underlying type that is a typedef. byte_label: base_type { {name byte} {encoding @DW_ATE_unsigned} @@ -54,6 +55,28 @@ Dwarf::assemble $asm_file { {name TByteArray} {type :$array_label} } + + # This subrange's underlying type is signed, but the bounds are + # specified using a non-signed form. + declare_labels signed_byte_label subrange_with_buggy_negative_bounds_= label + + signed_byte_label: base_type { + {name signed_byte} + {encoding @DW_ATE_signed} + {byte_size 1 DW_FORM_sdata} + } + + # The bounds mean -16 to -12. + subrange_with_buggy_negative_bounds_label: subrange_type { + {lower_bound 0xf0 DW_FORM_udata} + {upper_bound 0xf4 DW_FORM_udata} + {type :$signed_byte_label} + } + + DW_TAG_variable { + {name subrange_with_buggy_negative_bounds_variable} + {type :$subrange_with_buggy_negative_bounds_label} + } } } } @@ -67,3 +90,5 @@ gdb_test_no_output "set language pascal" =20 gdb_test "ptype TByteArray" \ "type =3D array \\\[0\\.\\.191\\\] of byte" +gdb_test "ptype subrange_with_buggy_negative_bounds_variable" \ + "type =3D -16\\.\\.-12"