public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb: add frame_id::user_created_p
@ 2023-01-20 19:52 Simon Marchi
  0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2023-01-20 19:52 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=848ab2ae8afe44843b8d06676604a48e45fa8969

commit 848ab2ae8afe44843b8d06676604a48e45fa8969
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Tue Dec 13 22:34:35 2022 -0500

    gdb: add frame_id::user_created_p
    
    Later in this series, we'll need to differentiate frame ids for regular
    frames (obtained from the target state and unwinding from it) vs frame
    ids for user-created frames (created with create_new_frame).  Add the
    frame_id::user_created_p field to indicate a frame is user-created, and
    set it in create_new_frame.
    
    The field is otherwise not used yet, so not changes in behavior are
    expected.
    
    Change-Id: I60de3ce581ed01bf0fddb30dff9bd932840120c3
    Reviewed-By: Bruno Larsen <blarsen@redhat.com>

Diff:
---
 gdb/frame-id.h | 4 ++++
 gdb/frame.c    | 1 +
 2 files changed, 5 insertions(+)

diff --git a/gdb/frame-id.h b/gdb/frame-id.h
index e8b9a795403..5978d99bba8 100644
--- a/gdb/frame-id.h
+++ b/gdb/frame-id.h
@@ -99,6 +99,10 @@ struct frame_id
   unsigned int code_addr_p : 1;
   unsigned int special_addr_p : 1;
 
+  /* True if this frame was created from addresses given by the user (see
+     create_new_frame) rather than through unwinding.  */
+  unsigned int user_created_p : 1;
+
   /* It is non-zero for a frame made up by GDB without stack data
      representation in inferior, such as INLINE_FRAME or TAILCALL_FRAME.
      Caller of inlined function will have it zero, each more inner called frame
diff --git a/gdb/frame.c b/gdb/frame.c
index b5f48399703..4dcfad37cd7 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -1953,6 +1953,7 @@ create_new_frame (CORE_ADDR addr, CORE_ADDR pc)
 
   fi->this_id.p = frame_id_status::COMPUTED;
   fi->this_id.value = frame_id_build (addr, pc);
+  fi->this_id.value.user_created_p = 1;
 
   frame_debug_printf ("  -> %s", fi->to_string ().c_str ());

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-20 19:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-20 19:52 [binutils-gdb] gdb: add frame_id::user_created_p Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).