public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix untested in gdb.base/frame-view.exp
Date: Mon, 23 Jan 2023 07:59:24 +0000 (GMT)	[thread overview]
Message-ID: <20230123075924.734AE3858D32@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bc0c6793fb45b491c6324614298a2880a34d3966

commit bc0c6793fb45b491c6324614298a2880a34d3966
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Jan 23 08:59:20 2023 +0100

    [gdb/testsuite] Fix untested in gdb.base/frame-view.exp
    
    When running test-case gdb.base/frame-view.exp, I see:
    ...
    gdb compile failed, ld: frame-view0.o: in function `main':
    frame-view.c:73: undefined reference to `pthread_create'
    ld: frame-view.c:76: undefined reference to `pthread_join'
    collect2: error: ld returned 1 exit status
    UNTESTED: gdb.base/frame-view.exp: failed to prepare
    ...
    
    Fix this by adding pthreads to the compilation flags.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.base/frame-view.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/frame-view.exp b/gdb/testsuite/gdb.base/frame-view.exp
index edae16735ab..72955bd1aff 100644
--- a/gdb/testsuite/gdb.base/frame-view.exp
+++ b/gdb/testsuite/gdb.base/frame-view.exp
@@ -18,7 +18,7 @@
 standard_testfile
 
 if { [build_executable "failed to prepare" \
-	${testfile} ${srcfile}] } {
+	  ${testfile} ${srcfile} {debug pthreads}] } {
     return
 }

                 reply	other threads:[~2023-01-23  7:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230123075924.734AE3858D32@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).