public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb/testsuite: use test_gdb_complete_unique more in C++ tests
Date: Wed, 25 Jan 2023 10:13:02 +0000 (GMT)	[thread overview]
Message-ID: <20230125101302.AEB7D3858D33@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7e5afb58f99052708c460cc3f7b9cc5773a1e45f

commit 7e5afb58f99052708c460cc3f7b9cc5773a1e45f
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Thu Jan 12 13:21:27 2023 +0000

    gdb/testsuite: use test_gdb_complete_unique more in C++ tests
    
    Spotted in gdb.cp/cpcompletion.exp that we could replace some uses of
    gdb_test with test_gdb_complete_unique, this will extend the
    completion testing to check tab-completion as well as completion using
    the 'complete' command in some additional cases.

Diff:
---
 gdb/testsuite/gdb.cp/cpcompletion.exp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gdb/testsuite/gdb.cp/cpcompletion.exp b/gdb/testsuite/gdb.cp/cpcompletion.exp
index 82a7ffb6fb4..d69aac6f79f 100644
--- a/gdb/testsuite/gdb.cp/cpcompletion.exp
+++ b/gdb/testsuite/gdb.cp/cpcompletion.exp
@@ -85,16 +85,16 @@ if {![runto "${srcfile}:$bp_location"]} {
 
 # This also tests inheritance -- completion should only see a single
 # "get_foo".
-gdb_test "complete p foo1.g" "p foo1\\.get_foo"
+test_gdb_complete_unique "p foo1.g" "p foo1.get_foo"
 
 # Test inheritance without overriding.
-gdb_test "complete p foo1.base" "p foo1\\.base_function_only"
+test_gdb_complete_unique "p foo1.base" "p foo1.base_function_only"
 
 # Test non-completion of constructor names.
-gdb_test "complete p foo1.Fo" "p foo1\\.Foofoo"
+test_gdb_complete_unique "p foo1.Fo" "p foo1.Foofoo"
 
 # Test completion with an anonymous struct.
-gdb_test "complete p a.g" "p a\\.get"
+test_gdb_complete_unique "p a.g" "p a.get"
 
 with_test_prefix "expression with namespace" {
     # Before the scope operator, GDB shows all the symbols whose

                 reply	other threads:[~2023-01-25 10:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230125101302.AEB7D3858D33@sourceware.org \
    --to=aburgess@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).