From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1726) id 023033858023; Wed, 25 Jan 2023 11:27:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 023033858023 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674646032; bh=aa6w7+nzwHzbmHCOj1JUBHg2bzBXXIQR+0R6AgpUiZ8=; h=From:To:Subject:Date:From; b=tk2oq5uAUE8h+PWQP97SEtXOm2eq9kfZpptYOcnXxFnSYHH4jqwAsjzYeCqAtMjAo y1UnKTU4bgenflMdWoODZ+k8sFbgE7FyBTXyv7lDfqwqxXRaDpJK9MQeQZun3vsWAx 1/NdWV7vS4x+LkWFgfqNKyPo+4Rqy+LVyzSWYDL8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Andrew Burgess To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/testsuite: update gdb.tui/tui-disasm-long-lines.exp X-Act-Checkin: binutils-gdb X-Git-Author: Andrew Burgess X-Git-Refname: refs/heads/master X-Git-Oldrev: b3b0595ff66d8597637c415f74d43dd459a18cb3 X-Git-Newrev: 843a1a4f735e77147710b307db29a1b5f4e1c707 Message-Id: <20230125112712.023033858023@sourceware.org> Date: Wed, 25 Jan 2023 11:27:12 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D843a1a4f735e= 77147710b307db29a1b5f4e1c707 commit 843a1a4f735e77147710b307db29a1b5f4e1c707 Author: Andrew Burgess Date: Tue Dec 20 16:25:33 2022 +0000 gdb/testsuite: update gdb.tui/tui-disasm-long-lines.exp =20 Following on from the previous commit, in this commit I am updating the test script gdb.tui/tui-disasm-long-lines.exp to take account of the changes in commit: =20 commit 9162a27c5f5828240b53379d735679e2a69a9f41 Date: Tue Nov 13 11:59:03 2018 -0700 =20 Change gdb test suite's TERM setting =20 In the above commit the TERM environment variable was changed to be 'dumb' by default, which means that tests, that previously activated tui mode, no longer do unless TERM is set to 'ansi'. =20 As the gdb.tui/tui-disasm-long-lines.exp script didn't do this, the test stopped working. As the expect patterns in this script were pretty generic no tests actually started failing, and we never noticed. =20 In this commit I update the script to use Term::clean_restart, which correctly sets TERM to 'ansi'. I've also added a check that the asm box does appear on the screen, which should indicate that tui mode has correctly activated. =20 However, I also notice that GDB doesn't appear to fully work correctly. The test should display the disassembly for the test program, but it doesn't. =20 The test is trying to disassemble some code that (deliberately) uses a very long symbol name, this eventually results in GDB entering tui_source_window_base::show_source_content and trying to allocate an ncurses pad in order to hold the current page of disassembler output. =20 Unfortunately, due to the very long line, the call to newpad fails, meaning that tui_source_window_base::m_pad is nullptr. Luckily non of the following calls appear to crash when passed a nullptr, however, all the output that is written to the pad is lost, which is why we don't see any assembly code written to the screen. =20 As the test history indicates that the script was originally checking for a crash in GDB when the long identifier was encountered, I think there is value in just leaving the test as it is for now, I have a fix for the issue of the newpad call failing, which I'll post in a follow up commit later. Diff: --- gdb/testsuite/gdb.tui/tui-disasm-long-lines.exp | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/gdb.tui/tui-disasm-long-lines.exp b/gdb/testsuit= e/gdb.tui/tui-disasm-long-lines.exp index 7e3cff3950b..ae19f2e69cb 100644 --- a/gdb/testsuite/gdb.tui/tui-disasm-long-lines.exp +++ b/gdb/testsuite/gdb.tui/tui-disasm-long-lines.exp @@ -16,6 +16,10 @@ # Test that the logic for displaying the TUI disassembly window # handles very long lines. =20 +require allow_tui_tests + +tuiterm_env + standard_testfile =20 set ccopts {debug quiet} @@ -31,13 +35,16 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "$bi= nfile" \ } } =20 -clean_restart "$binfile" - -if {![allow_tui_tests]} { - # TUI support is disabled. Check for error message. - gdb_test "layout asm" "Undefined command: \"layout\". Try \"help\"." +Term::clean_restart 24 80 $binfile +if {![Term::prepare_for_tui]} { + unsupported "TUI not supported" return } =20 -# Just check the command does not cause gdb to crash. -gdb_test "layout asm" +# Just check the command does not cause gdb to crash. It is worth +# noting that the asm window does infact fail to correctly display the +# disassembler output at this point, but initially we are just +# checking that GDB doesn't crash, fixing the asm display will come +# later. +Term::command_no_prompt_prefix "layout asm" +Term::check_box "asm box" 0 0 80 15