public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix gdb.base/unwind-on-each-insn.exp for -m32
Date: Wed, 25 Jan 2023 15:35:57 +0000 (GMT)	[thread overview]
Message-ID: <20230125153557.895553858D33@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9bf5a417591587233e1580973c8a64dfd4c2ac32

commit 9bf5a417591587233e1580973c8a64dfd4c2ac32
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Jan 25 16:35:53 2023 +0100

    [gdb/testsuite] Fix gdb.base/unwind-on-each-insn.exp for -m32
    
    With test-case gdb.base/unwind-on-each-insn.exp and target board unix/-m32, I
    now get:
    ...
     # of expected passes            25
    ...
    instead of:
    ...
     # of expected passes            133
    ...
    as I used to get before commit d25a8dbc7c3 ("[gdb/testsuite] Allow debug
    srcfile2 in gdb.base/unwind-on-each-insn.exp"), due to the test-case trying to match
    "rip = " and info frame printing "eip = " instead.
    
    Fix this by dropping "rip" from the regexp.
    
    Tested on x86_64-linux, target boards unix/{-m64,-m32}.

Diff:
---
 gdb/testsuite/gdb.base/unwind-on-each-insn.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/unwind-on-each-insn.exp b/gdb/testsuite/gdb.base/unwind-on-each-insn.exp
index 059967a2b2e..0d0683659c3 100644
--- a/gdb/testsuite/gdb.base/unwind-on-each-insn.exp
+++ b/gdb/testsuite/gdb.base/unwind-on-each-insn.exp
@@ -146,7 +146,7 @@ proc do_test { function step_cmd } {
 
 	    set in_fn 0
 	    gdb_test_multiple "info frame" "" {
-		-re -wrap "rip = $::hex in ${function}( \\(.*\\))?;.*" {
+		-re -wrap " = $::hex in ${function}( \\(.*\\))?;.*" {
 		    set in_fn 1
 		}
 		-re -wrap "" {}

                 reply	other threads:[~2023-01-25 15:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230125153557.895553858D33@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).