From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 129863858C53; Wed, 25 Jan 2023 16:21:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 129863858C53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674663672; bh=IJvq8nnuzzoiDmS8g7TSZFWEnDv+xcGEGm0ChbVo5I0=; h=From:To:Subject:Date:From; b=EwJznDEvdy5VRvgNqakwEC86w0wON9Fxvbx1T7OZ7GXaPTPUCkAgBIIe7QSlaatGe hJsjpgI0nZMvn6dPaSdLR/OmDvxEGPvjKuEoeS1Ql8UjenULIygQN6qvBOyEKmkG3g 50jpfXPjKn0ixGXsWGBT6NoB0E61A52tDZ9D1/jk= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Rename skip_power_isa_3_1_tests to allow form X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: 42abd7386e63a5637e46b0705896e0d86dd4e490 X-Git-Newrev: ad1046e1cbf611718dc06a2d7154231e023d9296 Message-Id: <20230125162112.129863858C53@sourceware.org> Date: Wed, 25 Jan 2023 16:21:12 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dad1046e1cbf6= 11718dc06a2d7154231e023d9296 commit ad1046e1cbf611718dc06a2d7154231e023d9296 Author: Tom Tromey Date: Sun Jan 22 09:12:30 2023 -0700 Rename skip_power_isa_3_1_tests to allow form =20 This renames skip_power_isa_3_1_tests to allow_power_isa_3_1_tests and updates its users to use require. Diff: --- gdb/testsuite/gdb.arch/powerpc-plxv-nonrel.exp | 3 ++- gdb/testsuite/gdb.reverse/ppc_record_test_isa_3_1.exp | 3 ++- gdb/testsuite/lib/gdb.exp | 18 +++++++++------= --- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.arch/powerpc-plxv-nonrel.exp b/gdb/testsuite= /gdb.arch/powerpc-plxv-nonrel.exp index a1aacb05070..1ad3ea8bde4 100644 --- a/gdb/testsuite/gdb.arch/powerpc-plxv-nonrel.exp +++ b/gdb/testsuite/gdb.arch/powerpc-plxv-nonrel.exp @@ -16,10 +16,11 @@ # Test to see if gdb is properly single stepping over the # displaced plxv instruction. =20 -if { ![istarget powerpc*-*] || [skip_power_isa_3_1_tests] } { +if { ![istarget powerpc*-*] } { verbose "Skipping powerpc ISA 3.1 plxv test." return } +require allow_power_isa_3_1_tests =20 set retval 0 =20 diff --git a/gdb/testsuite/gdb.reverse/ppc_record_test_isa_3_1.exp b/gdb/te= stsuite/gdb.reverse/ppc_record_test_isa_3_1.exp index f6bf4857fdf..7a291aaa49d 100644 --- a/gdb/testsuite/gdb.reverse/ppc_record_test_isa_3_1.exp +++ b/gdb/testsuite/gdb.reverse/ppc_record_test_isa_3_1.exp @@ -37,10 +37,11 @@ standard_testfile set gen_src record_test_isa_3_1.c set executable record_test_isa_3_1 =20 -if {![istarget "powerpc*"] || [skip_power_isa_3_1_tests]} { +if {![istarget "powerpc*"]} { verbose "Skipping PowerPC ISA 3.1 instruction record_test." return } +require allow_power_isa_3_1_tests =20 set options [list additional_flags=3D-mcpu=3Dpower10 debug] if {[build_executable "failed to prepare" $executable $srcfile $options] = =3D=3D -1} { diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 2c53ebe7774..5425ae74cb9 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -3525,10 +3525,10 @@ gdb_caching_proc allow_altivec_tests { } =20 # Run a test on the power target to see if it supports ISA 3.1 instructions -gdb_caching_proc skip_power_isa_3_1_tests { +gdb_caching_proc allow_power_isa_3_1_tests { global srcdir subdir gdb_prompt inferior_exited_re =20 - set me "skip_power_isa_3_1_tests" + set me "allow_power_isa_3_1_tests" =20 # Compile a test program containing ISA 3.1 instructions. set src { @@ -3540,7 +3540,7 @@ gdb_caching_proc skip_power_isa_3_1_tests { } =20 if {![gdb_simple_compile $me $src executable ]} { - return 1 + return 0 } =20 # No error message, compilation succeeded so now run it via gdb. @@ -3553,22 +3553,22 @@ gdb_caching_proc skip_power_isa_3_1_tests { gdb_expect { -re ".*Illegal instruction.*${gdb_prompt} $" { verbose -log "\n$me Power ISA 3.1 hardware not detected" - set skip_power_isa_3_1_tests 1 + set allow_power_isa_3_1_tests 0 } -re ".*$inferior_exited_re normally.*${gdb_prompt} $" { verbose -log "\n$me: Power ISA 3.1 hardware detected" - set skip_power_isa_3_1_tests 0 + set allow_power_isa_3_1_tests 1 } default { - warning "\n$me: default case taken" - set skip_power_isa_3_1_tests 1 + warning "\n$me: default case taken" + set allow_power_isa_3_1_tests 0 } } gdb_exit remote_file build delete $obj =20 - verbose "$me: returning $skip_power_isa_3_1_tests" 2 - return $skip_power_isa_3_1_tests + verbose "$me: returning $allow_power_isa_3_1_tests" 2 + return $allow_power_isa_3_1_tests } =20 # Run a test on the target to see if it supports vmx hardware. Return 0 i= f so,