public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Move target check into allow_altivec_tests
@ 2023-01-25 16:21 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2023-01-25 16:21 UTC (permalink / raw)
To: gdb-cvs
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d8f5b7d1d1e8e1f0352848b7066dd133edd50773
commit d8f5b7d1d1e8e1f0352848b7066dd133edd50773
Author: Tom Tromey <tom@tromey.com>
Date: Tue Jan 24 12:50:20 2023 -0700
Move target check into allow_altivec_tests
Pedro pointed out that only PPC can possibly have altivec, so we can
move the target check into allow_altivec_tests.
Diff:
---
gdb/testsuite/gdb.arch/altivec-abi.exp | 1 -
gdb/testsuite/gdb.arch/altivec-regs.exp | 1 -
gdb/testsuite/gdb.arch/powerpc-vector-regs.exp | 2 +-
gdb/testsuite/lib/gdb.exp | 5 +++++
4 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/gdb.arch/altivec-abi.exp b/gdb/testsuite/gdb.arch/altivec-abi.exp
index 2cc75d4d617..b04858950e8 100644
--- a/gdb/testsuite/gdb.arch/altivec-abi.exp
+++ b/gdb/testsuite/gdb.arch/altivec-abi.exp
@@ -22,7 +22,6 @@
#
require allow_altivec_tests
-require {istarget "powerpc*"}
standard_testfile
diff --git a/gdb/testsuite/gdb.arch/altivec-regs.exp b/gdb/testsuite/gdb.arch/altivec-regs.exp
index 315ce1acfb2..6cc32aeff22 100644
--- a/gdb/testsuite/gdb.arch/altivec-regs.exp
+++ b/gdb/testsuite/gdb.arch/altivec-regs.exp
@@ -22,7 +22,6 @@
#
require allow_altivec_tests
-require {istarget "powerpc*"}
standard_testfile
diff --git a/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp b/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp
index 2447d740624..2958af019cb 100644
--- a/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp
+++ b/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp
@@ -20,7 +20,7 @@
# 0 to 31 in each of the 16 bytes of each corresponding register, and
# we then check if gdb sees these same values.
-require allow_altivec_tests {[istarget "powerpc*"}
+require allow_altivec_tests
standard_testfile
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index d30340e1df1..e2af5a252b7 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3471,6 +3471,11 @@ gdb_caching_proc allow_altivec_tests {
return 0
}
+ if {![istarget powerpc*]} {
+ verbose "$me: PPC target required, returning 0" 2
+ return 0
+ }
+
# Make sure we have a compiler that understands altivec.
if [test_compiler_info gcc*] {
set compile_flags "additional_flags=-maltivec"
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-25 16:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-25 16:21 [binutils-gdb] Move target check into allow_altivec_tests Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).