From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2041) id DC4CD3858D28; Thu, 26 Jan 2023 19:57:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC4CD3858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674763058; bh=1ybDSeqNvqA0svwLLvQU+/SNaHEHSkQc9DdafAQSt6I=; h=From:To:Subject:Date:From; b=CYaO9Fr2ot19AF+pv3TIM6JKPV22Q3Ep1Jyccj66GfQE/RDlgiHqRXKfPkvi858Vf U5rtH3JQLe5Ye/2f1UfYjMv15kzKHYoq6MNQPRYqxs/wJWMKmIweZm9ryO3nzXm5Id c5yRQPskG1SRz+nsSp+XWta54TClintf7Y4UGS9s= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Vladimir Mezentsev To: bfd-cvs@sourceware.org, gdb-cvs@sourceware.org Subject: [binutils-gdb/binutils-2_40-branch] gprofng: PR30043 libgprofng.so.* are installed to a wrong location X-Act-Checkin: binutils-gdb X-Git-Author: Vladimir Mezentsev X-Git-Refname: refs/heads/binutils-2_40-branch X-Git-Oldrev: abb1a617c7e36e045687baed3ff08199acf6999e X-Git-Newrev: edd36b26f3506eeb259534ba2493e15c728cd280 Message-Id: <20230126195738.DC4CD3858D28@sourceware.org> Date: Thu, 26 Jan 2023 19:57:38 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dedd36b26f350= 6eeb259534ba2493e15c728cd280 commit edd36b26f3506eeb259534ba2493e15c728cd280 Author: Vladimir Mezentsev Date: Wed Jan 25 19:21:38 2023 -0800 gprofng: PR30043 libgprofng.so.* are installed to a wrong location =20 gprofng/ChangeLog 2023-01-25 Vladimir Mezentsev =20 PR gprofng/30043 PR gprofng/28972 * src/Makefile.am: Use lib_LTLIBRARIES instead of pkglib_LTLIBR= ARIES. * src/Makefile.in: Rebuild. Diff: --- gprofng/src/Makefile.am | 7 +---- gprofng/src/Makefile.in | 76 +++++++++++++++++++++++----------------------= ---- 2 files changed, 37 insertions(+), 46 deletions(-) diff --git a/gprofng/src/Makefile.am b/gprofng/src/Makefile.am index 78228002292..ab90bb08c5f 100644 --- a/gprofng/src/Makefile.am +++ b/gprofng/src/Makefile.am @@ -124,7 +124,7 @@ BUILT_SOURCES =3D QLParser.tab.hh EXTRA_DIST =3D QLParser.yy $(man_MANS) =20 =20 -pkglib_LTLIBRARIES =3D $(LIBGPROFNG) +lib_LTLIBRARIES =3D $(LIBGPROFNG) libgprofng_la_SOURCES =3D $(CCSOURCES) $(CSOURCES) libgprofng_la_LDFLAGS =3D -version-info 0:0:0 =20 @@ -215,9 +215,4 @@ endif # so ensure that the necessary libraries are built at dist time. dist-hook: $(LIBGPROFNG) =20 -.PHONY: install-data-local - -install-data-local: install-pkglibLTLIBRARIES - rm -f $(DESTDIR)/$(pkglibdir)/*.la $(DESTDIR)/$(pkglibdir)/*.a - $(srcdir)/DbeSession.cc: QLParser.tab.hh diff --git a/gprofng/src/Makefile.in b/gprofng/src/Makefile.in index d05fb04390d..605fa4f6fd4 100644 --- a/gprofng/src/Makefile.in +++ b/gprofng/src/Makefile.in @@ -155,9 +155,9 @@ am__uninstall_files_from_dir =3D { \ || { echo " ( cd '$$dir' && rm -f" $$files ")"; \ $(am__cd) "$$dir" && rm -f $$files; }; \ } -am__installdirs =3D "$(DESTDIR)$(pkglibdir)" "$(DESTDIR)$(bindir)" \ +am__installdirs =3D "$(DESTDIR)$(libdir)" "$(DESTDIR)$(bindir)" \ "$(DESTDIR)$(man1dir)" "$(DESTDIR)$(dbedir)" -LTLIBRARIES =3D $(pkglib_LTLIBRARIES) +LTLIBRARIES =3D $(lib_LTLIBRARIES) am__DEPENDENCIES_1 =3D libgprofng_la_DEPENDENCIES =3D $(top_builddir)/../opcodes/libopcodes.la \ $(top_builddir)/../bfd/libbfd.la $(am__DEPENDENCIES_1) @@ -548,7 +548,7 @@ AM_CFLAGS =3D $(GPROFNG_CFLAGS) $(PTHREAD_CFLAGS) \ AM_CXXFLAGS =3D $(AM_CFLAGS) BUILT_SOURCES =3D QLParser.tab.hh EXTRA_DIST =3D QLParser.yy $(man_MANS) -pkglib_LTLIBRARIES =3D $(LIBGPROFNG) +lib_LTLIBRARIES =3D $(LIBGPROFNG) libgprofng_la_SOURCES =3D $(CCSOURCES) $(CSOURCES) libgprofng_la_LDFLAGS =3D -version-info 0:0:0 =20 @@ -636,33 +636,33 @@ $(ACLOCAL_M4): @MAINTAINER_MODE_TRUE@ $(am__aclocal_m= 4_deps) cd $(top_builddir) && $(MAKE) $(AM_MAKEFLAGS) am--refresh $(am__aclocal_m4_deps): =20 -install-pkglibLTLIBRARIES: $(pkglib_LTLIBRARIES) +install-libLTLIBRARIES: $(lib_LTLIBRARIES) @$(NORMAL_INSTALL) - @list=3D'$(pkglib_LTLIBRARIES)'; test -n "$(pkglibdir)" || list=3D; \ + @list=3D'$(lib_LTLIBRARIES)'; test -n "$(libdir)" || list=3D; \ list2=3D; for p in $$list; do \ if test -f $$p; then \ list2=3D"$$list2 $$p"; \ else :; fi; \ done; \ test -z "$$list2" || { \ - echo " $(MKDIR_P) '$(DESTDIR)$(pkglibdir)'"; \ - $(MKDIR_P) "$(DESTDIR)$(pkglibdir)" || exit 1; \ - echo " $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=3Dinstall $= (INSTALL) $(INSTALL_STRIP_FLAG) $$list2 '$(DESTDIR)$(pkglibdir)'"; \ - $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=3Dinstall $(INSTAL= L) $(INSTALL_STRIP_FLAG) $$list2 "$(DESTDIR)$(pkglibdir)"; \ + echo " $(MKDIR_P) '$(DESTDIR)$(libdir)'"; \ + $(MKDIR_P) "$(DESTDIR)$(libdir)" || exit 1; \ + echo " $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=3Dinstall $= (INSTALL) $(INSTALL_STRIP_FLAG) $$list2 '$(DESTDIR)$(libdir)'"; \ + $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=3Dinstall $(INSTAL= L) $(INSTALL_STRIP_FLAG) $$list2 "$(DESTDIR)$(libdir)"; \ } =20 -uninstall-pkglibLTLIBRARIES: +uninstall-libLTLIBRARIES: @$(NORMAL_UNINSTALL) - @list=3D'$(pkglib_LTLIBRARIES)'; test -n "$(pkglibdir)" || list=3D; \ + @list=3D'$(lib_LTLIBRARIES)'; test -n "$(libdir)" || list=3D; \ for p in $$list; do \ $(am__strip_dir) \ - echo " $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=3Duninstall= rm -f '$(DESTDIR)$(pkglibdir)/$$f'"; \ - $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=3Duninstall rm -f = "$(DESTDIR)$(pkglibdir)/$$f"; \ + echo " $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=3Duninstall= rm -f '$(DESTDIR)$(libdir)/$$f'"; \ + $(LIBTOOL) $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=3Duninstall rm -f = "$(DESTDIR)$(libdir)/$$f"; \ done =20 -clean-pkglibLTLIBRARIES: - -test -z "$(pkglib_LTLIBRARIES)" || rm -f $(pkglib_LTLIBRARIES) - @list=3D'$(pkglib_LTLIBRARIES)'; \ +clean-libLTLIBRARIES: + -test -z "$(lib_LTLIBRARIES)" || rm -f $(lib_LTLIBRARIES) + @list=3D'$(lib_LTLIBRARIES)'; \ locs=3D`for p in $$list; do echo $$p; done | \ sed 's|^[^/]*$$|.|; s|/[^/]*$$||; s|$$|/so_locations|' | \ sort -u`; \ @@ -672,7 +672,7 @@ clean-pkglibLTLIBRARIES: } =20 libgprofng.la: $(libgprofng_la_OBJECTS) $(libgprofng_la_DEPENDENCIES) $(EX= TRA_libgprofng_la_DEPENDENCIES)=20 - $(AM_V_CXXLD)$(libgprofng_la_LINK) -rpath $(pkglibdir) $(libgprofng_la_OB= JECTS) $(libgprofng_la_LIBADD) $(LIBS) + $(AM_V_CXXLD)$(libgprofng_la_LINK) -rpath $(libdir) $(libgprofng_la_OBJEC= TS) $(libgprofng_la_LIBADD) $(LIBS) install-binPROGRAMS: $(bin_PROGRAMS) @$(NORMAL_INSTALL) @list=3D'$(bin_PROGRAMS)'; test -n "$(bindir)" || list=3D; \ @@ -1039,8 +1039,10 @@ check-am: all-am check: $(BUILT_SOURCES) $(MAKE) $(AM_MAKEFLAGS) check-am all-am: Makefile $(LTLIBRARIES) $(PROGRAMS) $(MANS) $(DATA) +install-binPROGRAMS: install-libLTLIBRARIES + installdirs: - for dir in "$(DESTDIR)$(pkglibdir)" "$(DESTDIR)$(bindir)" "$(DESTDIR)$(ma= n1dir)" "$(DESTDIR)$(dbedir)"; do \ + for dir in "$(DESTDIR)$(libdir)" "$(DESTDIR)$(bindir)" "$(DESTDIR)$(man1d= ir)" "$(DESTDIR)$(dbedir)"; do \ test -z "$$dir" || $(MKDIR_P) "$$dir"; \ done install: $(BUILT_SOURCES) @@ -1078,8 +1080,8 @@ maintainer-clean-generic: -test -z "$(MAINTAINERCLEANFILES)" || rm -f $(MAINTAINERCLEANFILES) clean: clean-am =20 -clean-am: clean-binPROGRAMS clean-generic clean-libtool \ - clean-pkglibLTLIBRARIES mostlyclean-am +clean-am: clean-binPROGRAMS clean-generic clean-libLTLIBRARIES \ + clean-libtool mostlyclean-am =20 distclean: distclean-am -rm -rf ./$(DEPDIR) @@ -1099,13 +1101,13 @@ info: info-am =20 info-am: =20 -install-data-am: install-data-local install-dbeDATA install-man +install-data-am: install-dbeDATA install-man =20 install-dvi: install-dvi-am =20 install-dvi-am: =20 -install-exec-am: install-binPROGRAMS install-pkglibLTLIBRARIES +install-exec-am: install-binPROGRAMS install-libLTLIBRARIES =20 install-html: install-html-am =20 @@ -1145,30 +1147,29 @@ ps: ps-am =20 ps-am: =20 -uninstall-am: uninstall-binPROGRAMS uninstall-dbeDATA uninstall-man \ - uninstall-pkglibLTLIBRARIES +uninstall-am: uninstall-binPROGRAMS uninstall-dbeDATA \ + uninstall-libLTLIBRARIES uninstall-man =20 uninstall-man: uninstall-man1 =20 .MAKE: all check install install-am install-strip =20 .PHONY: CTAGS GTAGS TAGS all all-am check check-am clean \ - clean-binPROGRAMS clean-generic clean-libtool \ - clean-pkglibLTLIBRARIES cscopelist-am ctags ctags-am dist-hook \ - distclean distclean-compile distclean-generic \ - distclean-libtool distclean-tags distdir dvi dvi-am html \ - html-am info info-am install install-am install-binPROGRAMS \ - install-data install-data-am install-data-local \ - install-dbeDATA install-dvi install-dvi-am install-exec \ - install-exec-am install-html install-html-am install-info \ - install-info-am install-man install-man1 install-pdf \ - install-pdf-am install-pkglibLTLIBRARIES install-ps \ + clean-binPROGRAMS clean-generic clean-libLTLIBRARIES \ + clean-libtool cscopelist-am ctags ctags-am dist-hook distclean \ + distclean-compile distclean-generic distclean-libtool \ + distclean-tags distdir dvi dvi-am html html-am info info-am \ + install install-am install-binPROGRAMS install-data \ + install-data-am install-dbeDATA install-dvi install-dvi-am \ + install-exec install-exec-am install-html install-html-am \ + install-info install-info-am install-libLTLIBRARIES \ + install-man install-man1 install-pdf install-pdf-am install-ps \ install-ps-am install-strip installcheck installcheck-am \ installdirs maintainer-clean maintainer-clean-generic \ mostlyclean mostlyclean-compile mostlyclean-generic \ mostlyclean-libtool pdf pdf-am ps ps-am tags tags-am uninstall \ uninstall-am uninstall-binPROGRAMS uninstall-dbeDATA \ - uninstall-man uninstall-man1 uninstall-pkglibLTLIBRARIES + uninstall-libLTLIBRARIES uninstall-man uninstall-man1 =20 .PRECIOUS: Makefile =20 @@ -1198,11 +1199,6 @@ QLParser.tab.cc QLParser.tab.hh: QLParser.yy # so ensure that the necessary libraries are built at dist time. dist-hook: $(LIBGPROFNG) =20 -.PHONY: install-data-local - -install-data-local: install-pkglibLTLIBRARIES - rm -f $(DESTDIR)/$(pkglibdir)/*.la $(DESTDIR)/$(pkglibdir)/*.a - $(srcdir)/DbeSession.cc: QLParser.tab.hh =20 # Tell versions [3.59,3.63) of GNU make to not export all variables.