public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb/testsuite/dap: write requests to gdb.log
Date: Thu, 26 Jan 2023 20:22:47 +0000 (GMT)	[thread overview]
Message-ID: <20230126202248.03449385843D@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4cdda229da53bde30b2a22155ee7ceb025cebc49

commit 4cdda229da53bde30b2a22155ee7ceb025cebc49
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Fri Jan 6 10:37:10 2023 -0500

    gdb/testsuite/dap: write requests to gdb.log
    
    This helps following what happens when reading gdb.log.  The downside is
    that it becomes harder to tell what text is from GDB and what text is
    going to GDB, but I think that seeing responses without seeing requests
    is even more confusing.  At least, the lines are prefix with >>>, so
    when you see this, you know that until the end of the line, it's
    something that was sent to GDB, and not GDB output.
    
    Change-Id: I1ba1acd8b16f4e64686c5ad268cc41082951c874

Diff:
---
 gdb/testsuite/lib/dap-support.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/lib/dap-support.exp b/gdb/testsuite/lib/dap-support.exp
index a91b5533643..94a0d27c8a8 100644
--- a/gdb/testsuite/lib/dap-support.exp
+++ b/gdb/testsuite/lib/dap-support.exp
@@ -102,7 +102,7 @@ proc _dap_send_ton {obj} {
     set json [namespace eval ton::2json $obj]
     # FIXME this is wrong for non-ASCII characters.
     set len [string length $json]
-    verbose ">>> $json"
+    verbose -log ">>> $json"
     send_gdb "Content-Length: $len\r\n\r\n$json"
 }

                 reply	other threads:[~2023-01-26 20:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230126202248.03449385843D@sourceware.org \
    --to=simark@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).