public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/testsuite/dap: remove catch from dap_read_event
@ 2023-01-26 20:22 Simon Marchi
  0 siblings, 0 replies; only message in thread
From: Simon Marchi @ 2023-01-26 20:22 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4dde3b33e461e40e069c2026861b3e5ba2476604

commit 4dde3b33e461e40e069c2026861b3e5ba2476604
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Fri Jan 6 11:39:29 2023 -0500

    gdb/testsuite/dap: remove catch from dap_read_event
    
    This catch didn't cause me any trouble, but for the same reason as the
    preceding patch, I think it's a bit better to just let any exception
    propagate, to make for easier debugging.
    
    Change-Id: I1779e62c788b77fef2d50434edf4c3d2ec5e1c4c

Diff:
---
 gdb/testsuite/lib/dap-support.exp | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gdb/testsuite/lib/dap-support.exp b/gdb/testsuite/lib/dap-support.exp
index bc99f0182a7..8c85f90c352 100644
--- a/gdb/testsuite/lib/dap-support.exp
+++ b/gdb/testsuite/lib/dap-support.exp
@@ -310,11 +310,7 @@ proc dap_read_event {name type args} {
 	set name $type
     }
 
-    if {[catch {_dap_read_event $type} result]} {
-	fail $name
-	return ""
-    }
-
+    set result [_dap_read_event $type]
     eval dap_match_values [list $name $result] $args
 
     return $result

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2023-01-26 20:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-26 20:22 [binutils-gdb] gdb/testsuite/dap: remove catch from dap_read_event Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).