From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1879) id 26163385842C; Thu, 26 Jan 2023 20:22:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26163385842C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674764578; bh=bRSTkf6Bh/PBxftANmX6p+EPQKg0zaGeZZpDHM25FEY=; h=From:To:Subject:Date:From; b=Lqh3b/kEIKyx439eNq2izG6/qDBD758H1czpVu8UjEK26+CTOy6t07t9T2j2QmRX2 A2cedEpK3O8y/lBvxRkOn09H43sKot0P9CCZUyX8hci+3yE13mNFSE4jieNuSjKOCz Cqdj2u+9YrOuRoaeN42U/Unp4WhNZZC3vLLQ11Wg= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Simon Marchi To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/testsuite/dap: remove catch from dap_read_event X-Act-Checkin: binutils-gdb X-Git-Author: Simon Marchi X-Git-Refname: refs/heads/master X-Git-Oldrev: 2e9a03fd2e20f9d0d3ddb340ba248bfb1d5ed521 X-Git-Newrev: 4dde3b33e461e40e069c2026861b3e5ba2476604 Message-Id: <20230126202258.26163385842C@sourceware.org> Date: Thu, 26 Jan 2023 20:22:58 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D4dde3b33e461= e40e069c2026861b3e5ba2476604 commit 4dde3b33e461e40e069c2026861b3e5ba2476604 Author: Simon Marchi Date: Fri Jan 6 11:39:29 2023 -0500 gdb/testsuite/dap: remove catch from dap_read_event =20 This catch didn't cause me any trouble, but for the same reason as the preceding patch, I think it's a bit better to just let any exception propagate, to make for easier debugging. =20 Change-Id: I1779e62c788b77fef2d50434edf4c3d2ec5e1c4c Diff: --- gdb/testsuite/lib/dap-support.exp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/gdb/testsuite/lib/dap-support.exp b/gdb/testsuite/lib/dap-supp= ort.exp index bc99f0182a7..8c85f90c352 100644 --- a/gdb/testsuite/lib/dap-support.exp +++ b/gdb/testsuite/lib/dap-support.exp @@ -310,11 +310,7 @@ proc dap_read_event {name type args} { set name $type } =20 - if {[catch {_dap_read_event $type} result]} { - fail $name - return "" - } - + set result [_dap_read_event $type] eval dap_match_values [list $name $result] $args =20 return $result