[binutils-gdb] gdb/testsuite: initialize "correct" variable in gdb.cp/cpexprs.exp.tcl

[binutils-gdb] gdb/testsuite: initialize "correct" variable in gdb.cp/cpexprs.exp.tcl

[Simon Marchi]

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4707199bd760f26cbc32614dd9f7c6ed7d2efdda

commit 4707199bd760f26cbc32614dd9f7c6ed7d2efdda
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Thu Jan 26 15:46:51 2023 -0500

    gdb/testsuite: initialize "correct" variable in gdb.cp/cpexprs.exp.tcl
    
    Due to a GDB bug (visible when building with -D_GLIBCXX_DEBUG), GDB
    crashes somewhere in the middle of gdb.cp/cpexprs.exp, and thus fails to
    read the string, at gdb.cp/cpexprs.exp.tcl:725.  The "correct" variable
    doesn't get set, and I then see this TCL error:
    
      ERROR: can't read "correct": no such variable
    
    Avoid the TCL error by initializing the "correct" variable to a dummy
    value.
    
    Change-Id: I828968d9b2d105ef47f8da2ef598aa16a518c059

Diff:
---
 gdb/testsuite/gdb.cp/cpexprs.exp.tcl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/testsuite/gdb.cp/cpexprs.exp.tcl b/gdb/testsuite/gdb.cp/cpexprs.exp.tcl
index 3df149bf6a3..462cf16dcd1 100644
--- a/gdb/testsuite/gdb.cp/cpexprs.exp.tcl
+++ b/gdb/testsuite/gdb.cp/cpexprs.exp.tcl
@@ -722,6 +722,8 @@ foreach name [get_functions list] {
 # Test c/v gets recognized even without quoting.
 foreach cv {{} { const} { volatile} { const volatile}} {
   set test "p 'CV::m(int)$cv'"
+  set correct dummy_value
+
   gdb_test_multiple $test $test {
       -re "( = {.*} 0x\[0-9a-f\]+ <CV::m.*>)\r\n$gdb_prompt $" {
 	  # = {void (CV * const, CV::t)} 0x400944 <CV::m(int)>