From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 9AFC43858D20; Fri, 27 Jan 2023 01:29:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9AFC43858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674782950; bh=6a3K3sq7tntEjvwz8qus50Yj9N5URqZvIcT/FcFXadQ=; h=From:To:Subject:Date:From; b=qBbPFz4Di5z2b+X/ugyIMQ1+r8xc/TWAnAGU7ujBkXGgKsfym7vjr0QKMl2rlKm/L TrYlBLWw4iSgXUi4F6Anp7JHkMHPXBX6idAbBi4c4pjvCIJI0fMVGt6upVqvVN1i6W QAtJxgGA1naDWeVNA0VeqlIZBG311XMhG2UQGTjA= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Minor "require" fixups X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: e1a772ad89bc1103182168b46513900aa035a81e X-Git-Newrev: eacd228909680afd71ba4e36e64b147c402b6802 Message-Id: <20230127012910.9AFC43858D20@sourceware.org> Date: Fri, 27 Jan 2023 01:29:10 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Deacd22890968= 0afd71ba4e36e64b147c402b6802 commit eacd228909680afd71ba4e36e64b147c402b6802 Author: Tom Tromey Date: Wed Jan 25 09:43:03 2023 -0700 Minor "require" fixups =20 I found a couple of spots that could use "require", and one spot where hoisting the "require" closer to the top of the file made it more clear. Diff: --- gdb/testsuite/gdb.btrace/enable.exp | 5 +---- gdb/testsuite/gdb.mi/list-thread-groups-available.exp | 3 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.btrace/enable.exp b/gdb/testsuite/gdb.btrace= /enable.exp index 6a30d7d9187..bedff46ddb6 100644 --- a/gdb/testsuite/gdb.btrace/enable.exp +++ b/gdb/testsuite/gdb.btrace/enable.exp @@ -76,10 +76,7 @@ gdb_exit # skip the rerun test when using gdbserver # otherwise rerun twice, target should be automatically disabled load_lib gdbserver-support.exp -if {![allow_gdbserver_tests]} { - unsupported "target does not support gdbserver" - return 0 -} +require allow_gdbserver_tests clean_restart $testfile if ![runto_main] { return -1 diff --git a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp b/gdb/te= stsuite/gdb.mi/list-thread-groups-available.exp index 27224b5f96f..3ab2cab850c 100644 --- a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp +++ b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp @@ -22,6 +22,7 @@ standard_testfile =20 # Support for XML is needed to run this test. require allow_xml_test +require can_spawn_for_attach =20 if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executabl= e {debug}] !=3D "" } { untested "failed to compile" @@ -32,8 +33,6 @@ if [mi_gdb_start] { return } =20 -require can_spawn_for_attach - set string_re {(?:[^\\"]|\\.)*} =20 set id_re "id=3D\"$decimal\""