public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Start gdb after building executable in mi-basics.exp
@ 2023-01-27  1:29 Tom Tromey
  0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2023-01-27  1:29 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=d6acf25c03f8c507e134f7438bd4360464ce111e

commit d6acf25c03f8c507e134f7438bd4360464ce111e
Author: Tom Tromey <tom@tromey.com>
Date:   Wed Jan 25 10:00:58 2023 -0700

    Start gdb after building executable in mi-basics.exp
    
    A lot of the MI tests start gdb and only then build the executable.
    This just seemed weird to me, so I've fixed this up.  In this patch,
    no other cleanups are done, the startup is just moved to a more
    logical (to me) spot.

Diff:
---
 gdb/testsuite/gdb.mi/mi-basics.exp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gdb/testsuite/gdb.mi/mi-basics.exp b/gdb/testsuite/gdb.mi/mi-basics.exp
index 086ce74eae5..30d0da6ed02 100644
--- a/gdb/testsuite/gdb.mi/mi-basics.exp
+++ b/gdb/testsuite/gdb.mi/mi-basics.exp
@@ -28,11 +28,6 @@
 load_lib mi-support.exp
 set MIFLAGS "-i=mi"
 
-gdb_exit
-if [mi_gdb_start separate-inferior-tty] {
-    return
-}
-
 standard_testfile basics.c
 # This file was audited to ensure that the explicit references to
 # objdir in it are safe for parallel testing.  Please be sure to
@@ -49,6 +44,11 @@ if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb
 # In this file we want to test if the operations needed by the following
 # procedures work, so it makes no sense using them here.
 
+gdb_exit
+if [mi_gdb_start separate-inferior-tty] {
+    return
+}
+
 # mi_delete_breakpoints
 # mi_gdb_reinitialize_dir $srcdir/$subdir
 # mi_gdb_load ${binfile}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-27  1:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-27  1:29 [binutils-gdb] Start gdb after building executable in mi-basics.exp Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).