public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/testsuite: fix line feed scrolling in tuiterm.exp
@ 2023-01-27 16:25 Andrew Burgess
  0 siblings, 0 replies; only message in thread
From: Andrew Burgess @ 2023-01-27 16:25 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=efe1b6507b7e6ae5ee45af5b1568b910a3170750

commit efe1b6507b7e6ae5ee45af5b1568b910a3170750
Author: Andrew Burgess <aburgess@redhat.com>
Date:   Thu Dec 22 16:26:50 2022 +0000

    gdb/testsuite: fix line feed scrolling in tuiterm.exp
    
    In a following commit I managed to trigger the line feed scrolling
    case in tuiterm.exp.  This case is currently unhandled, and this
    commit fills in this missing functionality.
    
    The implementation is pretty simple, just scroll all the content up
    one line at a time until the cursor is back on the screen (a single
    line of scroll is all that should be needed).
    
    This change is untested in this commit, but is required by the next
    commit.

Diff:
---
 gdb/testsuite/lib/tuiterm.exp | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/lib/tuiterm.exp b/gdb/testsuite/lib/tuiterm.exp
index c38ccbbdbd7..8a3f7a48acc 100644
--- a/gdb/testsuite/lib/tuiterm.exp
+++ b/gdb/testsuite/lib/tuiterm.exp
@@ -99,10 +99,24 @@ namespace eval Term {
 	_log_cur "Line feed" {
 	    variable _cur_row
 	    variable _rows
+	    variable _cols
+	    variable _chars
 
 	    incr _cur_row 1
-	    if {$_cur_row >= $_rows} {
-		error "FIXME scroll"
+	    while {$_cur_row >= $_rows} {
+		# Scroll the display contents.  We scroll one line at
+		# a time here; as _cur_row was only increased by one,
+		# a single line scroll should be enough to put the
+		# cursor back on the screen.  But we wrap the
+		# scrolling inside a while loop just to be on the safe
+		# side.
+		for {set y 0} {$y < [expr $_rows - 1]} {incr y} {
+		    set next_y [expr $y + 1]
+		    for {set x 0} {$x < $_cols} {incr x} {
+			set _chars($x,$y) $_chars($x,$next_y)
+		    }
+		    incr _cur_row -1
+		}
 	    }
 	}
     }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-27 16:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-27 16:25 [binutils-gdb] gdb/testsuite: fix line feed scrolling in tuiterm.exp Andrew Burgess

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).