public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb/tui: make m_horizontal_offset private Date: Fri, 27 Jan 2023 16:25:18 +0000 (GMT) [thread overview] Message-ID: <20230127162518.902AB3857BB2@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9bea9aa7d29330783541861d7498d51fbb0002c7 commit 9bea9aa7d29330783541861d7498d51fbb0002c7 Author: Andrew Burgess <aburgess@redhat.com> Date: Wed Jan 4 17:07:47 2023 +0000 gdb/tui: make m_horizontal_offset private I noticed that tui_source_window_base::m_horizontal_offset was protected, but could be made private, so lets do that. This makes more sense in the context of a later commit where I plan to add another member variable that is similar to m_horizontal_offset. The new member variable could also be private. So I had to choose, place the new member variable next to m_horizontal_offset making it protected, but grouping similar variables together, or make m_horizontal_offset private, and then add the new variable as private too. I chose to make m_horizontal_offset private, which is this commit. There should be no user visible changes after this commit. Diff: --- gdb/tui/tui-winsource.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h index 7d6d64d35c4..bf0ca96c09b 100644 --- a/gdb/tui/tui-winsource.h +++ b/gdb/tui/tui-winsource.h @@ -124,8 +124,7 @@ protected: /* Redraw the complete line of a source or disassembly window. */ void show_source_line (int lineno); - /* Used for horizontal scroll. */ - int m_horizontal_offset = 0; + /* Where to start generating content from. */ struct tui_line_or_address m_start_line_or_addr; /* Architecture associated with code at this location. */ @@ -179,6 +178,9 @@ public: private: + /* Used for horizontal scroll. */ + int m_horizontal_offset = 0; + void show_source_content (); /* Called when the user "set style enabled" setting is changed. */
reply other threads:[~2023-01-27 16:25 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230127162518.902AB3857BB2@sourceware.org \ --to=aburgess@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).