From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2161) id B6F973858D1E; Mon, 30 Jan 2023 21:14:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B6F973858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675113298; bh=oLe0B9mxQN2Kq0qSkYw6YgQvi38+NVc38mqmqE1gYPM=; h=From:To:Subject:Date:From; b=HlkA4hX6XFzMSAepAIGtH94CDCCMXTkTgnmbMOm33S9u8YbvBBT1+yCqHZc3M5gKN KXXqxVOU/YO4EPdPudHejYF7kbvuTN12sg67hRW2wtgmmzjXpzmMAtWKXBRuytSzoF 02/Nlm0mwD+hCebPP2LlFY+TmsD5LIkAPdoFIHKM= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Mark Wielaard To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc X-Act-Checkin: binutils-gdb X-Git-Author: Mark Wielaard X-Git-Refname: refs/heads/master X-Git-Oldrev: 7d82b08e9e0a7a22943b843972cd1b8ae1328884 X-Git-Newrev: 214d883794db819617ee60806e3dbeb3d5dab666 Message-Id: <20230130211458.B6F973858D1E@sourceware.org> Date: Mon, 30 Jan 2023 21:14:58 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D214d883794db= 819617ee60806e3dbeb3d5dab666 commit 214d883794db819617ee60806e3dbeb3d5dab666 Author: Mark Wielaard Date: Sun Jan 15 01:06:16 2023 +0100 gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc =20 For some reason g++ 12.2.1 on sparc produces spurious warnings for stringop-overread and restrict in fbsd-tdep.c for a memcpy call. Use std::copy to avoid the warnings: =20 In function =E2=80=98void* memcpy(void*, const void*, size_t)=E2=80=99, inlined from =E2=80=98gdb::optional > > > = fbsd_make_note_desc(target_object, uint32_t)=E2=80=99 at ../../binutils-gdb= /gdb/fbsd-tdep.c:666:10: /usr/include/bits/string_fortified.h:29:33: error: =E2=80=98void* __bui= ltin_memcpy(void*, const void*, long unsigned int)=E2=80=99 specified bound= 18446744073709551612 exceeds maximum object size 9223372036854775807 [-Wer= ror=3Dstringop-overflow=3D] =20 In function =E2=80=98void* memcpy(void*, const void*, size_t)=E2=80=99, inlined from =E2=80=98gdb::optional > > > = fbsd_make_note_desc(target_object, uint32_t)=E2=80=99 at ../../binutils-gdb= /gdb/fbsd-tdep.c:673:10: /usr/include/bits/string_fortified.h:29:33: error: =E2=80=98void* __bui= ltin_memcpy(void*, const void*, long unsigned int)=E2=80=99 accessing 18446= 744073709551612 bytes at offsets 0 and 0 overlaps 9223372036854775801 bytes= at offset -9223372036854775805 [-Werror=3Drestrict] =20 gdb/ChangeLog: =20 * fbsd-tdep.c (fbsd_make_note_desc): Use std::copy instead of memcpy. Diff: --- gdb/fbsd-tdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/fbsd-tdep.c b/gdb/fbsd-tdep.c index 203390d9880..3a7cb9b14ea 100644 --- a/gdb/fbsd-tdep.c +++ b/gdb/fbsd-tdep.c @@ -663,7 +663,7 @@ fbsd_make_note_desc (enum target_object object, uint32_= t structsize) =20 gdb::byte_vector desc (sizeof (structsize) + buf->size ()); memcpy (desc.data (), &structsize, sizeof (structsize)); - memcpy (desc.data () + sizeof (structsize), buf->data (), buf->size ()); + std::copy (buf->begin (), buf->end (), desc.data () + sizeof (structsize= )); return desc; }