public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: make gdb_printing_disassembler::stream public Date: Thu, 2 Feb 2023 15:09:02 +0000 (GMT) [thread overview] Message-ID: <20230202150902.9542D3858426@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8b588f42120f1a39d32116c2bf3e53981d906a02 commit 8b588f42120f1a39d32116c2bf3e53981d906a02 Author: Simon Marchi <simon.marchi@efficios.com> Date: Wed Nov 30 09:46:09 2022 -0500 gdb: make gdb_printing_disassembler::stream public In the ROCm port, we need to access the underlying stream of a gdb_printing_disassembler, so make it public. The reason we need to access it is to know whether it supports style escape code. We then pass that information to a temporary string_file we use while symbolizing addresses. Change-Id: Ib95755a4a45b8f6478787993e9f904df60dd8dc1 Approved-By: Andrew Burgess <aburgess@redhat.com> Diff: --- gdb/disasm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/disasm.h b/gdb/disasm.h index 86d8eed61e9..02d94081077 100644 --- a/gdb/disasm.h +++ b/gdb/disasm.h @@ -123,12 +123,12 @@ struct gdb_printing_disassembler : public gdb_disassemble_info { DISABLE_COPY_AND_ASSIGN (gdb_printing_disassembler); -protected: - /* The stream that disassembler output is being written too. */ struct ui_file *stream () { return m_stream; } +protected: + /* Constructor. All the arguments are just passed to the parent class. We also add the two print functions to the arguments passed to the parent. See gdb_disassemble_info for a description of how the
reply other threads:[~2023-02-02 15:09 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230202150902.9542D3858426@sourceware.org \ --to=simark@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).