public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb: use assignment to initialize variable in tdesc_parse_xml
Date: Fri,  3 Feb 2023 13:24:54 +0000 (GMT)	[thread overview]
Message-ID: <20230203132454.398D93858D20@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e3ee979c1f24984eb93b32822338aa425afbc2af

commit e3ee979c1f24984eb93b32822338aa425afbc2af
Author: Simon Marchi <simon.marchi@polymtl.ca>
Date:   Fri Feb 3 08:23:32 2023 -0500

    gdb: use assignment to initialize variable in tdesc_parse_xml
    
    Since allocate_target_description returns a target_desc_up, use
    assignment to initialize the description variable.
    
    Change-Id: Iab3311642c09b95648984f305936f4a4cde09440

Diff:
---
 gdb/xml-tdesc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/xml-tdesc.c b/gdb/xml-tdesc.c
index ba7154c5d56..a8b0b0566c7 100644
--- a/gdb/xml-tdesc.c
+++ b/gdb/xml-tdesc.c
@@ -638,7 +638,7 @@ tdesc_parse_xml (const char *document, xml_fetch_another fetcher)
     return it->second.get ();
 
   memset (&data, 0, sizeof (struct tdesc_parsing_data));
-  target_desc_up description (allocate_target_description ());
+  target_desc_up description = allocate_target_description ();
   data.tdesc = description.get ();
 
   if (gdb_xml_parse_quick (_("target description"), "gdb-target.dtd",

                 reply	other threads:[~2023-02-03 13:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230203132454.398D93858D20@sourceware.org \
    --to=simark@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).