From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2205) id A48D33858D33; Tue, 7 Feb 2023 10:41:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A48D33858D33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675766508; bh=FTVZxqbes7sfUF+UJO2XpHCOhH5H+tidFlPthDfpKiw=; h=From:To:Subject:Date:From; b=YI/nXgKJxam5GTxk+qJ93hR56u6KA9Y0EZBVgE1Db+RE/tJ3iWTa89AeaVfzLQuVm v/ncbN+aMvv4wcWNTi0llHdfVKdD/d+O9kV1uJSNJ59M0artxCftSyx2dDNJfznbeS gld0NOAaKIaOTn4xMsDMwBIWdZJViVUK3LacDYUc= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom de Vries To: gdb-cvs@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Improve untested message in gdb.ada/finish-var-size.exp X-Act-Checkin: binutils-gdb X-Git-Author: Tom de Vries X-Git-Refname: refs/heads/master X-Git-Oldrev: e7a881b9d49f16bd901dba53006c48a8bfd115df X-Git-Newrev: ca2f51c6960d65c2d3adbc4095aa8a9d02759376 Message-Id: <20230207104148.A48D33858D33@sourceware.org> Date: Tue, 7 Feb 2023 10:41:48 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dca2f51c6960d= 65c2d3adbc4095aa8a9d02759376 commit ca2f51c6960d65c2d3adbc4095aa8a9d02759376 Author: Tom de Vries Date: Tue Feb 7 11:41:44 2023 +0100 [gdb/testsuite] Improve untested message in gdb.ada/finish-var-size.exp =20 I came across: ... UNTESTED: gdb.ada/finish-var-size.exp: GCC too told for this test ... The message only tells us that the compiler version too old, not what c= ompiler version is required. =20 Fix this by rewriting using required: ... UNSUPPORTED: gdb.ada/finish-var-size.exp: require failed: \ expr [gcc_major_version] >=3D 12 ... =20 Tested on x86_64-linux. Diff: --- gdb/testsuite/gdb.ada/finish-var-size.exp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gdb/testsuite/gdb.ada/finish-var-size.exp b/gdb/testsuite/gdb.= ada/finish-var-size.exp index c1cf6406433..5865be249a0 100644 --- a/gdb/testsuite/gdb.ada/finish-var-size.exp +++ b/gdb/testsuite/gdb.ada/finish-var-size.exp @@ -18,10 +18,7 @@ load_lib "ada.exp" require allow_ada_tests =20 # GCC 12 has the needed fix. -if {![test_compiler_info {gcc-1[2-9]-*}]} { - untested "GCC too told for this test" - return -1 -} +require {expr [gcc_major_version] >=3D 12} =20 standard_ada_testfile p