From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id 81DC53858C62; Thu, 9 Feb 2023 19:22:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81DC53858C62 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1675970551; bh=023ZCVi/p+6jZ/GjMCZbPamBJwpjz/6yDg5uS4KFL+c=; h=From:To:Subject:Date:From; b=TnWy9QSV9xWi8tzOVHRxib1yWXgig18DnvnMoHqIfZJLMeeafRNoEEfE2qqfkkR1R vZ4HLLL2ELf0P6G1Dp+JGAzbc6b/y2gghVHVfKa7X4pyU9juft52NH/hGNJMyqBcfF 9y7bls/GyvlnAe6lCu/NLVPOu0JYCSgaUI3rksg8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Trivially simplify rust_language::print_enum X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: b695fdd9b2494a64db1fb8e584753a1a5afec494 X-Git-Newrev: 8ac460b742bc7f49acbcd78f8822386f56814055 Message-Id: <20230209192231.81DC53858C62@sourceware.org> Date: Thu, 9 Feb 2023 19:22:31 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D8ac460b742bc= 7f49acbcd78f8822386f56814055 commit 8ac460b742bc7f49acbcd78f8822386f56814055 Author: Tom Tromey Date: Thu Feb 9 12:13:08 2023 -0700 Trivially simplify rust_language::print_enum =20 rust_language::print_enum computes: =20 int nfields =3D variant_type->num_fields (); =20 ... but then does not reuse this in one spot. This patch corrects the oversight. Diff: --- gdb/rust-lang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/rust-lang.c b/gdb/rust-lang.c index 6653f7a9c64..f2017f95211 100644 --- a/gdb/rust-lang.c +++ b/gdb/rust-lang.c @@ -495,7 +495,7 @@ rust_language::print_enum (struct value *val, struct ui= _file *stream, } =20 bool first_field =3D true; - for (int j =3D 0; j < variant_type->num_fields (); j++) + for (int j =3D 0; j < nfields; j++) { if (!first_field) gdb_puts (", ", stream);