public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Ensure all DAP requests are keyword-only Date: Fri, 10 Feb 2023 21:09:20 +0000 (GMT) [thread overview] Message-ID: <20230210210920.A8E1E3858414@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5036bde964bc1a18282dde536a95aecd0d2c08fb commit 5036bde964bc1a18282dde536a95aecd0d2c08fb Author: Tom Tromey <tromey@adacore.com> Date: Fri Feb 10 11:59:03 2023 -0700 Ensure all DAP requests are keyword-only Python functions implementing DAP requests should not use positional parameters -- it only makes sense to call them with keyword arguments. This patch changes the few remaining cases to start with the special "*" parameter, following this rule. Diff: --- gdb/python/lib/gdb/dap/breakpoint.py | 6 +++--- gdb/python/lib/gdb/dap/evaluate.py | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/python/lib/gdb/dap/breakpoint.py b/gdb/python/lib/gdb/dap/breakpoint.py index 502beb0478e..f0e1f103d1b 100644 --- a/gdb/python/lib/gdb/dap/breakpoint.py +++ b/gdb/python/lib/gdb/dap/breakpoint.py @@ -1,4 +1,4 @@ -# Copyright 2022 Free Software Foundation, Inc. +# Copyright 2022, 2023 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -85,7 +85,7 @@ def _set_breakpoints(kind, specs): @request("setBreakpoints") -def set_breakpoint(source, *, breakpoints=[], **args): +def set_breakpoint(*, source, breakpoints=[], **args): if "path" not in source: result = [] else: @@ -108,7 +108,7 @@ def set_breakpoint(source, *, breakpoints=[], **args): @request("setFunctionBreakpoints") @capability("supportsFunctionBreakpoints") -def set_fn_breakpoint(breakpoints, **args): +def set_fn_breakpoint(*, breakpoints, **args): specs = [] for bp in breakpoints: specs.append( diff --git a/gdb/python/lib/gdb/dap/evaluate.py b/gdb/python/lib/gdb/dap/evaluate.py index c05e62d17a3..f01bf0f33c9 100644 --- a/gdb/python/lib/gdb/dap/evaluate.py +++ b/gdb/python/lib/gdb/dap/evaluate.py @@ -1,4 +1,4 @@ -# Copyright 2022 Free Software Foundation, Inc. +# Copyright 2022, 2023 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -33,7 +33,7 @@ def _evaluate(expr, frame_id): # FIXME return a structured response using pretty-printers / varobj # FIXME supportsVariableType handling @request("evaluate") -def eval_request(expression, *, frameId=None, **args): +def eval_request(*, expression, frameId=None, **args): result = send_gdb_with_response(lambda: _evaluate(expression, frameId)) return { "result": result,
reply other threads:[~2023-02-10 21:09 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230210210920.A8E1E3858414@sourceware.org \ --to=tromey@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).