From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1726) id 3BF293858D32; Sun, 12 Feb 2023 07:21:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3BF293858D32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676186480; bh=QN/Occk0DF3A29HjaLb9JQgCygjdVsAzUi+7dfmhLaQ=; h=From:To:Subject:Date:From; b=ecuOowB3hLIZeH0OcsHtDQ8ZvrMme7VebhsBiVAFxww70j+8+JaIGwV8ooradC30N gkl+utQ+yJOVFPcB+/0IStGSJHQTuursmL9u0vr3YMA+BdT5woSE8p+B/Doyl+P3YG oOImNIVKCkAoa4XeaayaTdfWGEGCSFUHMZyTPsuo= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Andrew Burgess To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: fix describe_other_breakpoints for default task being -1 X-Act-Checkin: binutils-gdb X-Git-Author: Andrew Burgess X-Git-Refname: refs/heads/master X-Git-Oldrev: f0bdf68d3fb6db1dd2b83e07062e2104cdb785c2 X-Git-Newrev: 8282ad74c302a8e0db7a588e500ae117a1df68c5 Message-Id: <20230212072120.3BF293858D32@sourceware.org> Date: Sun, 12 Feb 2023 07:21:20 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D8282ad74c302= a8e0db7a588e500ae117a1df68c5 commit 8282ad74c302a8e0db7a588e500ae117a1df68c5 Author: Andrew Burgess Date: Sun Feb 12 07:14:31 2023 +0000 gdb: fix describe_other_breakpoints for default task being -1 =20 Commit: =20 commit 2ecee236752932672fb3d6cd63c6976927f747d8 CommitDate: Sun Feb 12 05:46:44 2023 +0000 =20 gdb: use -1 for breakpoint::task default value =20 Failed to take account of an earlier commit: =20 commit f1f517e81039f6aa673b7d87a66bfbd25a66e3d3 CommitDate: Sat Feb 11 17:36:24 2023 +0000 =20 gdb: show task number in describe_other_breakpoints =20 That both of these are my own commits is only more embarrassing. =20 This small fix updates describe_other_breakpoints to take account of the default task number now being -1. This fixes regressions in gdb.base/break.exp, gdb.base/break-always.exp, and many other tests. Diff: --- gdb/breakpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 4b0a909d60c..97dee5cd0fe 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -7057,7 +7057,7 @@ describe_other_breakpoints (struct gdbarch *gdbarch, struct thread_info *thr =3D find_thread_global_id (b->thread); gdb_printf (" (thread %s)", print_thread_id (thr)); } - else if (b->task !=3D 0) + else if (b->task !=3D -1) gdb_printf (" (task %d)", b->task); gdb_printf ("%s%s ", ((b->enable_state =3D=3D bp_disabled