public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom Tromey <tromey@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] Fully qualify calls to copy in value.c
Date: Mon, 13 Feb 2023 22:30:11 +0000 (GMT)	[thread overview]
Message-ID: <20230213223011.D53623858C2C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e18312bb596fcc9b4df1d018038690df28a68b46

commit e18312bb596fcc9b4df1d018038690df28a68b46
Author: Tom Tromey <tom@tromey.com>
Date:   Tue Jan 31 14:51:24 2023 -0700

    Fully qualify calls to copy in value.c
    
    A coming patch will add value::copy, so this namespace-qualifies
    existing calls to 'copy' in value.c, to ensure it will still compile
    after that change is done.
    
    Approved-By: Simon Marchi <simon.marchi@efficios.com>

Diff:
---
 gdb/value.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/value.c b/gdb/value.c
index 23453e82ce5..804444221ba 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -1216,7 +1216,7 @@ value_contents_copy_raw (struct value *dst, LONGEST dst_offset,
   gdb::array_view<const gdb_byte> src_contents
     = src->contents_all_raw ().slice (src_offset * unit_size,
 					  length * unit_size);
-  copy (src_contents, dst_contents);
+  gdb::copy (src_contents, dst_contents);
 
   /* Copy the meta-data, adjusted.  */
   src_bit_offset = src_offset * unit_size * HOST_CHAR_BIT;
@@ -1562,7 +1562,7 @@ value_copy (const value *arg)
       gdb::array_view<gdb_byte> val_contents
 	= val->contents_all_raw ().slice (0, length);
 
-      copy (arg_view, val_contents);
+      gdb::copy (arg_view, val_contents);
     }
 
   if (VALUE_LVAL (val) == lval_computed)
@@ -1604,7 +1604,7 @@ value_non_lval (struct value *arg)
       struct type *enc_type = arg->enclosing_type ();
       struct value *val = value::allocate (enc_type);
 
-      copy (arg->contents_all (), val->contents_all_raw ());
+      gdb::copy (arg->contents_all (), val->contents_all_raw ());
       val->m_type = arg->m_type;
       val->set_embedded_offset (arg->embedded_offset ());
       val->set_pointed_to_offset (arg->pointed_to_offset ());

                 reply	other threads:[~2023-02-13 22:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213223011.D53623858C2C@sourceware.org \
    --to=tromey@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).