public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Simon Marchi <simark@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: cast return value of std::unique_ptr::release to void Date: Tue, 14 Feb 2023 19:29:37 +0000 (GMT) [thread overview] Message-ID: <20230214192937.1C3F2385840D@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8eaecfb37c8ece7396303dd3122def526a223d70 commit 8eaecfb37c8ece7396303dd3122def526a223d70 Author: Simon Marchi <simon.marchi@efficios.com> Date: Mon Feb 13 14:55:13 2023 -0500 gdb: cast return value of std::unique_ptr::release to void My editor shows warnings like: value.c:2784: warning: The value returned by this function should be used value.c:2784: note: cast the expression to void to silence this warning [bugprone-unused-return-value] These warnings come from clangd, so ultimately from one of the clang static analyzers (probably clang-tidy). Silence these warnings by casting to void. Add a comment to explain why this unusual thing is done. Change-Id: I58323959c0baf9f1b20a8d596e4c58dc77c6809a Approved-By: Tom Tromey <tom@tromey.com> Diff: --- gdb/value.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gdb/value.c b/gdb/value.c index 7873aeb9558..6597d0fe4ef 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -2347,9 +2347,12 @@ add_internal_function (gdb::unique_xmalloc_ptr<char> &&name, { struct cmd_list_element *cmd = do_add_internal_function (name.get (), doc.get (), handler, cookie); - doc.release (); + + /* Manually transfer the ownership of the doc and name strings to CMD by + setting the appropriate flags. */ + (void) doc.release (); cmd->doc_allocated = 1; - name.release (); + (void) name.release (); cmd->name_allocated = 1; }
reply other threads:[~2023-02-14 19:29 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230214192937.1C3F2385840D@sourceware.org \ --to=simark@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).