public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Felix Willgerodt <fwillger@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] gdb, fortran: Fix quad floating-point type for ifort compiler.
Date: Wed, 15 Feb 2023 09:03:03 +0000 (GMT)	[thread overview]
Message-ID: <20230215090303.3DE3E3858D1E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ecbc5c4f9059dd483cf8b0705cbd4e2e9606aad5

commit ecbc5c4f9059dd483cf8b0705cbd4e2e9606aad5
Author: Felix Willgerodt <felix.willgerodt@intel.com>
Date:   Mon Feb 13 11:02:23 2023 +0100

    gdb, fortran: Fix quad floating-point type for ifort compiler.
    
    I fixed this a while ago for ifx, one of the two Intel compilers, in
    8d624a9d8050ca96e154215c7858ac5c2d8b0b19.
    
    Apparently I missed that the older ifort Intel compiler actually emits
    slightly different debug info again:
    
    0x0000007a:   DW_TAG_base_type
                    DW_AT_byte_size (0x20)
                    DW_AT_encoding  (DW_ATE_complex_float)
                    DW_AT_name      ("COMPLEX(16)")
    
    0x00000081:   DW_TAG_base_type
                    DW_AT_byte_size (0x10)
                    DW_AT_encoding  (DW_ATE_float)
                    DW_AT_name      ("REAL(16)")
    
    This fixes two failures in gdb.fortran/complex.exp with ifort.
    
    Approved-By: Tom Tromey <tom@tromey.com>

Diff:
---
 gdb/i386-tdep.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index da4950ac259..acf22dba98d 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -8238,12 +8238,14 @@ i386_floatformat_for_type (struct gdbarch *gdbarch,
 	|| strcmp (name, "_Float128") == 0
 	|| strcmp (name, "complex _Float128") == 0
 	|| strcmp (name, "complex(kind=16)") == 0
+	|| strcmp (name, "COMPLEX(16)") == 0
 	|| strcmp (name, "complex*32") == 0
 	|| strcmp (name, "COMPLEX*32") == 0
 	|| strcmp (name, "quad complex") == 0
 	|| strcmp (name, "real(kind=16)") == 0
 	|| strcmp (name, "real*16") == 0
-	|| strcmp (name, "REAL*16") == 0)
+	|| strcmp (name, "REAL*16") == 0
+	|| strcmp (name, "REAL(16)") == 0)
       return floatformats_ieee_quad;
 
   return default_floatformat_for_type (gdbarch, name, len);

                 reply	other threads:[~2023-02-15  9:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230215090303.3DE3E3858D1E@sourceware.org \
    --to=fwillger@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).