From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1879) id 2D2DB3858439; Wed, 15 Feb 2023 17:00:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2D2DB3858439 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676480420; bh=myaoKUvjQXqOE7IHal5lQfO8fFx7zZzt44VfRXhntas=; h=From:To:Subject:Date:From; b=Rpv25wY+QsFLRHsjN4ESXqJhMOLZsyTffCFtxnj9VDbqFqE/JPxOOVkJMHb4saDgf 7uP/UG3f4h42WZmvJPs/QwND3ECH2LiXkO3PfO/Y12r5q0bw5ApQJ6uNTX5XuPWgyX BGxRtbayiX+EtFgBHZra/kziL0XzJPEe60BHhpSY= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Simon Marchi To: gdb-cvs@sourceware.org Subject: [binutils-gdb] gdb: add constructor to internalvar X-Act-Checkin: binutils-gdb X-Git-Author: Simon Marchi X-Git-Refname: refs/heads/master X-Git-Oldrev: f251cb9bae76441b43b3ea0b030086052eb54524 X-Git-Newrev: dbca589b8d72316a5884321747b6ab92c6b34dbc Message-Id: <20230215170020.2D2DB3858439@sourceware.org> Date: Wed, 15 Feb 2023 17:00:20 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Ddbca589b8d72= 316a5884321747b6ab92c6b34dbc commit dbca589b8d72316a5884321747b6ab92c6b34dbc Author: Simon Marchi Date: Tue Feb 14 14:23:26 2023 -0500 gdb: add constructor to internalvar =20 Add a constructor that takes the name as a parameter. Initialize the next and kind fields inline. =20 Change-Id: Ic4db0aba85f1da9f12f3eee0ac62c0e5ef0cfe88 Approved-By: Tom Tromey Diff: --- gdb/value.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/gdb/value.c b/gdb/value.c index 4b3ec771266..1b74a6ecc4f 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -1829,14 +1829,18 @@ union internalvar_data =20 struct internalvar { - struct internalvar *next; + internalvar (std::string name) + : name (std::move (name)) + {} + + struct internalvar *next =3D nullptr; std::string name; =20 /* We support various different kinds of content of an internal variable. enum internalvar_kind specifies the kind, and union internalvar_data provides the data associated with this particular kind. */ =20 - enum internalvar_kind kind; + enum internalvar_kind kind =3D INTERNALVAR_VOID; =20 union internalvar_data u; }; @@ -1922,10 +1926,8 @@ complete_internalvar (completion_tracker &tracker, c= onst char *name) struct internalvar * create_internalvar (const char *name) { - internalvar *var =3D new internalvar; + internalvar *var =3D new internalvar (name); =20 - var->name =3D name; - var->kind =3D INTERNALVAR_VOID; var->next =3D internalvars; internalvars =3D var; return var;