From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2126) id C382938582B0; Wed, 15 Feb 2023 22:09:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C382938582B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1676498963; bh=HtdvNzdUag6kpKp+hOEBahQiYbB6DKzHr0N3WjDqxXA=; h=From:To:Subject:Date:From; b=VgwN+kL8HFa90mmt526vLZdi87TNFVqhXKpRWnZ8OZANOAkFWXR/Zm062UMPDjoMQ zTHK1150QH67BVyl6vyi4AIULClNLMAPkMWf8bdpFZ+etge1G/8TO3GAEVX5utmSdp dxEUXb0e3y0v85iZ+fC/OnHY4hZDH/mFsCERgSRI= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Tom Tromey To: gdb-cvs@sourceware.org Subject: [binutils-gdb] Change value::m_stack to bool X-Act-Checkin: binutils-gdb X-Git-Author: Tom Tromey X-Git-Refname: refs/heads/master X-Git-Oldrev: a7c27481a077a32c5a7c5bce11904a60dcec7feb X-Git-Newrev: 42c13555ff880d8efeb89430c559b553e09e5311 Message-Id: <20230215220923.C382938582B0@sourceware.org> Date: Wed, 15 Feb 2023 22:09:23 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D42c13555ff88= 0d8efeb89430c559b553e09e5311 commit 42c13555ff880d8efeb89430c559b553e09e5311 Author: Tom Tromey Date: Tue Feb 14 09:43:26 2023 -0700 Change value::m_stack to bool =20 This changes value::m_stack to be a bool and updates the various uses. =20 Reviewed-By: Bruno Larsen Diff: --- gdb/dwarf2/expr.c | 2 +- gdb/frame-unwind.c | 2 +- gdb/valops.c | 2 +- gdb/value.c | 2 +- gdb/value.h | 10 +++++----- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c index 760c5c4b0d0..3f040e7b2d3 100644 --- a/gdb/dwarf2/expr.c +++ b/gdb/dwarf2/expr.c @@ -1005,7 +1005,7 @@ dwarf_expr_context::fetch_result (struct type *type, = struct type *subobj_type, retval =3D value_at_lazy (subobj_type, address + subobj_offset); if (in_stack_memory) - retval->set_stack (1); + retval->set_stack (true); } break; =20 diff --git a/gdb/frame-unwind.c b/gdb/frame-unwind.c index e5f8dc639e3..a3673dde77a 100644 --- a/gdb/frame-unwind.c +++ b/gdb/frame-unwind.c @@ -289,7 +289,7 @@ frame_unwind_got_memory (frame_info_ptr frame, int regn= um, CORE_ADDR addr) struct gdbarch *gdbarch =3D frame_unwind_arch (frame); struct value *v =3D value_at_lazy (register_type (gdbarch, regnum), addr= ); =20 - v->set_stack (1); + v->set_stack (true); return v; } =20 diff --git a/gdb/valops.c b/gdb/valops.c index 90f7b8c5532..3a1b14c3d44 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -1041,7 +1041,7 @@ value_at_lazy (struct type *type, CORE_ADDR addr) =20 void read_value_memory (struct value *val, LONGEST bit_offset, - int stack, CORE_ADDR memaddr, + bool stack, CORE_ADDR memaddr, gdb_byte *buffer, size_t length) { ULONGEST xfered_total =3D 0; diff --git a/gdb/value.c b/gdb/value.c index ee35f705228..bf285a9d50c 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -3749,7 +3749,7 @@ value::fetch_lazy_memory () gdb_assert (len >=3D 0); =20 if (len > 0) - read_value_memory (this, 0, stack (), addr, + read_value_memory (this, false, stack (), addr, contents_all_raw ().data (), len); } =20 diff --git a/gdb/value.h b/gdb/value.h index 41327ebe3b8..4cb6fac4104 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -135,7 +135,7 @@ private: : m_modifiable (true), m_lazy (true), m_initialized (true), - m_stack (0), + m_stack (false), m_is_zero (false), m_in_history (false), m_type (type_), @@ -314,10 +314,10 @@ public: =20 void set_enclosing_type (struct type *new_type); =20 - int stack () const + bool stack () const { return m_stack; } =20 - void set_stack (int val) + void set_stack (bool val) { m_stack =3D val; } =20 /* If this value is lval_computed, return its lval_funcs @@ -642,7 +642,7 @@ private: =20 /* If value is from the stack. If this is set, read_stack will be used instead of read_memory to enable extra caching. */ - unsigned int m_stack : 1; + bool m_stack : 1; =20 /* True if this is a zero value, created by 'value::zero'; false otherwise. */ @@ -1000,7 +1000,7 @@ extern struct value *coerce_array (struct value *valu= e); whether the memory is known to be stack memory. */ =20 extern void read_value_memory (struct value *val, LONGEST bit_offset, - int stack, CORE_ADDR memaddr, + bool stack, CORE_ADDR memaddr, gdb_byte *buffer, size_t length); =20 /* Cast SCALAR_VALUE to the element type of VECTOR_TYPE, then replicate