public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Require istarget x86* in gdb.reverse/step-indirect-call-thunk.exp
@ 2023-02-21 14:06 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2023-02-21 14:06 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=2ef339e38f51906a394105fe545058fec1f9bc4a

commit 2ef339e38f51906a394105fe545058fec1f9bc4a
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Feb 21 15:06:50 2023 +0100

    [gdb/testsuite] Require istarget x86* in gdb.reverse/step-indirect-call-thunk.exp
    
    On aarch64-linux, I run into:
    ...
    Running gdb.reverse/step-indirect-call-thunk.exp ...
    gdb compile failed, gcc: error: unrecognized command line option \
      '-mindirect-branch=thunk'; did you mean '-findirect-inlining'?
    gcc: error: unrecognized command line option '-mfunction-return=thunk'; \
      did you mean '-Wfunction-elimination'?
    UNTESTED: gdb.reverse/step-indirect-call-thunk.exp: failed to prepare
    ...
    
    Fix this by requiring istarget "x86*", similar to what was added in
    gdb.base/step-indirect-call-thunk.exp by commit 43127ae5714 ("Fix
    gdb.base/step-indirect-call-thunk.exp"), such that we have instead:
    ...
    UNSUPPORTED: gdb.reverse/step-indirect-call-thunk.exp: require failed: \
      istarget "x86*
    ...
    
    Tested on x86_64-linux and aarch64-linux.

Diff:
---
 gdb/testsuite/gdb.reverse/step-indirect-call-thunk.exp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/testsuite/gdb.reverse/step-indirect-call-thunk.exp b/gdb/testsuite/gdb.reverse/step-indirect-call-thunk.exp
index 94292d5eb9b..f433efb11c2 100644
--- a/gdb/testsuite/gdb.reverse/step-indirect-call-thunk.exp
+++ b/gdb/testsuite/gdb.reverse/step-indirect-call-thunk.exp
@@ -15,6 +15,8 @@
 
 require supports_reverse
 
+require {istarget "x86*"}
+
 standard_testfile
 
 set cflags {}

^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2023-02-21 14:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-21 14:06 [binutils-gdb] [gdb/testsuite] Require istarget x86* in gdb.reverse/step-indirect-call-thunk.exp Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).